All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org,
	mirq-linux@rere.qmqm.pl, gustavoars@kernel.org
Subject: Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones
Date: Tue, 23 Mar 2021 13:15:42 +0100	[thread overview]
Message-ID: <a0c862ec-44ba-52e0-551c-0347166ac4e9@perex.cz> (raw)
In-Reply-To: <20210323114327.3969072-1-codrin.ciubotariu@microchip.com>

Dne 23. 03. 21 v 12:43 Codrin Ciubotariu napsal(a):

> To achieve this, the first thing needed is to detect whether a HW
> constraint rule is enforced by a FE or a BE DAI. This means that
> snd_pcm_hw_rule_add() needs to be able to differentiate between the two
> type of DAIs. For this, the runtime pointer to struct snd_pcm_runtime is
> replaced with a pointer to struct snd_pcm_substream, to be able to reach
> substream->pcm->internal to differentiate between FE and BE DAIs.

Think about other not-so-invasive solution. What about to use
'runtime->private_data' (struct snd_soc_pcm_runtime *) to determine FE / BE?

					Jaroslav
-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

WARNING: multiple messages have this Message-ID (diff)
From: Jaroslav Kysela <perex@perex.cz>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: gustavoars@kernel.org, mirq-linux@rere.qmqm.pl,
	broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones
Date: Tue, 23 Mar 2021 13:15:42 +0100	[thread overview]
Message-ID: <a0c862ec-44ba-52e0-551c-0347166ac4e9@perex.cz> (raw)
In-Reply-To: <20210323114327.3969072-1-codrin.ciubotariu@microchip.com>

Dne 23. 03. 21 v 12:43 Codrin Ciubotariu napsal(a):

> To achieve this, the first thing needed is to detect whether a HW
> constraint rule is enforced by a FE or a BE DAI. This means that
> snd_pcm_hw_rule_add() needs to be able to differentiate between the two
> type of DAIs. For this, the runtime pointer to struct snd_pcm_runtime is
> replaced with a pointer to struct snd_pcm_substream, to be able to reach
> substream->pcm->internal to differentiate between FE and BE DAIs.

Think about other not-so-invasive solution. What about to use
'runtime->private_data' (struct snd_soc_pcm_runtime *) to determine FE / BE?

					Jaroslav
-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

  parent reply	other threads:[~2021-03-23 12:16 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 11:43 [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones Codrin Ciubotariu
2021-03-23 11:43 ` Codrin Ciubotariu
2021-03-23 11:43 ` [RFC PATCH 1/3] pcm: use substream instead of runtime in snd_pcm_hw_rule_add() Codrin Ciubotariu
2021-03-23 11:43   ` Codrin Ciubotariu
2021-03-23 11:43 ` [RFC PATCH 2/3] ASoC: soc-pcm: add hw_constraints for BE DAI links Codrin Ciubotariu
2021-03-23 11:43   ` Codrin Ciubotariu
2021-03-23 11:43 ` [RFC PATCH 3/3] ASoC: soc-pcm: apply BE HW constraint rules Codrin Ciubotariu
2021-03-23 11:43   ` Codrin Ciubotariu
2021-03-23 12:15 ` Jaroslav Kysela [this message]
2021-03-23 12:15   ` [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones Jaroslav Kysela
2021-03-23 14:18   ` Codrin.Ciubotariu
2021-03-23 14:18     ` Codrin.Ciubotariu
2021-04-14 14:58     ` Codrin.Ciubotariu
2021-04-14 14:58       ` Codrin.Ciubotariu
2021-04-15 16:17       ` Mark Brown
2021-04-15 16:17         ` Mark Brown
2021-04-15 16:56         ` Codrin.Ciubotariu
2021-04-15 16:56           ` Codrin.Ciubotariu
2021-04-15 17:25           ` Mark Brown
2021-04-15 17:25             ` Mark Brown
2021-04-16 16:03             ` Codrin.Ciubotariu
2021-04-16 16:03               ` Codrin.Ciubotariu
2021-04-16 16:31               ` Mark Brown
2021-04-16 16:31                 ` Mark Brown
2021-04-16 16:47                 ` Pierre-Louis Bossart
2021-04-16 16:47                   ` Pierre-Louis Bossart
2021-04-16 18:55                   ` Mark Brown
2021-04-16 18:55                     ` Mark Brown
2021-04-16 19:39                     ` Pierre-Louis Bossart
2021-04-16 19:39                       ` Pierre-Louis Bossart
2021-04-19 15:07                       ` Mark Brown
2021-04-19 15:07                         ` Mark Brown
2021-04-16 17:39                 ` Codrin.Ciubotariu
2021-04-16 17:39                   ` Codrin.Ciubotariu
2021-03-23 19:25 ` Pierre-Louis Bossart
2021-03-23 19:25   ` Pierre-Louis Bossart
2021-03-24  9:51   ` Codrin.Ciubotariu
2021-03-24  9:51     ` Codrin.Ciubotariu
2021-03-24 15:28     ` Pierre-Louis Bossart
2021-03-24 15:28       ` Pierre-Louis Bossart
2021-03-24 17:12       ` Codrin.Ciubotariu
2021-03-24 17:12         ` Codrin.Ciubotariu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0c862ec-44ba-52e0-551c-0347166ac4e9@perex.cz \
    --to=perex@perex.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=gustavoars@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.