From: gengdongjiu <gengdongjiu@huawei.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: <pbonzini@redhat.com>, <imammedo@redhat.com>, <shannon.zhaosl@gmail.com>, <peter.maydell@linaro.org>, <lersek@redhat.com>, <james.morse@arm.com>, <mtosatti@redhat.com>, <rth@twiddle.net>, <ehabkost@redhat.com>, <zhengxiang9@huawei.com>, <jonathan.cameron@huawei.com>, <xuwei5@huawei.com>, <kvm@vger.kernel.org>, <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>, <linuxarm@huawei.com> Subject: Re: [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Date: Thu, 30 May 2019 22:58:23 +0800 [thread overview] Message-ID: <a0cad169-0dae-8525-f36f-2b88e418791e@huawei.com> (raw) In-Reply-To: <20190528233859-mutt-send-email-mst@kernel.org> On 2019/5/29 11:40, Michael S. Tsirkin wrote: > On Tue, May 14, 2019 at 04:18:15AM -0700, Dongjiu Geng wrote: >> Add Generic Error Status Block structures and some macros >> definitions, which is referred to the ACPI 4.0 or ACPI 6.2. The >> HEST table generation and CPER record will use them. >> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> > > Are these all still used? I'd rather you moved stuff to > where it's used. Ok, I will move them, thanks > > > >> --- >> include/hw/acpi/acpi-defs.h | 52 +++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> >> diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h >> index f9aa4bd..d1996fb 100644 >> --- a/include/hw/acpi/acpi-defs.h >> +++ b/include/hw/acpi/acpi-defs.h >> @@ -224,6 +224,25 @@ typedef struct AcpiMultipleApicTable AcpiMultipleApicTable; >> #define ACPI_APIC_RESERVED 16 /* 16 and greater are reserved */ >> >> /* >> + * Values for Hardware Error Notification Type field >> + */ >> +enum AcpiHestNotifyType { >> + ACPI_HEST_NOTIFY_POLLED = 0, >> + ACPI_HEST_NOTIFY_EXTERNAL = 1, >> + ACPI_HEST_NOTIFY_LOCAL = 2, >> + ACPI_HEST_NOTIFY_SCI = 3, >> + ACPI_HEST_NOTIFY_NMI = 4, >> + ACPI_HEST_NOTIFY_CMCI = 5, /* ACPI 5.0: 18.3.2.7, Table 18-290 */ >> + ACPI_HEST_NOTIFY_MCE = 6, /* ACPI 5.0: 18.3.2.7, Table 18-290 */ >> + ACPI_HEST_NOTIFY_GPIO = 7, /* ACPI 6.0: 18.3.2.7, Table 18-332 */ >> + ACPI_HEST_NOTIFY_SEA = 8, /* ACPI 6.1: 18.3.2.9, Table 18-345 */ >> + ACPI_HEST_NOTIFY_SEI = 9, /* ACPI 6.1: 18.3.2.9, Table 18-345 */ >> + ACPI_HEST_NOTIFY_GSIV = 10, /* ACPI 6.1: 18.3.2.9, Table 18-345 */ >> + ACPI_HEST_NOTIFY_SDEI = 11, /* ACPI 6.2: 18.3.2.9, Table 18-383 */ >> + ACPI_HEST_NOTIFY_RESERVED = 12 /* 12 and greater are reserved */ >> +}; >> + > > If there's a single user, the best thing to do > is just to open-code with a comment that matches > spec names. It's hard to find stuff like ACPI_HEST_NOTIFY_GSIV > in a spec. ok, I will do it, thanks > >> +/* >> * MADT sub-structures (Follow MULTIPLE_APIC_DESCRIPTION_TABLE) >> */ >> #define ACPI_SUB_HEADER_DEF /* Common ACPI sub-structure header */\ >> @@ -400,6 +419,39 @@ struct AcpiSystemResourceAffinityTable { >> } QEMU_PACKED; >> typedef struct AcpiSystemResourceAffinityTable AcpiSystemResourceAffinityTable; >> >> +/* >> + * Generic Error Status Block >> + */ >> +struct AcpiGenericErrorStatus { >> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ >> + uint32_t block_status; >> + uint32_t raw_data_offset; >> + uint32_t raw_data_length; >> + uint32_t data_length; >> + uint32_t error_severity; >> +} QEMU_PACKED; >> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; >> + >> +/* >> + * Masks for block_status flags above >> + */ >> +#define ACPI_GEBS_UNCORRECTABLE 1 >> + >> +/* >> + * Values for error_severity field above >> + */ >> +enum AcpiGenericErrorSeverity { >> + ACPI_CPER_SEV_RECOVERABLE, >> + ACPI_CPER_SEV_FATAL, >> + ACPI_CPER_SEV_CORRECTED, >> + ACPI_CPER_SEV_NONE, >> +}; >> + >> +/* >> + * Generic Hardware Error Source version 2 >> + */ >> +#define ACPI_HEST_SOURCE_GENERIC_ERROR_V2 10 >> + >> #define ACPI_SRAT_PROCESSOR_APIC 0 >> #define ACPI_SRAT_MEMORY 1 >> #define ACPI_SRAT_PROCESSOR_x2APIC 2 >> -- >> 1.8.3.1 > . >
WARNING: multiple messages have this Message-ID (diff)
From: gengdongjiu <gengdongjiu@huawei.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com, jonathan.cameron@huawei.com, imammedo@redhat.com, pbonzini@redhat.com, xuwei5@huawei.com, lersek@redhat.com, rth@twiddle.net Subject: Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Date: Thu, 30 May 2019 22:58:23 +0800 [thread overview] Message-ID: <a0cad169-0dae-8525-f36f-2b88e418791e@huawei.com> (raw) In-Reply-To: <20190528233859-mutt-send-email-mst@kernel.org> On 2019/5/29 11:40, Michael S. Tsirkin wrote: > On Tue, May 14, 2019 at 04:18:15AM -0700, Dongjiu Geng wrote: >> Add Generic Error Status Block structures and some macros >> definitions, which is referred to the ACPI 4.0 or ACPI 6.2. The >> HEST table generation and CPER record will use them. >> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> > > Are these all still used? I'd rather you moved stuff to > where it's used. Ok, I will move them, thanks > > > >> --- >> include/hw/acpi/acpi-defs.h | 52 +++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> >> diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h >> index f9aa4bd..d1996fb 100644 >> --- a/include/hw/acpi/acpi-defs.h >> +++ b/include/hw/acpi/acpi-defs.h >> @@ -224,6 +224,25 @@ typedef struct AcpiMultipleApicTable AcpiMultipleApicTable; >> #define ACPI_APIC_RESERVED 16 /* 16 and greater are reserved */ >> >> /* >> + * Values for Hardware Error Notification Type field >> + */ >> +enum AcpiHestNotifyType { >> + ACPI_HEST_NOTIFY_POLLED = 0, >> + ACPI_HEST_NOTIFY_EXTERNAL = 1, >> + ACPI_HEST_NOTIFY_LOCAL = 2, >> + ACPI_HEST_NOTIFY_SCI = 3, >> + ACPI_HEST_NOTIFY_NMI = 4, >> + ACPI_HEST_NOTIFY_CMCI = 5, /* ACPI 5.0: 18.3.2.7, Table 18-290 */ >> + ACPI_HEST_NOTIFY_MCE = 6, /* ACPI 5.0: 18.3.2.7, Table 18-290 */ >> + ACPI_HEST_NOTIFY_GPIO = 7, /* ACPI 6.0: 18.3.2.7, Table 18-332 */ >> + ACPI_HEST_NOTIFY_SEA = 8, /* ACPI 6.1: 18.3.2.9, Table 18-345 */ >> + ACPI_HEST_NOTIFY_SEI = 9, /* ACPI 6.1: 18.3.2.9, Table 18-345 */ >> + ACPI_HEST_NOTIFY_GSIV = 10, /* ACPI 6.1: 18.3.2.9, Table 18-345 */ >> + ACPI_HEST_NOTIFY_SDEI = 11, /* ACPI 6.2: 18.3.2.9, Table 18-383 */ >> + ACPI_HEST_NOTIFY_RESERVED = 12 /* 12 and greater are reserved */ >> +}; >> + > > If there's a single user, the best thing to do > is just to open-code with a comment that matches > spec names. It's hard to find stuff like ACPI_HEST_NOTIFY_GSIV > in a spec. ok, I will do it, thanks > >> +/* >> * MADT sub-structures (Follow MULTIPLE_APIC_DESCRIPTION_TABLE) >> */ >> #define ACPI_SUB_HEADER_DEF /* Common ACPI sub-structure header */\ >> @@ -400,6 +419,39 @@ struct AcpiSystemResourceAffinityTable { >> } QEMU_PACKED; >> typedef struct AcpiSystemResourceAffinityTable AcpiSystemResourceAffinityTable; >> >> +/* >> + * Generic Error Status Block >> + */ >> +struct AcpiGenericErrorStatus { >> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ >> + uint32_t block_status; >> + uint32_t raw_data_offset; >> + uint32_t raw_data_length; >> + uint32_t data_length; >> + uint32_t error_severity; >> +} QEMU_PACKED; >> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; >> + >> +/* >> + * Masks for block_status flags above >> + */ >> +#define ACPI_GEBS_UNCORRECTABLE 1 >> + >> +/* >> + * Values for error_severity field above >> + */ >> +enum AcpiGenericErrorSeverity { >> + ACPI_CPER_SEV_RECOVERABLE, >> + ACPI_CPER_SEV_FATAL, >> + ACPI_CPER_SEV_CORRECTED, >> + ACPI_CPER_SEV_NONE, >> +}; >> + >> +/* >> + * Generic Hardware Error Source version 2 >> + */ >> +#define ACPI_HEST_SOURCE_GENERIC_ERROR_V2 10 >> + >> #define ACPI_SRAT_PROCESSOR_APIC 0 >> #define ACPI_SRAT_MEMORY 1 >> #define ACPI_SRAT_PROCESSOR_x2APIC 2 >> -- >> 1.8.3.1 > . >
next prev parent reply other threads:[~2019-05-30 14:58 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 11:18 [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-14 11:18 ` [PATCH v17 01/10] hw/arm/virt: Add RAS platform version for migration Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-20 12:04 ` Igor Mammedov 2019-06-20 12:04 ` [Qemu-devel] " Igor Mammedov 2019-06-24 12:19 ` gengdongjiu 2019-06-24 12:19 ` [Qemu-devel] " gengdongjiu 2019-06-25 13:16 ` Igor Mammedov 2019-06-25 13:16 ` [Qemu-devel] " Igor Mammedov 2019-06-25 13:29 ` gengdongjiu 2019-06-25 13:29 ` [Qemu-devel] " gengdongjiu 2019-05-14 11:18 ` [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-29 3:40 ` Michael S. Tsirkin 2019-05-29 3:40 ` [Qemu-devel] " Michael S. Tsirkin 2019-05-30 14:58 ` gengdongjiu [this message] 2019-05-30 14:58 ` gengdongjiu 2019-06-20 12:10 ` Igor Mammedov 2019-06-20 12:10 ` Igor Mammedov 2019-06-20 14:04 ` gengdongjiu 2019-06-20 14:04 ` gengdongjiu 2019-06-20 15:09 ` Igor Mammedov 2019-06-20 15:09 ` Igor Mammedov 2019-06-20 17:17 ` gengdongjiu 2019-06-20 17:17 ` gengdongjiu 2019-06-24 11:16 ` Igor Mammedov 2019-06-24 11:16 ` Igor Mammedov 2019-06-25 9:56 ` gengdongjiu 2019-06-25 9:56 ` gengdongjiu 2019-06-25 13:33 ` Igor Mammedov 2019-06-25 13:33 ` Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 03/10] acpi: add build_append_ghes_notify() helper for Hardware Error Notification Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-24 11:21 ` Igor Mammedov 2019-06-24 11:21 ` [Qemu-devel] " Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 04/10] acpi: add build_append_ghes_generic_data() helper for Generic Error Data Entry Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-20 12:28 ` Igor Mammedov 2019-06-20 12:28 ` [Qemu-devel] " Igor Mammedov 2019-06-24 12:37 ` gengdongjiu 2019-06-24 12:37 ` [Qemu-devel] " gengdongjiu 2019-05-14 11:18 ` [PATCH v17 05/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-20 12:42 ` Igor Mammedov 2019-06-20 12:42 ` [Qemu-devel] " Igor Mammedov 2019-06-25 12:11 ` gengdongjiu 2019-06-25 12:11 ` [Qemu-devel] " gengdongjiu 2019-06-25 13:41 ` Igor Mammedov 2019-06-25 13:41 ` [Qemu-devel] " Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 06/10] docs: APEI GHES generation and CPER record description Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-24 11:39 ` Igor Mammedov 2019-06-24 11:39 ` [Qemu-devel] " Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 07/10] ACPI: Add APEI GHES table generation support Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-29 3:37 ` Michael S. Tsirkin 2019-05-29 3:37 ` [Qemu-devel] " Michael S. Tsirkin 2019-05-30 14:47 ` gengdongjiu 2019-05-30 14:47 ` [Qemu-devel] " gengdongjiu 2019-06-06 13:43 ` Jonathan Cameron 2019-06-06 13:43 ` [Qemu-devel] " Jonathan Cameron 2019-06-24 12:27 ` Igor Mammedov 2019-06-24 12:27 ` [Qemu-devel] " Igor Mammedov 2019-06-25 13:48 ` gengdongjiu 2019-06-25 13:48 ` [Qemu-devel] " gengdongjiu 2019-06-26 14:25 ` Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 08/10] KVM: Move related hwpoison page functions to accel/kvm/ folder Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-24 12:32 ` Igor Mammedov 2019-06-24 12:32 ` [Qemu-devel] " Igor Mammedov 2019-06-25 12:28 ` gengdongjiu 2019-06-25 12:28 ` [Qemu-devel] " gengdongjiu 2019-05-14 11:18 ` [PATCH v17 09/10] target-arm: kvm64: inject synchronous External Abort Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-14 11:18 ` [PATCH v17 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-06 13:31 ` Jonathan Cameron 2019-06-06 13:31 ` [Qemu-devel] " Jonathan Cameron 2019-06-24 13:08 ` Igor Mammedov 2019-06-24 13:08 ` [Qemu-devel] " Igor Mammedov 2019-06-25 12:24 ` gengdongjiu 2019-06-25 12:24 ` [Qemu-devel] " gengdongjiu 2019-06-25 13:32 ` Igor Mammedov 2019-06-25 13:32 ` [Qemu-devel] " Igor Mammedov 2019-05-15 9:40 ` [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU gengdongjiu 2019-05-15 9:40 ` [Qemu-devel] " gengdongjiu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a0cad169-0dae-8525-f36f-2b88e418791e@huawei.com \ --to=gengdongjiu@huawei.com \ --cc=ehabkost@redhat.com \ --cc=imammedo@redhat.com \ --cc=james.morse@arm.com \ --cc=jonathan.cameron@huawei.com \ --cc=kvm@vger.kernel.org \ --cc=lersek@redhat.com \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=shannon.zhaosl@gmail.com \ --cc=xuwei5@huawei.com \ --cc=zhengxiang9@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.