* [PATCH] media: usbvision: depends on USB
@ 2020-04-20 16:50 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2020-04-20 16:50 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Mauro Carvalho Chehab, Hans Verkuil, Greg Kroah-Hartman,
Thomas Gleixner, YueHaibing, devel, Stephen Rothwell,
Randy Dunlap
When built with:
CONFIG_USB=m
CONFIG_VIDEO_USBVISION=y
It causes ld errors:
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg_irq':
usbvision-core.c:(.text+0x8a4): undefined reference to `usb_submit_urb'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_isoc_irq':
usbvision-core.c:(.text+0x2ee8): undefined reference to `usb_submit_urb'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_read_reg':
usbvision-core.c:(.text+0x30ad): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg':
usbvision-core.c:(.text+0x3178): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_output':
usbvision-core.c:(.text+0x344e): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_input':
usbvision-core.c:(.text+0x3b9b): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_setup':
usbvision-core.c:(.text+0x4009): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o:usbvision-core.c:(.text+0x417f): more undefined references to `usb_control_msg' follow
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_alternate':
usbvision-core.c:(.text+0x4518): undefined reference to `usb_set_interface'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_init_isoc':
usbvision-core.c:(.text+0x4673): undefined reference to `usb_alloc_urb'
ld: usbvision-core.c:(.text+0x46a5): undefined reference to `usb_alloc_coherent'
ld: usbvision-core.c:(.text+0x4765): undefined reference to `usb_submit_urb'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_stop_isoc':
usbvision-core.c:(.text+0x4837): undefined reference to `usb_kill_urb'
ld: usbvision-core.c:(.text+0x485f): undefined reference to `usb_free_coherent'
ld: usbvision-core.c:(.text+0x4874): undefined reference to `usb_free_urb'
ld: usbvision-core.c:(.text+0x48f1): undefined reference to `usb_set_interface'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_release':
usbvision-video.c:(.text+0x1a8a): undefined reference to `usb_free_urb'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_disconnect':
usbvision-video.c:(.text+0x1b74): undefined reference to `usb_put_dev'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_radio_close':
usbvision-video.c:(.text+0x1c89): undefined reference to `usb_set_interface'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_probe':
usbvision-video.c:(.text+0x1e4b): undefined reference to `usb_get_dev'
ld: usbvision-video.c:(.text+0x20e1): undefined reference to `usb_alloc_urb'
ld: usbvision-video.c:(.text+0x2797): undefined reference to `usb_put_dev'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_exit':
usbvision-video.c:(.exit.text+0x37): undefined reference to `usb_deregister'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_init':
usbvision-video.c:(.init.text+0xf9): undefined reference to `usb_register_driver'
ld: drivers/staging/media/usbvision/usbvision-i2c.o: in function `usbvision_i2c_write':
usbvision-i2c.c:(.text+0x2f4): undefined reference to `usb_control_msg'
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/staging/media/usbvision/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/usbvision/Kconfig b/drivers/staging/media/usbvision/Kconfig
index c6e1afb5ac48..1c7da2a2caac 100644
--- a/drivers/staging/media/usbvision/Kconfig
+++ b/drivers/staging/media/usbvision/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_USBVISION
tristate "USB video devices based on Nogatech NT1003/1004/1005 (Deprecated)"
- depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2
+ depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2 && USB
select VIDEO_TUNER
select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
help
--
2.25.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] media: usbvision: depends on USB
@ 2020-04-20 16:50 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2020-04-20 16:50 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: devel, Stephen Rothwell, Mauro Carvalho Chehab,
Greg Kroah-Hartman, YueHaibing, Hans Verkuil, Thomas Gleixner
When built with:
CONFIG_USB=m
CONFIG_VIDEO_USBVISION=y
It causes ld errors:
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg_irq':
usbvision-core.c:(.text+0x8a4): undefined reference to `usb_submit_urb'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_isoc_irq':
usbvision-core.c:(.text+0x2ee8): undefined reference to `usb_submit_urb'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_read_reg':
usbvision-core.c:(.text+0x30ad): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg':
usbvision-core.c:(.text+0x3178): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_output':
usbvision-core.c:(.text+0x344e): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_input':
usbvision-core.c:(.text+0x3b9b): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_setup':
usbvision-core.c:(.text+0x4009): undefined reference to `usb_control_msg'
ld: drivers/staging/media/usbvision/usbvision-core.o:usbvision-core.c:(.text+0x417f): more undefined references to `usb_control_msg' follow
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_alternate':
usbvision-core.c:(.text+0x4518): undefined reference to `usb_set_interface'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_init_isoc':
usbvision-core.c:(.text+0x4673): undefined reference to `usb_alloc_urb'
ld: usbvision-core.c:(.text+0x46a5): undefined reference to `usb_alloc_coherent'
ld: usbvision-core.c:(.text+0x4765): undefined reference to `usb_submit_urb'
ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_stop_isoc':
usbvision-core.c:(.text+0x4837): undefined reference to `usb_kill_urb'
ld: usbvision-core.c:(.text+0x485f): undefined reference to `usb_free_coherent'
ld: usbvision-core.c:(.text+0x4874): undefined reference to `usb_free_urb'
ld: usbvision-core.c:(.text+0x48f1): undefined reference to `usb_set_interface'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_release':
usbvision-video.c:(.text+0x1a8a): undefined reference to `usb_free_urb'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_disconnect':
usbvision-video.c:(.text+0x1b74): undefined reference to `usb_put_dev'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_radio_close':
usbvision-video.c:(.text+0x1c89): undefined reference to `usb_set_interface'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_probe':
usbvision-video.c:(.text+0x1e4b): undefined reference to `usb_get_dev'
ld: usbvision-video.c:(.text+0x20e1): undefined reference to `usb_alloc_urb'
ld: usbvision-video.c:(.text+0x2797): undefined reference to `usb_put_dev'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_exit':
usbvision-video.c:(.exit.text+0x37): undefined reference to `usb_deregister'
ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_init':
usbvision-video.c:(.init.text+0xf9): undefined reference to `usb_register_driver'
ld: drivers/staging/media/usbvision/usbvision-i2c.o: in function `usbvision_i2c_write':
usbvision-i2c.c:(.text+0x2f4): undefined reference to `usb_control_msg'
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/staging/media/usbvision/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/usbvision/Kconfig b/drivers/staging/media/usbvision/Kconfig
index c6e1afb5ac48..1c7da2a2caac 100644
--- a/drivers/staging/media/usbvision/Kconfig
+++ b/drivers/staging/media/usbvision/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_USBVISION
tristate "USB video devices based on Nogatech NT1003/1004/1005 (Deprecated)"
- depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2
+ depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2 && USB
select VIDEO_TUNER
select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
help
--
2.25.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] media: usbvision: depends on USB
2020-04-20 16:50 ` Mauro Carvalho Chehab
@ 2020-04-20 17:41 ` Randy Dunlap
-1 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2020-04-20 17:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Media Mailing List
Cc: Hans Verkuil, Greg Kroah-Hartman, Thomas Gleixner, YueHaibing,
devel, Stephen Rothwell
On 4/20/20 9:50 AM, Mauro Carvalho Chehab wrote:
> When built with:
> CONFIG_USB=m
> CONFIG_VIDEO_USBVISION=y
>
> It causes ld errors:
>
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg_irq':
> usbvision-core.c:(.text+0x8a4): undefined reference to `usb_submit_urb'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_isoc_irq':
> usbvision-core.c:(.text+0x2ee8): undefined reference to `usb_submit_urb'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_read_reg':
> usbvision-core.c:(.text+0x30ad): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg':
> usbvision-core.c:(.text+0x3178): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_output':
> usbvision-core.c:(.text+0x344e): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_input':
> usbvision-core.c:(.text+0x3b9b): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_setup':
> usbvision-core.c:(.text+0x4009): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o:usbvision-core.c:(.text+0x417f): more undefined references to `usb_control_msg' follow
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_alternate':
> usbvision-core.c:(.text+0x4518): undefined reference to `usb_set_interface'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_init_isoc':
> usbvision-core.c:(.text+0x4673): undefined reference to `usb_alloc_urb'
> ld: usbvision-core.c:(.text+0x46a5): undefined reference to `usb_alloc_coherent'
> ld: usbvision-core.c:(.text+0x4765): undefined reference to `usb_submit_urb'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_stop_isoc':
> usbvision-core.c:(.text+0x4837): undefined reference to `usb_kill_urb'
> ld: usbvision-core.c:(.text+0x485f): undefined reference to `usb_free_coherent'
> ld: usbvision-core.c:(.text+0x4874): undefined reference to `usb_free_urb'
> ld: usbvision-core.c:(.text+0x48f1): undefined reference to `usb_set_interface'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_release':
> usbvision-video.c:(.text+0x1a8a): undefined reference to `usb_free_urb'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_disconnect':
> usbvision-video.c:(.text+0x1b74): undefined reference to `usb_put_dev'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_radio_close':
> usbvision-video.c:(.text+0x1c89): undefined reference to `usb_set_interface'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_probe':
> usbvision-video.c:(.text+0x1e4b): undefined reference to `usb_get_dev'
> ld: usbvision-video.c:(.text+0x20e1): undefined reference to `usb_alloc_urb'
> ld: usbvision-video.c:(.text+0x2797): undefined reference to `usb_put_dev'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_exit':
> usbvision-video.c:(.exit.text+0x37): undefined reference to `usb_deregister'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_init':
> usbvision-video.c:(.init.text+0xf9): undefined reference to `usb_register_driver'
> ld: drivers/staging/media/usbvision/usbvision-i2c.o: in function `usbvision_i2c_write':
> usbvision-i2c.c:(.text+0x2f4): undefined reference to `usb_control_msg'
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> drivers/staging/media/usbvision/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/usbvision/Kconfig b/drivers/staging/media/usbvision/Kconfig
> index c6e1afb5ac48..1c7da2a2caac 100644
> --- a/drivers/staging/media/usbvision/Kconfig
> +++ b/drivers/staging/media/usbvision/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config VIDEO_USBVISION
> tristate "USB video devices based on Nogatech NT1003/1004/1005 (Deprecated)"
> - depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2
> + depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2 && USB
> select VIDEO_TUNER
> select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
> help
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: usbvision: depends on USB
@ 2020-04-20 17:41 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2020-04-20 17:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Media Mailing List
Cc: devel, Stephen Rothwell, Greg Kroah-Hartman, YueHaibing,
Hans Verkuil, Thomas Gleixner
On 4/20/20 9:50 AM, Mauro Carvalho Chehab wrote:
> When built with:
> CONFIG_USB=m
> CONFIG_VIDEO_USBVISION=y
>
> It causes ld errors:
>
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg_irq':
> usbvision-core.c:(.text+0x8a4): undefined reference to `usb_submit_urb'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_isoc_irq':
> usbvision-core.c:(.text+0x2ee8): undefined reference to `usb_submit_urb'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_read_reg':
> usbvision-core.c:(.text+0x30ad): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg':
> usbvision-core.c:(.text+0x3178): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_output':
> usbvision-core.c:(.text+0x344e): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_input':
> usbvision-core.c:(.text+0x3b9b): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_setup':
> usbvision-core.c:(.text+0x4009): undefined reference to `usb_control_msg'
> ld: drivers/staging/media/usbvision/usbvision-core.o:usbvision-core.c:(.text+0x417f): more undefined references to `usb_control_msg' follow
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_alternate':
> usbvision-core.c:(.text+0x4518): undefined reference to `usb_set_interface'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_init_isoc':
> usbvision-core.c:(.text+0x4673): undefined reference to `usb_alloc_urb'
> ld: usbvision-core.c:(.text+0x46a5): undefined reference to `usb_alloc_coherent'
> ld: usbvision-core.c:(.text+0x4765): undefined reference to `usb_submit_urb'
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_stop_isoc':
> usbvision-core.c:(.text+0x4837): undefined reference to `usb_kill_urb'
> ld: usbvision-core.c:(.text+0x485f): undefined reference to `usb_free_coherent'
> ld: usbvision-core.c:(.text+0x4874): undefined reference to `usb_free_urb'
> ld: usbvision-core.c:(.text+0x48f1): undefined reference to `usb_set_interface'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_release':
> usbvision-video.c:(.text+0x1a8a): undefined reference to `usb_free_urb'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_disconnect':
> usbvision-video.c:(.text+0x1b74): undefined reference to `usb_put_dev'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_radio_close':
> usbvision-video.c:(.text+0x1c89): undefined reference to `usb_set_interface'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_probe':
> usbvision-video.c:(.text+0x1e4b): undefined reference to `usb_get_dev'
> ld: usbvision-video.c:(.text+0x20e1): undefined reference to `usb_alloc_urb'
> ld: usbvision-video.c:(.text+0x2797): undefined reference to `usb_put_dev'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_exit':
> usbvision-video.c:(.exit.text+0x37): undefined reference to `usb_deregister'
> ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_init':
> usbvision-video.c:(.init.text+0xf9): undefined reference to `usb_register_driver'
> ld: drivers/staging/media/usbvision/usbvision-i2c.o: in function `usbvision_i2c_write':
> usbvision-i2c.c:(.text+0x2f4): undefined reference to `usb_control_msg'
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> drivers/staging/media/usbvision/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/usbvision/Kconfig b/drivers/staging/media/usbvision/Kconfig
> index c6e1afb5ac48..1c7da2a2caac 100644
> --- a/drivers/staging/media/usbvision/Kconfig
> +++ b/drivers/staging/media/usbvision/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config VIDEO_USBVISION
> tristate "USB video devices based on Nogatech NT1003/1004/1005 (Deprecated)"
> - depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2
> + depends on MEDIA_USB_SUPPORT && I2C && VIDEO_V4L2 && USB
> select VIDEO_TUNER
> select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
> help
>
thanks.
--
~Randy
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: usbvision: depends on USB
2020-04-20 17:41 ` Randy Dunlap
@ 2020-04-20 19:38 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2020-04-20 19:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: Mauro Carvalho Chehab, Linux Media Mailing List, devel,
Stephen Rothwell, YueHaibing, Hans Verkuil, Thomas Gleixner
On Mon, Apr 20, 2020 at 10:41:28AM -0700, Randy Dunlap wrote:
> On 4/20/20 9:50 AM, Mauro Carvalho Chehab wrote:
> > When built with:
> > CONFIG_USB=m
> > CONFIG_VIDEO_USBVISION=y
> >
> > It causes ld errors:
> >
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg_irq':
> > usbvision-core.c:(.text+0x8a4): undefined reference to `usb_submit_urb'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_isoc_irq':
> > usbvision-core.c:(.text+0x2ee8): undefined reference to `usb_submit_urb'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_read_reg':
> > usbvision-core.c:(.text+0x30ad): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg':
> > usbvision-core.c:(.text+0x3178): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_output':
> > usbvision-core.c:(.text+0x344e): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_input':
> > usbvision-core.c:(.text+0x3b9b): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_setup':
> > usbvision-core.c:(.text+0x4009): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o:usbvision-core.c:(.text+0x417f): more undefined references to `usb_control_msg' follow
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_alternate':
> > usbvision-core.c:(.text+0x4518): undefined reference to `usb_set_interface'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_init_isoc':
> > usbvision-core.c:(.text+0x4673): undefined reference to `usb_alloc_urb'
> > ld: usbvision-core.c:(.text+0x46a5): undefined reference to `usb_alloc_coherent'
> > ld: usbvision-core.c:(.text+0x4765): undefined reference to `usb_submit_urb'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_stop_isoc':
> > usbvision-core.c:(.text+0x4837): undefined reference to `usb_kill_urb'
> > ld: usbvision-core.c:(.text+0x485f): undefined reference to `usb_free_coherent'
> > ld: usbvision-core.c:(.text+0x4874): undefined reference to `usb_free_urb'
> > ld: usbvision-core.c:(.text+0x48f1): undefined reference to `usb_set_interface'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_release':
> > usbvision-video.c:(.text+0x1a8a): undefined reference to `usb_free_urb'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_disconnect':
> > usbvision-video.c:(.text+0x1b74): undefined reference to `usb_put_dev'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_radio_close':
> > usbvision-video.c:(.text+0x1c89): undefined reference to `usb_set_interface'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_probe':
> > usbvision-video.c:(.text+0x1e4b): undefined reference to `usb_get_dev'
> > ld: usbvision-video.c:(.text+0x20e1): undefined reference to `usb_alloc_urb'
> > ld: usbvision-video.c:(.text+0x2797): undefined reference to `usb_put_dev'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_exit':
> > usbvision-video.c:(.exit.text+0x37): undefined reference to `usb_deregister'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_init':
> > usbvision-video.c:(.init.text+0xf9): undefined reference to `usb_register_driver'
> > ld: drivers/staging/media/usbvision/usbvision-i2c.o: in function `usbvision_i2c_write':
> > usbvision-i2c.c:(.text+0x2f4): undefined reference to `usb_control_msg'
> >
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: usbvision: depends on USB
@ 2020-04-20 19:38 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2020-04-20 19:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: devel, Stephen Rothwell, Mauro Carvalho Chehab, YueHaibing,
Hans Verkuil, Thomas Gleixner, Linux Media Mailing List
On Mon, Apr 20, 2020 at 10:41:28AM -0700, Randy Dunlap wrote:
> On 4/20/20 9:50 AM, Mauro Carvalho Chehab wrote:
> > When built with:
> > CONFIG_USB=m
> > CONFIG_VIDEO_USBVISION=y
> >
> > It causes ld errors:
> >
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg_irq':
> > usbvision-core.c:(.text+0x8a4): undefined reference to `usb_submit_urb'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_isoc_irq':
> > usbvision-core.c:(.text+0x2ee8): undefined reference to `usb_submit_urb'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_read_reg':
> > usbvision-core.c:(.text+0x30ad): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_write_reg':
> > usbvision-core.c:(.text+0x3178): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_output':
> > usbvision-core.c:(.text+0x344e): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_input':
> > usbvision-core.c:(.text+0x3b9b): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_setup':
> > usbvision-core.c:(.text+0x4009): undefined reference to `usb_control_msg'
> > ld: drivers/staging/media/usbvision/usbvision-core.o:usbvision-core.c:(.text+0x417f): more undefined references to `usb_control_msg' follow
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_set_alternate':
> > usbvision-core.c:(.text+0x4518): undefined reference to `usb_set_interface'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_init_isoc':
> > usbvision-core.c:(.text+0x4673): undefined reference to `usb_alloc_urb'
> > ld: usbvision-core.c:(.text+0x46a5): undefined reference to `usb_alloc_coherent'
> > ld: usbvision-core.c:(.text+0x4765): undefined reference to `usb_submit_urb'
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function `usbvision_stop_isoc':
> > usbvision-core.c:(.text+0x4837): undefined reference to `usb_kill_urb'
> > ld: usbvision-core.c:(.text+0x485f): undefined reference to `usb_free_coherent'
> > ld: usbvision-core.c:(.text+0x4874): undefined reference to `usb_free_urb'
> > ld: usbvision-core.c:(.text+0x48f1): undefined reference to `usb_set_interface'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_release':
> > usbvision-video.c:(.text+0x1a8a): undefined reference to `usb_free_urb'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_disconnect':
> > usbvision-video.c:(.text+0x1b74): undefined reference to `usb_put_dev'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_radio_close':
> > usbvision-video.c:(.text+0x1c89): undefined reference to `usb_set_interface'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_probe':
> > usbvision-video.c:(.text+0x1e4b): undefined reference to `usb_get_dev'
> > ld: usbvision-video.c:(.text+0x20e1): undefined reference to `usb_alloc_urb'
> > ld: usbvision-video.c:(.text+0x2797): undefined reference to `usb_put_dev'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_exit':
> > usbvision-video.c:(.exit.text+0x37): undefined reference to `usb_deregister'
> > ld: drivers/staging/media/usbvision/usbvision-video.o: in function `usbvision_init':
> > usbvision-video.c:(.init.text+0xf9): undefined reference to `usb_register_driver'
> > ld: drivers/staging/media/usbvision/usbvision-i2c.o: in function `usbvision_i2c_write':
> > usbvision-i2c.c:(.text+0x2f4): undefined reference to `usb_control_msg'
> >
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-20 19:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 16:50 [PATCH] media: usbvision: depends on USB Mauro Carvalho Chehab
2020-04-20 16:50 ` Mauro Carvalho Chehab
2020-04-20 17:41 ` Randy Dunlap
2020-04-20 17:41 ` Randy Dunlap
2020-04-20 19:38 ` Greg Kroah-Hartman
2020-04-20 19:38 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.