All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: james.hogan@imgtec.com, marc.zyngier@arm.com,
	kvm-ppc@vger.kernel.org, borntraeger@de.ibm.com,
	paulus@samba.org, cornelia.huck@de.ibm.com,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] KVM: race-free exit from KVM_RUN without POSIX signals
Date: Fri, 17 Feb 2017 10:40:29 +0100	[thread overview]
Message-ID: <a0f8d9bf-b438-a011-fe38-fa83a2733631@redhat.com> (raw)
In-Reply-To: <8a0f0818-07eb-c33e-9488-5a69c6bb67b1@redhat.com>



On 16/02/2017 20:26, David Hildenbrand wrote:
> As mentioned already on IRC, maybe something like "block_vcpu_run" would
> fit better now.

Hmm, the purpose of the flag is cause an immediate exit and it does do
so...  Surely incorrect (or just uncommon) usage will prevent a VCPU
from running, but that is just a side effect of the semantics, not the
intended usage.

Paolo

> But this is also ok and looks good to me.
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: james.hogan@imgtec.com, marc.zyngier@arm.com,
	kvm-ppc@vger.kernel.org, borntraeger@de.ibm.com,
	paulus@samba.org, cornelia.huck@de.ibm.com,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] KVM: race-free exit from KVM_RUN without POSIX signals
Date: Fri, 17 Feb 2017 09:40:29 +0000	[thread overview]
Message-ID: <a0f8d9bf-b438-a011-fe38-fa83a2733631@redhat.com> (raw)
In-Reply-To: <8a0f0818-07eb-c33e-9488-5a69c6bb67b1@redhat.com>



On 16/02/2017 20:26, David Hildenbrand wrote:
> As mentioned already on IRC, maybe something like "block_vcpu_run" would
> fit better now.

Hmm, the purpose of the flag is cause an immediate exit and it does do
so...  Surely incorrect (or just uncommon) usage will prevent a VCPU
from running, but that is just a side effect of the semantics, not the
intended usage.

Paolo

> But this is also ok and looks good to me.
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>


  reply	other threads:[~2017-02-17  9:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 14:43 [PATCH] KVM: race-free exit from KVM_RUN without POSIX signals Paolo Bonzini
2017-02-15 14:43 ` Paolo Bonzini
2017-02-15 14:43 ` Paolo Bonzini
2017-02-15 15:24 ` Christian Borntraeger
2017-02-15 15:24   ` Christian Borntraeger
2017-02-15 15:24   ` Christian Borntraeger
2017-02-15 15:56   ` Paolo Bonzini
2017-02-15 15:56     ` Paolo Bonzini
2017-02-16 16:19 ` Radim Krčmář
2017-02-16 16:19   ` Radim Krčmář
2017-02-16 19:26 ` David Hildenbrand
2017-02-16 19:26   ` David Hildenbrand
2017-02-16 19:26   ` David Hildenbrand
2017-02-17  9:40   ` Paolo Bonzini [this message]
2017-02-17  9:40     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0f8d9bf-b438-a011-fe38-fa83a2733631@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=david@redhat.com \
    --cc=james.hogan@imgtec.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.