From: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> Cc: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>, Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>, Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux-Renesas <linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Date: Fri, 8 Sep 2017 10:05:40 +0300 [thread overview] Message-ID: <a106fe34-d584-1560-797c-581ffc33a305@cogentembedded.com> (raw) In-Reply-To: <CAMuHMdUi9THE7nTd54C22K6kOo_Ye5LkhTrRZPNfcHfWCiBsUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Hi Geert, On 07.09.2017 13:58, Geert Uytterhoeven wrote: > Hi Vladimir, > > On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov > <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote: >> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a >> supported board. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> > Thanks for your patch! > >> --- a/Documentation/devicetree/bindings/arm/shmobile.txt >> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt >> @@ -85,6 +85,7 @@ Boards: >> - Lager (RTP0RC7790SEB00010S) >> compatible = "renesas,lager", "renesas,r8a7790" >> - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) >> + M3ULCB Kingfisher (SBEV-RCAR-KF-M03) > As the Kingfisher is an extension board (and you added the same board part > number to the H3ULCB section in patch 02/18), shouldn't it have its own > compatible value "shimafuji,kingfisher" instead? Thank you for this suggestion. This looks very meaningful for boards differentiation. > Then this can be used in ulcb-kf.dtsi: > > compatible = "shimafuji,kingfisher"; > > and appended (overridden, as there's no /append-property/ directive in dtc > yet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts: > > compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796"; > > Does that make sense? Yes. I will rework this in V2 patchset according to your suggestion. > >> compatible = "renesas,m3ulcb", "renesas,r8a7796"; >> - Marzen (R0P7779A00010S) >> compatible = "renesas,marzen", "renesas,r8a7779" > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Date: Fri, 8 Sep 2017 10:05:40 +0300 [thread overview] Message-ID: <a106fe34-d584-1560-797c-581ffc33a305@cogentembedded.com> (raw) In-Reply-To: <CAMuHMdUi9THE7nTd54C22K6kOo_Ye5LkhTrRZPNfcHfWCiBsUQ@mail.gmail.com> Hi Geert, On 07.09.2017 13:58, Geert Uytterhoeven wrote: > Hi Vladimir, > > On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov > <vladimir.barinov@cogentembedded.com> wrote: >> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a >> supported board. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > Thanks for your patch! > >> --- a/Documentation/devicetree/bindings/arm/shmobile.txt >> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt >> @@ -85,6 +85,7 @@ Boards: >> - Lager (RTP0RC7790SEB00010S) >> compatible = "renesas,lager", "renesas,r8a7790" >> - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) >> + M3ULCB Kingfisher (SBEV-RCAR-KF-M03) > As the Kingfisher is an extension board (and you added the same board part > number to the H3ULCB section in patch 02/18), shouldn't it have its own > compatible value "shimafuji,kingfisher" instead? Thank you for this suggestion. This looks very meaningful for boards differentiation. > Then this can be used in ulcb-kf.dtsi: > > compatible = "shimafuji,kingfisher"; > > and appended (overridden, as there's no /append-property/ directive in dtc > yet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts: > > compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796"; > > Does that make sense? Yes. I will rework this in V2 patchset according to your suggestion. > >> compatible = "renesas,m3ulcb", "renesas,r8a7796"; >> - Marzen (R0P7779A00010S) >> compatible = "renesas,marzen", "renesas,r8a7779" > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Vladimir
next prev parent reply other threads:[~2017-09-08 7:05 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-06 22:34 [PATCH 0/18] arm64: renesas: add ULCB Kingfisher board Vladimir Barinov 2017-09-06 22:34 ` Vladimir Barinov 2017-09-06 22:35 ` [PATCH 02/18] dt: arm: shmobile: add H3ULCB Kingfisher board DT bindings Vladimir Barinov 2017-09-06 22:35 ` [PATCH 03/18] arm64: dts: ulcb-kf: initial device tree Vladimir Barinov [not found] ` <1504737322-22954-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2017-09-20 12:20 ` Geert Uytterhoeven 2017-09-20 12:20 ` Geert Uytterhoeven 2017-09-20 14:43 ` Vladimir Barinov 2017-09-06 22:35 ` [PATCH 05/18] arm64: dts: h3ulcb-kf: ES1.x SoC " Vladimir Barinov 2017-09-06 22:35 ` [PATCH 06/18] arm64: dts: h3ulcb-kf: ES2.0+ " Vladimir Barinov 2017-09-06 22:36 ` [PATCH 08/18] arm64: dts: ulcb-kf: enable CAN0/1 Vladimir Barinov 2017-09-07 9:50 ` Sergei Shtylyov 2017-09-06 22:36 ` [PATCH 10/18] arm64: dts: ulcb-kf: enable HSUSB Vladimir Barinov 2017-09-20 12:51 ` Geert Uytterhoeven [not found] ` <CAMuHMdVVCBUgOrFrTQgVpwkShr8SgE9C7agEov5u5PE2F=h8ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-10-09 7:17 ` Simon Horman 2017-10-09 7:17 ` Simon Horman [not found] ` <1504737267-22829-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2017-09-06 22:35 ` [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Vladimir Barinov 2017-09-06 22:35 ` Vladimir Barinov 2017-09-07 10:58 ` Geert Uytterhoeven [not found] ` <CAMuHMdUi9THE7nTd54C22K6kOo_Ye5LkhTrRZPNfcHfWCiBsUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-09-08 7:05 ` Vladimir Barinov [this message] 2017-09-08 7:05 ` Vladimir Barinov 2017-09-06 22:35 ` [PATCH 04/18] arm64: dts: m3ulcb-kf: initial device tree Vladimir Barinov 2017-09-06 22:35 ` Vladimir Barinov 2017-09-06 22:35 ` [PATCH 07/18] arm64: dts: ulcb-kf: enable SCIF1 Vladimir Barinov 2017-09-06 22:35 ` Vladimir Barinov [not found] ` <1504737358-23113-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2017-09-20 12:40 ` Geert Uytterhoeven 2017-09-20 12:40 ` Geert Uytterhoeven 2017-09-06 22:36 ` [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0 Vladimir Barinov 2017-09-06 22:36 ` Vladimir Barinov [not found] ` <1504737377-23191-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2017-09-20 12:59 ` Geert Uytterhoeven 2017-09-20 12:59 ` Geert Uytterhoeven 2017-10-06 2:38 ` Vladimir Barinov 2017-10-06 7:15 ` Geert Uytterhoeven 2017-10-06 17:28 ` Vladimir Barinov [not found] ` <1c5fc090-af98-0041-be8b-b06dc81d4670-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2017-10-09 7:17 ` Simon Horman 2017-10-09 7:17 ` Simon Horman 2017-10-12 11:41 ` Yoshihiro Shimoda 2017-10-12 11:41 ` Yoshihiro Shimoda 2017-10-12 12:27 ` Geert Uytterhoeven 2017-09-06 22:36 ` [PATCH 11/18] arm64: dts: ulcb-kf: enable USB2.0 Host " Vladimir Barinov 2017-09-06 22:36 ` Vladimir Barinov 2017-09-20 12:52 ` Geert Uytterhoeven [not found] ` <CAMuHMdW9e-hSEHDbN9PNjLQHYdoXy6jFF=PgbCFb0neN_0Ho2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-10-09 7:17 ` Simon Horman 2017-10-09 7:17 ` Simon Horman 2017-09-06 22:36 ` [PATCH 12/18] arm64: dts: ulcb-kf: enable PCIE0/1 Vladimir Barinov 2017-09-06 22:36 ` Vladimir Barinov 2017-09-20 13:06 ` Geert Uytterhoeven 2017-09-06 22:36 ` [PATCH 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2 Vladimir Barinov 2017-09-06 22:36 ` Vladimir Barinov 2017-09-07 10:49 ` Geert Uytterhoeven 2017-09-06 22:37 ` [PATCH 16/18] arm64: dts: ulcb-kf: enable PCA9548 " Vladimir Barinov 2017-09-06 22:37 ` Vladimir Barinov 2017-09-07 10:37 ` Geert Uytterhoeven 2017-09-06 22:36 ` [PATCH 13/18] arm64: dts: ulcb-kf: enable USB3.0 Host Vladimir Barinov 2017-09-20 13:07 ` Geert Uytterhoeven 2017-10-09 7:16 ` Simon Horman 2017-09-06 22:37 ` [PATCH 15/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C4 Vladimir Barinov 2017-09-07 10:50 ` Geert Uytterhoeven 2017-09-06 22:37 ` [PATCH 17/18] arm64: dts: ulcb-kf: enable PCA9548 " Vladimir Barinov [not found] ` <1504737438-23504-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2017-09-07 10:51 ` Geert Uytterhoeven 2017-09-07 10:51 ` Geert Uytterhoeven 2017-09-06 22:37 ` [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios Vladimir Barinov [not found] ` <1504737444-23544-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2017-09-20 13:50 ` Geert Uytterhoeven 2017-09-20 13:50 ` Geert Uytterhoeven [not found] ` <CAMuHMdUqvdQZXrsf_p0rTUfKicvWBNPjk+Dt-ke_tSwmU1O=7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-10-09 7:15 ` Simon Horman 2017-10-09 7:15 ` Simon Horman 2017-09-06 22:45 ` [PATCH 0/18] arm64: renesas: add ULCB Kingfisher board Vladimir Barinov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a106fe34-d584-1560-797c-581ffc33a305@cogentembedded.com \ --to=vladimir.barinov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \ --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \ --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \ --cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.