All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mark Brown <broonie@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	quozl@laptop.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Eric Miao <eric.y.miao@gmail.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Daniel Mack <daniel@zonque.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	linux-spi <linux-spi@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 10/11] spi: pxa2xx: Add ready signal
Date: Thu, 11 Oct 2018 18:13:26 +0200	[thread overview]
Message-ID: <a13569d534e4393abff2ac704cee45df2bcd9656.camel@v3.sk> (raw)
In-Reply-To: <CAMuHMdXmsw3jjp8wFuuK_Vz8kwCP4=L59sc4kZafXzrb=hKv7g@mail.gmail.com>

On Thu, 2018-10-11 at 09:28 +0200, Geert Uytterhoeven wrote:
> Hi Lubomir,
> 
> On Wed, Oct 10, 2018 at 7:10 PM Lubomir Rintel <lkundrak@v3.sk>
> wrote:
> > Strobe a GPIO line when the slave TX FIFO is filled. This is how
> > the
> > Embedded Controller on an OLPC XO-1.75 machine, that happens to be
> > a SPI
> > master, learns that it can initiate a transaction.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> 
> Thanks for your patch!
> 
> I'm repeating my comments on the RFC below:

Ah, sorry for not addressing those; it somehow slipped through my
fingers. I'll wait a while to collect more feedback before sending v2
and then I'll include fixes for those.

Thanks for the review.

Lubo


WARNING: multiple messages have this Message-ID (diff)
From: lkundrak@v3.sk (Lubomir Rintel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] spi: pxa2xx: Add ready signal
Date: Thu, 11 Oct 2018 18:13:26 +0200	[thread overview]
Message-ID: <a13569d534e4393abff2ac704cee45df2bcd9656.camel@v3.sk> (raw)
In-Reply-To: <CAMuHMdXmsw3jjp8wFuuK_Vz8kwCP4=L59sc4kZafXzrb=hKv7g@mail.gmail.com>

On Thu, 2018-10-11 at 09:28 +0200, Geert Uytterhoeven wrote:
> Hi Lubomir,
> 
> On Wed, Oct 10, 2018 at 7:10 PM Lubomir Rintel <lkundrak@v3.sk>
> wrote:
> > Strobe a GPIO line when the slave TX FIFO is filled. This is how
> > the
> > Embedded Controller on an OLPC XO-1.75 machine, that happens to be
> > a SPI
> > master, learns that it can initiate a transaction.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> 
> Thanks for your patch!
> 
> I'm repeating my comments on the RFC below:

Ah, sorry for not addressing those; it somehow slipped through my
fingers. I'll wait a while to collect more feedback before sending v2
and then I'll include fixes for those.

Thanks for the review.

Lubo

  reply	other threads:[~2018-10-11 16:13 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 17:09 [PATCH 0/11] spi: pxa2xx: add DT and slave mode support Lubomir Rintel
2018-10-10 17:09 ` Lubomir Rintel
2018-10-10 17:09 ` [PATCH v2 01/11] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-10-11 14:27   ` Mark Brown
2018-10-11 14:27     ` Mark Brown
2018-10-11 17:59     ` Lubomir Rintel
2018-10-11 17:59       ` Lubomir Rintel
2018-10-12 17:00       ` Mark Brown
2018-10-12 17:00         ` Mark Brown
2018-10-17 19:32         ` Rob Herring
2018-10-17 19:32           ` Rob Herring
2018-11-04 12:00   ` Pavel Machek
2018-11-04 12:00     ` Pavel Machek
2018-10-10 17:09 ` [PATCH v2 02/11] PCI: Provide pci_match_id() with CONFIG_PCI=n Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-11-04 12:02   ` Pavel Machek
2018-11-04 12:02     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 03/11] spi: pxa2xx: Use an enum for type Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-11-04 12:03   ` Pavel Machek
2018-11-04 12:03     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 04/11] spi: pxa2xx: Add devicetree support Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-11-04 12:04   ` Pavel Machek
2018-11-04 12:04     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 05/11] DT: marvell,mmp2: Add SSP1 and SSP3 Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-10-29  5:35   ` James Cameron
2018-10-29  5:35     ` James Cameron
2018-11-04 12:06   ` Pavel Machek
2018-11-04 12:06     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 06/11] dt-bindings: spi/spi-pxa2xx: Add spi-slave property Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-10-17 19:33   ` Rob Herring
2018-10-17 19:33     ` Rob Herring
2018-11-04 12:07   ` Pavel Machek
2018-11-04 12:07     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 07/11] spi: Deal with slaves that return from transfer_one() unfinished Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-10-11  7:23   ` Geert Uytterhoeven
2018-10-11  7:23     ` Geert Uytterhoeven
2018-10-11  7:23     ` Geert Uytterhoeven
2018-11-04 12:09   ` Pavel Machek
2018-11-04 12:09     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 08/11] spi: pxa2xx: Add slave mode support Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-11-04 12:12   ` Pavel Machek
2018-11-04 12:12     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 09/11] dt-bindings: spi/spi-pxa2xx: Add ready GPIO signal Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-10-11  7:26   ` Geert Uytterhoeven
2018-10-11  7:26     ` Geert Uytterhoeven
2018-10-11  7:26     ` Geert Uytterhoeven
2018-11-04 12:13   ` Pavel Machek
2018-11-04 12:13     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 10/11] spi: pxa2xx: Add ready signal Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-10-11  7:28   ` Geert Uytterhoeven
2018-10-11  7:28     ` Geert Uytterhoeven
2018-10-11  7:28     ` Geert Uytterhoeven
2018-10-11 16:13     ` Lubomir Rintel [this message]
2018-10-11 16:13       ` Lubomir Rintel
2018-10-11 16:13       ` Lubomir Rintel
2018-11-04 12:16   ` Pavel Machek
2018-11-04 12:16     ` Pavel Machek
2018-10-10 17:09 ` [PATCH 11/11] spi: pxa2xx: Deal with the leftover garbage in TXFIFO Lubomir Rintel
2018-10-10 17:09   ` Lubomir Rintel
2018-11-04 12:19   ` Pavel Machek
2018-11-04 12:19     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a13569d534e4393abff2ac704cee45df2bcd9656.camel@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eric.y.miao@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=quozl@laptop.org \
    --cc=robert.jarzmik@free.fr \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.