[PATCH] usb: dwc3: Remove old comment

[PATCH] usb: dwc3: Remove old comment

[Thinh Nguyen]

With the new IP version checking scheme, we're not using the bit 31 of
dwc->revision as a flag anymore. Remove the stale comment.

Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---

Hi Felipe,

Not sure what happened to the DWC_usb32 patch* when it was merged to your
testing/next branch, but the old comment was removed in that patch. You can
apply this or squash it to the patch "usb: dwc3: Add support for DWC_usb32 IP"
on your testing/next branch.

*Original patch:
https://patchwork.kernel.org/patch/11484297/

Thanks,
Thinh


 drivers/usb/dwc3/core.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index d800f8119195..013f42a2b5dc 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1153,10 +1153,6 @@ struct dwc3 {
 #define DWC3_REVISION_310A	0x5533310a
 #define DWC3_REVISION_330A	0x5533330a
 
-/*
- * NOTICE: we're using bit 31 as a "is usb 3.1" flag. This is really
- * just so dwc31 revisions are always larger than dwc3.
- */
 #define DWC31_REVISION_ANY	0x0
 #define DWC31_REVISION_110A	0x3131302a
 #define DWC31_REVISION_120A	0x3132302a
-- 
2.11.0

Re: [PATCH] usb: dwc3: Remove old comment

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]


Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> With the new IP version checking scheme, we're not using the bit 31 of
> dwc->revision as a flag anymore. Remove the stale comment.
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
>
> Hi Felipe,
>
> Not sure what happened to the DWC_usb32 patch* when it was merged to your
> testing/next branch, but the old comment was removed in that patch. You can
> apply this or squash it to the patch "usb: dwc3: Add support for DWC_usb32 IP"
> on your testing/next branch.
>
> *Original patch:
> https://patchwork.kernel.org/patch/11484297/

Thanks for the fix up. I had to apply that patch manually and ended up
missing this hunk. I've corrected your original patch now.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]