All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH next] ARM: dts: BCM5301X: Fix Linksys EA9500 partitions
@ 2021-03-29  5:54 ` Rafał Miłecki
  0 siblings, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2021-03-29  5:54 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
	devicetree, Vivek Unune, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

Partitions are basically fixed indeed but firmware ones don't have
hardcoded function ("firmware" vs "failsafe"). Actual function depends
on bootloader configuration. Use a proper binding for that.

While at it fix numbers formatting to avoid:
arch/arm/boot/dts/bcm47094-linksys-panamera.dt.yaml: partitions: 'partition@1F00000' does not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
        From schema: Documentation/devicetree/bindings/mtd/partitions/linksys,ns-partitions.yaml

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm/boot/dts/bcm47094-linksys-panamera.dts | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/bcm47094-linksys-panamera.dts b/arch/arm/boot/dts/bcm47094-linksys-panamera.dts
index 1dc0cb0fae22..8b77efd2224e 100644
--- a/arch/arm/boot/dts/bcm47094-linksys-panamera.dts
+++ b/arch/arm/boot/dts/bcm47094-linksys-panamera.dts
@@ -279,7 +279,7 @@ &usb3_phy {
 
 &nandcs {
 	partitions {
-		compatible = "fixed-partitions";
+		compatible = "linksys,ns-partitions";
 		#address-cells = <1>;
 		#size-cells = <1>;
 
@@ -300,20 +300,18 @@ partition@180000{
 		};
 
 		partition@200000 {
-			label = "firmware";
-			reg = <0x0200000 0x01D00000>;
-			compatible = "brcm,trx";
+			reg = <0x0200000 0x01d00000>;
+			compatible = "linksys,ns-firmware", "brcm,trx";
 		};
 
-		partition@1F00000 {
-			label = "failsafe";
-			reg = <0x01F00000 0x01D00000>;
-			read-only;
+		partition@1f00000 {
+			reg = <0x01f00000 0x01d00000>;
+			compatible = "linksys,ns-firmware", "brcm,trx";
 		};
 
 		partition@5200000 {
 			label = "system";
-			reg = <0x05200000 0x02E00000>;
+			reg = <0x05200000 0x02e00000>;
 		};
 	};
 };
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH next] ARM: dts: BCM5301X: Fix Linksys EA9500 partitions
@ 2021-03-29  5:54 ` Rafał Miłecki
  0 siblings, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2021-03-29  5:54 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
	devicetree, Vivek Unune, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

Partitions are basically fixed indeed but firmware ones don't have
hardcoded function ("firmware" vs "failsafe"). Actual function depends
on bootloader configuration. Use a proper binding for that.

While at it fix numbers formatting to avoid:
arch/arm/boot/dts/bcm47094-linksys-panamera.dt.yaml: partitions: 'partition@1F00000' does not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
        From schema: Documentation/devicetree/bindings/mtd/partitions/linksys,ns-partitions.yaml

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm/boot/dts/bcm47094-linksys-panamera.dts | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/bcm47094-linksys-panamera.dts b/arch/arm/boot/dts/bcm47094-linksys-panamera.dts
index 1dc0cb0fae22..8b77efd2224e 100644
--- a/arch/arm/boot/dts/bcm47094-linksys-panamera.dts
+++ b/arch/arm/boot/dts/bcm47094-linksys-panamera.dts
@@ -279,7 +279,7 @@ &usb3_phy {
 
 &nandcs {
 	partitions {
-		compatible = "fixed-partitions";
+		compatible = "linksys,ns-partitions";
 		#address-cells = <1>;
 		#size-cells = <1>;
 
@@ -300,20 +300,18 @@ partition@180000{
 		};
 
 		partition@200000 {
-			label = "firmware";
-			reg = <0x0200000 0x01D00000>;
-			compatible = "brcm,trx";
+			reg = <0x0200000 0x01d00000>;
+			compatible = "linksys,ns-firmware", "brcm,trx";
 		};
 
-		partition@1F00000 {
-			label = "failsafe";
-			reg = <0x01F00000 0x01D00000>;
-			read-only;
+		partition@1f00000 {
+			reg = <0x01f00000 0x01d00000>;
+			compatible = "linksys,ns-firmware", "brcm,trx";
 		};
 
 		partition@5200000 {
 			label = "system";
-			reg = <0x05200000 0x02E00000>;
+			reg = <0x05200000 0x02e00000>;
 		};
 	};
 };
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH next] ARM: dts: BCM5301X: Fix Linksys EA9500 partitions
  2021-03-29  5:54 ` Rafał Miłecki
@ 2021-03-29 18:43   ` Florian Fainelli
  -1 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-03-29 18:43 UTC (permalink / raw)
  To: Rafał Miłecki, Florian Fainelli
  Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
	devicetree, Vivek Unune, Rafał Miłecki

On 3/28/21 10:54 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Partitions are basically fixed indeed but firmware ones don't have
> hardcoded function ("firmware" vs "failsafe"). Actual function depends
> on bootloader configuration. Use a proper binding for that.
> 
> While at it fix numbers formatting to avoid:
> arch/arm/boot/dts/bcm47094-linksys-panamera.dt.yaml: partitions: 'partition@1F00000' does not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         From schema: Documentation/devicetree/bindings/mtd/partitions/linksys,ns-partitions.yaml
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied to devicetree/next, thanks!
-- 
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH next] ARM: dts: BCM5301X: Fix Linksys EA9500 partitions
@ 2021-03-29 18:43   ` Florian Fainelli
  0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-03-29 18:43 UTC (permalink / raw)
  To: Rafał Miłecki, Florian Fainelli
  Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
	devicetree, Vivek Unune, Rafał Miłecki

On 3/28/21 10:54 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Partitions are basically fixed indeed but firmware ones don't have
> hardcoded function ("firmware" vs "failsafe"). Actual function depends
> on bootloader configuration. Use a proper binding for that.
> 
> While at it fix numbers formatting to avoid:
> arch/arm/boot/dts/bcm47094-linksys-panamera.dt.yaml: partitions: 'partition@1F00000' does not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         From schema: Documentation/devicetree/bindings/mtd/partitions/linksys,ns-partitions.yaml
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied to devicetree/next, thanks!
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-30  0:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29  5:54 [PATCH next] ARM: dts: BCM5301X: Fix Linksys EA9500 partitions Rafał Miłecki
2021-03-29  5:54 ` Rafał Miłecki
2021-03-29 18:43 ` Florian Fainelli
2021-03-29 18:43   ` Florian Fainelli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.