From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org> To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, David Daney <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> Subject: Re: [PATCH v2 1/3] dt-bindings: gpio: Add binding documentation for gpio-thunderx Date: Mon, 9 Jan 2017 11:44:22 -0800 [thread overview] Message-ID: <a1b6c9da-5b19-c9a7-3774-0bc0e9dcdeb6@caviumnetworks.com> (raw) In-Reply-To: <CACRpkdZ0xkhUC7_0A4uHxpGaU7BHgNp8TNuDPuPN9h6dDsQx4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On 01/09/2017 11:36 AM, Linus Walleij wrote: > On Sat, Jan 7, 2017 at 12:22 AM, David Daney <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > >> From: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> >> >> Signed-off-by: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > (...) > >> +Optional Properties: >> +- compatible: "cavium,thunder-8890-gpio", unused as PCI driver binding is used. >> +- interrupt-controller: Marks the device node as an interrupt controller. >> +- #interrupt-cells: Must be present and have value of 2 if >> + "interrupt-controller" is present. >> + - First cell is the GPIO pin number relative to the controller. >> + - Second cell is triggering flags as defined in interrupts.txt. > > AFAICT this device has an optional list of interrupts as well? > One per pin even? I'm not sure I understand your question. The GPIO hardware supports an interrupt on each pin. The underlying interrupt mechanism is via PCI MSI-X, which are fully discoverable by the driver, so lack of device tree binding for the these underlying MSI-X is fully appropriate. On the other hand, users of the GPIO interrupt pins need this "interrupt-controller" and "#interrupt-cells" to be able to properly find and configure the proper interrupts. I said the "interrupt-controller" property was optional, because some systems don't use GPIO interrupts and can function without specifying that it is also an interrupt controller. > > Yours, > Linus Walleij > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com> To: Linus Walleij <linus.walleij@linaro.org>, David Daney <ddaney.cavm@gmail.com> Cc: Alexandre Courbot <gnurou@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, David Daney <david.daney@cavium.com> Subject: Re: [PATCH v2 1/3] dt-bindings: gpio: Add binding documentation for gpio-thunderx Date: Mon, 9 Jan 2017 11:44:22 -0800 [thread overview] Message-ID: <a1b6c9da-5b19-c9a7-3774-0bc0e9dcdeb6@caviumnetworks.com> (raw) In-Reply-To: <CACRpkdZ0xkhUC7_0A4uHxpGaU7BHgNp8TNuDPuPN9h6dDsQx4g@mail.gmail.com> On 01/09/2017 11:36 AM, Linus Walleij wrote: > On Sat, Jan 7, 2017 at 12:22 AM, David Daney <ddaney.cavm@gmail.com> wrote: > >> From: David Daney <david.daney@cavium.com> >> >> Signed-off-by: David Daney <david.daney@cavium.com> > (...) > >> +Optional Properties: >> +- compatible: "cavium,thunder-8890-gpio", unused as PCI driver binding is used. >> +- interrupt-controller: Marks the device node as an interrupt controller. >> +- #interrupt-cells: Must be present and have value of 2 if >> + "interrupt-controller" is present. >> + - First cell is the GPIO pin number relative to the controller. >> + - Second cell is triggering flags as defined in interrupts.txt. > > AFAICT this device has an optional list of interrupts as well? > One per pin even? I'm not sure I understand your question. The GPIO hardware supports an interrupt on each pin. The underlying interrupt mechanism is via PCI MSI-X, which are fully discoverable by the driver, so lack of device tree binding for the these underlying MSI-X is fully appropriate. On the other hand, users of the GPIO interrupt pins need this "interrupt-controller" and "#interrupt-cells" to be able to properly find and configure the proper interrupts. I said the "interrupt-controller" property was optional, because some systems don't use GPIO interrupts and can function without specifying that it is also an interrupt controller. > > Yours, > Linus Walleij >
next prev parent reply other threads:[~2017-01-09 19:44 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-06 23:22 [PATCH v2 0/3] GPIO: Add driver for ThunderX and OCTEON-TX SoCs David Daney 2017-01-06 23:22 ` David Daney [not found] ` <1483744980-25898-1-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-01-06 23:22 ` [PATCH v2 1/3] dt-bindings: gpio: Add binding documentation for gpio-thunderx David Daney 2017-01-06 23:22 ` David Daney 2017-01-09 19:36 ` Linus Walleij [not found] ` <CACRpkdZ0xkhUC7_0A4uHxpGaU7BHgNp8TNuDPuPN9h6dDsQx4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-01-09 19:44 ` David Daney [this message] 2017-01-09 19:44 ` David Daney [not found] ` <a1b6c9da-5b19-c9a7-3774-0bc0e9dcdeb6-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org> 2017-01-10 8:42 ` Linus Walleij 2017-01-10 8:42 ` Linus Walleij 2017-01-10 5:35 ` Rob Herring 2017-01-06 23:22 ` [PATCH v2 2/3] gpio: Add gpio driver support for ThunderX and OCTEON-TX David Daney 2017-01-06 23:22 ` David Daney [not found] ` <1483744980-25898-3-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-01-09 19:35 ` Linus Walleij 2017-01-09 19:35 ` Linus Walleij 2017-01-09 20:02 ` David Daney 2017-01-11 15:07 ` Linus Walleij 2017-01-06 23:23 ` [PATCH v2 3/3] MAINTAINERS: Add entry for THUNDERX GPIO Driver David Daney
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a1b6c9da-5b19-c9a7-3774-0bc0e9dcdeb6@caviumnetworks.com \ --to=ddaney-m3mlkvoiwjvv6pq1l3v1odbpr1lh4cv8@public.gmane.org \ --cc=david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \ --cc=ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.