From: Hou Tao <houtao1@huawei.com>
To: Richard Weinberger <richard.weinberger@gmail.com>,
Quanyang Wang <quanyang.wang@windriver.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
Sascha Hauer <s.hauer@pengutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] ubi: fix memory leak from ubi->fm_anchor
Date: Sat, 8 Feb 2020 11:00:15 +0800 [thread overview]
Message-ID: <a1b8f42b-9076-cc73-a298-4ddba7cfbc32@huawei.com> (raw)
In-Reply-To: <CAFLxGvw-q3N98RhbtWCE5mGGv6qwrJBDTMTs_yMe9QDY6U4TAQ@mail.gmail.com>
Hi,
The same problem has already been fixed by the patch in the following link early:
https://lore.kernel.org/linux-mtd/0000000000006d0a820599366088@google.com/T/#medffabe29b65eb5feb387bff84c6ec7ad235c310
I will send a v2 next week.
Regards,
Tao
On 2020/2/7 23:54, Richard Weinberger wrote:
> On Mon, Feb 3, 2020 at 10:14 AM Quanyang Wang
> <quanyang.wang@windriver.com> wrote:
>>
>> Ping?
>>
>> On 1/14/20 5:33 PM, quanyang.wang@windriver.com wrote:
>>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>>
>>> Some ubi_wl_entry are allocated in erase_aeb() and one of them is
>>> assigned to ubi->fm_anchor in __erase_worker(). And it should be freed
>>> like others which are freed in tree_destroy(). Otherwise, it will
>>> cause a memory leak:
>>>
>>> unreferenced object 0xbc094318 (size 24):
>>> comm "ubiattach", pid 491, jiffies 4294954015 (age 420.110s)
>>> hex dump (first 24 bytes):
>>> 30 43 09 bc 00 00 00 00 00 00 00 00 01 00 00 00 0C..............
>>> 02 00 00 00 04 00 00 00 ........
>>> backtrace:
>>> [<6c2d5089>] erase_aeb+0x28/0xc8
>>> [<a1c68fb1>] ubi_wl_init+0x1d8/0x4a8
>>> [<d4f408f8>] ubi_attach+0xffc/0x10d0
>>> [<add3b5d8>] ubi_attach_mtd_dev+0x5b4/0x9fc
>>> [<d375a11c>] ctrl_cdev_ioctl+0xb8/0x1d8
>>> [<72b250f2>] vfs_ioctl+0x28/0x3c
>>> [<b80095d7>] do_vfs_ioctl+0xb0/0x798
>>> [<bf9ef69e>] ksys_ioctl+0x58/0x74
>>> [<5355bdbe>] ret_fast_syscall+0x0/0x54
>>> [<90c6c3ca>] 0x7eadf854
>>>
>>> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
>>> ---
>>> drivers/mtd/ubi/wl.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>
> Good catch!
> Fixes: f9c34bb52997 ("ubi: Fix producing anchor PEBs")
>
> ---
> Thanks,
> //richard
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Hou Tao <houtao1@huawei.com>
To: Richard Weinberger <richard.weinberger@gmail.com>,
Quanyang Wang <quanyang.wang@windriver.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
Sascha Hauer <s.hauer@pengutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] ubi: fix memory leak from ubi->fm_anchor
Date: Sat, 8 Feb 2020 11:00:15 +0800 [thread overview]
Message-ID: <a1b8f42b-9076-cc73-a298-4ddba7cfbc32@huawei.com> (raw)
In-Reply-To: <CAFLxGvw-q3N98RhbtWCE5mGGv6qwrJBDTMTs_yMe9QDY6U4TAQ@mail.gmail.com>
Hi,
The same problem has already been fixed by the patch in the following link early:
https://lore.kernel.org/linux-mtd/0000000000006d0a820599366088@google.com/T/#medffabe29b65eb5feb387bff84c6ec7ad235c310
I will send a v2 next week.
Regards,
Tao
On 2020/2/7 23:54, Richard Weinberger wrote:
> On Mon, Feb 3, 2020 at 10:14 AM Quanyang Wang
> <quanyang.wang@windriver.com> wrote:
>>
>> Ping?
>>
>> On 1/14/20 5:33 PM, quanyang.wang@windriver.com wrote:
>>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>>
>>> Some ubi_wl_entry are allocated in erase_aeb() and one of them is
>>> assigned to ubi->fm_anchor in __erase_worker(). And it should be freed
>>> like others which are freed in tree_destroy(). Otherwise, it will
>>> cause a memory leak:
>>>
>>> unreferenced object 0xbc094318 (size 24):
>>> comm "ubiattach", pid 491, jiffies 4294954015 (age 420.110s)
>>> hex dump (first 24 bytes):
>>> 30 43 09 bc 00 00 00 00 00 00 00 00 01 00 00 00 0C..............
>>> 02 00 00 00 04 00 00 00 ........
>>> backtrace:
>>> [<6c2d5089>] erase_aeb+0x28/0xc8
>>> [<a1c68fb1>] ubi_wl_init+0x1d8/0x4a8
>>> [<d4f408f8>] ubi_attach+0xffc/0x10d0
>>> [<add3b5d8>] ubi_attach_mtd_dev+0x5b4/0x9fc
>>> [<d375a11c>] ctrl_cdev_ioctl+0xb8/0x1d8
>>> [<72b250f2>] vfs_ioctl+0x28/0x3c
>>> [<b80095d7>] do_vfs_ioctl+0xb0/0x798
>>> [<bf9ef69e>] ksys_ioctl+0x58/0x74
>>> [<5355bdbe>] ret_fast_syscall+0x0/0x54
>>> [<90c6c3ca>] 0x7eadf854
>>>
>>> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
>>> ---
>>> drivers/mtd/ubi/wl.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>
> Good catch!
> Fixes: f9c34bb52997 ("ubi: Fix producing anchor PEBs")
>
> ---
> Thanks,
> //richard
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-08 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 9:33 [PATCH] ubi: fix memory leak from ubi->fm_anchor quanyang.wang
2020-02-03 8:37 ` Quanyang Wang
2020-02-07 15:54 ` Richard Weinberger
2020-02-07 15:54 ` Richard Weinberger
2020-02-08 3:00 ` Hou Tao [this message]
2020-02-08 3:00 ` Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1b8f42b-9076-cc73-a298-4ddba7cfbc32@huawei.com \
--to=houtao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=quanyang.wang@windriver.com \
--cc=richard.weinberger@gmail.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.