All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1 ] fs: Warming in __brelse
@ 2023-08-16 16:40 ` Manas Ghandat
  0 siblings, 0 replies; 2+ messages in thread
From: Manas Ghandat @ 2023-08-16 16:40 UTC (permalink / raw)
  To: viro, brauner; +Cc: linux-fsdevel, linux-kernel, Linux-kernel-mentees

Hi,

I was working on the following syzbot bug:

https://syzkaller.appspot.com/bug?extid=ce3af36144a13b018cc7

Upon debugging I found that in this case the buffer_head is having count 
0 and then when __brelse is called it tries to free it. A simple 
solution to this problem would be to remove the warn call. SInce in any 
case the buffers only get freed if the count is present and consequently 
the pointers are also set to null. Additionally we could add a check in 
the has_bh_in_lru to also consider the counter.

Link : 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/buffer.c?id=d192f5382581d972c4ae1b4d72e0b59b34cadeb9#n1509


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 0/1 ] fs: Warming in __brelse
@ 2023-08-16 16:40 ` Manas Ghandat
  0 siblings, 0 replies; 2+ messages in thread
From: Manas Ghandat @ 2023-08-16 16:40 UTC (permalink / raw)
  To: viro, brauner; +Cc: linux-fsdevel, Linux-kernel-mentees, linux-kernel

Hi,

I was working on the following syzbot bug:

https://syzkaller.appspot.com/bug?extid=ce3af36144a13b018cc7

Upon debugging I found that in this case the buffer_head is having count 
0 and then when __brelse is called it tries to free it. A simple 
solution to this problem would be to remove the warn call. SInce in any 
case the buffers only get freed if the count is present and consequently 
the pointers are also set to null. Additionally we could add a check in 
the has_bh_in_lru to also consider the counter.

Link : 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/buffer.c?id=d192f5382581d972c4ae1b4d72e0b59b34cadeb9#n1509

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-16 16:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-16 16:40 [PATCH 0/1 ] fs: Warming in __brelse Manas Ghandat
2023-08-16 16:40 ` Manas Ghandat

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.