* [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
@ 2016-09-12 17:04 Namrata A Shettar
2016-09-12 17:06 ` [Outreachy kernel] " Julia Lawall
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Namrata A Shettar @ 2016-09-12 17:04 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
This patch fixes the checkpatch.pl issue:
-Please don't use multiple blank lines
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
---
drivers/staging/comedi/comedi_pcmcia.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_pcmcia.c
b/drivers/staging/comedi/comedi_pcmcia.c
index d7072a5..ec8a0ad 100644
--- a/drivers/staging/comedi/comedi_pcmcia.c
+++ b/drivers/staging/comedi/comedi_pcmcia.c
@@ -18,7 +18,6 @@
#include <linux/module.h>
#include <linux/kernel.h>
-
#include "comedi_pcmcia.h"
/**
[-- Attachment #2: Type: text/html, Size: 858 bytes --]
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
2016-09-12 17:04 [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue Namrata A Shettar
@ 2016-09-12 17:06 ` Julia Lawall
2016-09-12 17:25 ` Greg KH
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2016-09-12 17:06 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1260 bytes --]
On Mon, 12 Sep 2016, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl issue:
> -Please don't use multiple blank lines
This is fine, but I guess there is a maintainer for this file?
julia
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDEjFOCD2WZmVWedeRc
> asU_48CmaTpOCKT3QJWbRB5zFgQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
2016-09-12 17:04 [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue Namrata A Shettar
2016-09-12 17:06 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-12 17:25 ` Greg KH
2016-09-12 17:31 ` Namrata A Shettar
2016-09-12 19:08 ` Namrata A Shettar
3 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2016-09-12 17:25 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel
On Mon, Sep 12, 2016 at 10:34:21PM +0530, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> �drivers/staging/comedi/comedi_pcmcia.c | 1 -
> �1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c b/drivers/staging/comedi/
> comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> �#include <linux/module.h>
> �#include <linux/kernel.h>
> -
> �#include "comedi_pcmcia.h"
That's not a multiple blank line :(
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
2016-09-12 17:04 [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue Namrata A Shettar
2016-09-12 17:06 ` [Outreachy kernel] " Julia Lawall
2016-09-12 17:25 ` Greg KH
@ 2016-09-12 17:31 ` Namrata A Shettar
2016-09-12 17:37 ` [Outreachy kernel] " Julia Lawall
2016-09-12 19:08 ` Namrata A Shettar
3 siblings, 1 reply; 9+ messages in thread
From: Namrata A Shettar @ 2016-09-12 17:31 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 785 bytes --]
There was an issue in getting the maintainer's list.Sorted now and sent it
to the maintainers.
Thanks,
Namrata
On Monday, September 12, 2016 at 10:34:43 PM UTC+5:30, Namrata A Shettar
wrote:
>
> This patch fixes the checkpatch.pl issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
[-- Attachment #1.2: Type: text/html, Size: 1732 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
2016-09-12 17:31 ` Namrata A Shettar
@ 2016-09-12 17:37 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2016-09-12 17:37 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1759 bytes --]
On Mon, 12 Sep 2016, Namrata A Shettar wrote:
> There was an issue in getting the maintainer's list.Sorted now and sent it
> to the maintainers.
Actually, when you adjust a patch in any way, you should send the patch to
all of the original recipients. Put [PATCH v2] in the subject line and an
explanation under the ---, eg
---
v2: added maintainers
See the Revising your patches section of the tutorial.
julia
>
> Thanks,
> Namrata
>
> On Monday, September 12, 2016 at 10:34:43 PM UTC+5:30, Namrata A Shettar
> wrote:
> This patch fixes the checkpatch.pl issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/a1d35405-1ff2-4642-a8da-
> 533adbc6da70%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
2016-09-12 17:04 [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue Namrata A Shettar
` (2 preceding siblings ...)
2016-09-12 17:31 ` Namrata A Shettar
@ 2016-09-12 19:08 ` Namrata A Shettar
2016-09-13 5:18 ` [Outreachy kernel] " Julia Lawall
3 siblings, 1 reply; 9+ messages in thread
From: Namrata A Shettar @ 2016-09-12 19:08 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 792 bytes --]
Yes,a mistake in naming the issue, an uneccessary blank line would have
been apt.
Sorry,for the inconvenience,
Namrata
On Monday, September 12, 2016 at 10:34:43 PM UTC+5:30, Namrata A Shettar
wrote:
>
> This patch fixes the checkpatch.pl issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
[-- Attachment #1.2: Type: text/html, Size: 1732 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
2016-09-12 19:08 ` Namrata A Shettar
@ 2016-09-13 5:18 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2016-09-13 5:18 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1541 bytes --]
On Mon, 12 Sep 2016, Namrata A Shettar wrote:
> Yes,a mistake in naming the issue, an uneccessary blank line would have been
> apt.
> Sorry,for the inconvenience,
You should send a v2 with the correction.
julia
> Namrata
>
> On Monday, September 12, 2016 at 10:34:43 PM UTC+5:30, Namrata A Shettar
> wrote:
> This patch fixes the checkpatch.pl issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/617c0bbf-3f68-4fd4-b435-
> b73e7665b5bb%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
2016-09-12 18:07 ` Ian Abbott
@ 2016-09-12 18:17 ` Joe Perches
0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2016-09-12 18:17 UTC (permalink / raw)
To: Ian Abbott, Namrata A Shettar, hsweeten, gregkh, badbuddha91,
devel, linux-kernel
On Mon, 2016-09-12 at 19:07 +0100, Ian Abbott wrote:
> On 12/09/16 18:29, Namrata A Shettar wrote:
> > This patch fixes the checkpatch.pl <http://checkpatch.pl> issue:
> -Please don't use multiple blank lines
[]
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
[]
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
>
> But there is only one blank line, so why the warning about multiple
> blank lines?
checkpatch doesn't emit a warning here.
Also the http://checkpatch.pl link is incorrect
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
[not found] <CAFrQyDGBgef3Nko84BcC9awPCP8+-wrpH2wGZmcfGEctuC31nA@mail.gmail.com>
@ 2016-09-12 18:07 ` Ian Abbott
2016-09-12 18:17 ` Joe Perches
0 siblings, 1 reply; 9+ messages in thread
From: Ian Abbott @ 2016-09-12 18:07 UTC (permalink / raw)
To: Namrata A Shettar, hsweeten, gregkh, badbuddha91, devel, linux-kernel
On 12/09/16 18:29, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl <http://checkpatch.pl> issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com
> <mailto:namrataashettar@gmail.com>>
> ---
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
But there is only one blank line, so why the warning about multiple
blank lines?
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-09-13 14:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 17:04 [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue Namrata A Shettar
2016-09-12 17:06 ` [Outreachy kernel] " Julia Lawall
2016-09-12 17:25 ` Greg KH
2016-09-12 17:31 ` Namrata A Shettar
2016-09-12 17:37 ` [Outreachy kernel] " Julia Lawall
2016-09-12 19:08 ` Namrata A Shettar
2016-09-13 5:18 ` [Outreachy kernel] " Julia Lawall
[not found] <CAFrQyDGBgef3Nko84BcC9awPCP8+-wrpH2wGZmcfGEctuC31nA@mail.gmail.com>
2016-09-12 18:07 ` Ian Abbott
2016-09-12 18:17 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.