All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
	Tom Zanussi <zanussi@kernel.org>
Subject: [PATCH 2/7] tracing: Fix smatch warning for do while check in event_hist_trigger_parse()
Date: Thu, 27 Jan 2022 15:44:16 -0600	[thread overview]
Message-ID: <a1d4c79766c0cf61e20438dc35244d216633fef6.1643319703.git.zanussi@kernel.org> (raw)
In-Reply-To: <cover.1643319703.git.zanussi@kernel.org>
In-Reply-To: <cover.1643319703.git.zanussi@kernel.org>

The patch ec5ce0987541: "tracing: Allow whitespace to surround hist
trigger filter" from Jan 15, 2018, leads to the following Smatch
static checker warning:

    kernel/trace/trace_events_hist.c:6199 event_hist_trigger_parse()
    warn: 'p' can't be NULL.

Since p is always checked for a NULL value at the top of loop and
nothing in the rest of the loop will set it to NULL, the warning
is correct and might as well be 1 to silence the warning.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
---
 kernel/trace/trace_events_hist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index e0860146dd39..b894d68082ea 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -6199,7 +6199,7 @@ static int event_hist_trigger_parse(struct event_command *cmd_ops,
 			continue;
 		}
 		break;
-	} while (p);
+	} while (1);
 
 	if (!p)
 		param = NULL;
-- 
2.17.1


  parent reply	other threads:[~2022-01-27 21:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 21:44 [PATCH 0/7] tracing: Misc bugfixes Tom Zanussi
2022-01-27 21:44 ` [PATCH 1/7] tracing: Fix smatch warning for null glob in event_hist_trigger_parse() Tom Zanussi
2022-01-27 21:44 ` Tom Zanussi [this message]
2022-01-27 21:44 ` [PATCH 3/7] tracing: Propagate is_signed to expression Tom Zanussi
2022-01-27 21:44 ` [PATCH 4/7] tracing: Don't inc err_log entry count if entry allocation fails Tom Zanussi
2022-01-27 21:44 ` [PATCH 5/7] tracing: Remove size restriction on tracing_log_err cmd strings Tom Zanussi
2022-01-27 21:44 ` [PATCH 6/7] tracing: Remove size restriction on hist trigger cmd error logging Tom Zanussi
2022-01-27 21:44 ` [PATCH 7/7] tracing: Remove size restriction on synthetic event " Tom Zanussi
2022-01-27 23:26 ` [PATCH 0/7] tracing: Misc bugfixes Steven Rostedt
2022-01-27 23:50   ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1d4c79766c0cf61e20438dc35244d216633fef6.1643319703.git.zanussi@kernel.org \
    --to=zanussi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.