All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
	Tom Zanussi <zanussi@kernel.org>
Subject: [PATCH 4/7] tracing: Don't inc err_log entry count if entry allocation fails
Date: Thu, 27 Jan 2022 15:44:18 -0600	[thread overview]
Message-ID: <cad1ab28f75968db0f466925e7cba5970cec6c29.1643319703.git.zanussi@kernel.org> (raw)
In-Reply-To: <cover.1643319703.git.zanussi@kernel.org>
In-Reply-To: <cover.1643319703.git.zanussi@kernel.org>

tr->n_err_log_entries should only be increased if entry allocation
succeeds.

Doing it when it fails won't cause any problems other than wasting an
entry, but should be fixed anyway.

Signed-off-by: Tom Zanussi <zanussi@kernel.org>
---
 kernel/trace/trace.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a73d78dcda2c..addd8297874e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -7740,7 +7740,8 @@ static struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
 		err = kzalloc(sizeof(*err), GFP_KERNEL);
 		if (!err)
 			err = ERR_PTR(-ENOMEM);
-		tr->n_err_log_entries++;
+		else
+			tr->n_err_log_entries++;
 
 		return err;
 	}
-- 
2.17.1


  parent reply	other threads:[~2022-01-27 21:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 21:44 [PATCH 0/7] tracing: Misc bugfixes Tom Zanussi
2022-01-27 21:44 ` [PATCH 1/7] tracing: Fix smatch warning for null glob in event_hist_trigger_parse() Tom Zanussi
2022-01-27 21:44 ` [PATCH 2/7] tracing: Fix smatch warning for do while check " Tom Zanussi
2022-01-27 21:44 ` [PATCH 3/7] tracing: Propagate is_signed to expression Tom Zanussi
2022-01-27 21:44 ` Tom Zanussi [this message]
2022-01-27 21:44 ` [PATCH 5/7] tracing: Remove size restriction on tracing_log_err cmd strings Tom Zanussi
2022-01-27 21:44 ` [PATCH 6/7] tracing: Remove size restriction on hist trigger cmd error logging Tom Zanussi
2022-01-27 21:44 ` [PATCH 7/7] tracing: Remove size restriction on synthetic event " Tom Zanussi
2022-01-27 23:26 ` [PATCH 0/7] tracing: Misc bugfixes Steven Rostedt
2022-01-27 23:50   ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cad1ab28f75968db0f466925e7cba5970cec6c29.1643319703.git.zanussi@kernel.org \
    --to=zanussi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.