All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: rename header test build commands to avoid conflicts
@ 2019-06-05 13:21 Jani Nikula
  2019-06-05 13:35 ` Sam Ravnborg
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Jani Nikula @ 2019-06-05 13:21 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula, Masahiro Yamada, Sam Ravnborg

We have a local hack to test if headers are self-contained, while
upstreaming a proper generic solution in kbuild [1]. Now that both have
found themselves in linux-next, the identical cmd_header_test build
commands conflict, leading to errors such as:

>> drivers/gpu/drm/i915/header_test_intel_audio.c:1:10: fatal error:
>> drivers/gpu/drm/i915/intel_audio.h: No such file or directory
    #include "drivers/gpu/drm/i915/intel_audio.h"
	     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rename the i915 local build command until the proper kbuild solution
finds its way to Linus' master and gets backported to our tree, and we
can finally switch over.

Note that since the kbuild header test requires CONFIG_HEADER_TEST=y,
and our hack requires our debug option CONFIG_DRM_I915_WERROR=y, this is
likely hit only by build test bots.

[1] http://marc.info/?i=20190604124248.5564-1-jani.nikula@intel.com

Reported-by: kbuild test robot <lkp@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/Makefile.header-test     | 6 +++---
 drivers/gpu/drm/i915/gem/Makefile.header-test | 6 +++---
 drivers/gpu/drm/i915/gt/Makefile.header-test  | 6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 6ef3b647ac65..1b4537405b4b 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -63,11 +63,11 @@ header_test := \
 	intel_vdsc.h \
 	intel_wakeref.h
 
-quiet_cmd_header_test = HDRTEST $@
-      cmd_header_test = echo "\#include \"$(<F)\"" > $@
+quiet_cmd_i915_header_test = HDRTEST $@
+      cmd_i915_header_test = echo "\#include \"$(<F)\"" > $@
 
 header_test_%.c: %.h
-	$(call cmd,header_test)
+	$(call cmd,i915_header_test)
 
 i915-$(CONFIG_DRM_I915_WERROR) += $(foreach h,$(header_test),$(patsubst %.h,header_test_%.o,$(h)))
 
diff --git a/drivers/gpu/drm/i915/gem/Makefile.header-test b/drivers/gpu/drm/i915/gem/Makefile.header-test
index 61e06cbb4b32..50a3aa983659 100644
--- a/drivers/gpu/drm/i915/gem/Makefile.header-test
+++ b/drivers/gpu/drm/i915/gem/Makefile.header-test
@@ -4,11 +4,11 @@
 # Test the headers are compilable as standalone units
 header_test := $(notdir $(wildcard $(src)/*.h))
 
-quiet_cmd_header_test = HDRTEST $@
-      cmd_header_test = echo "\#include \"$(<F)\"" > $@
+quiet_cmd_i915_header_test = HDRTEST $@
+      cmd_i915_header_test = echo "\#include \"$(<F)\"" > $@
 
 header_test_%.c: %.h
-	$(call cmd,header_test)
+	$(call cmd,i915_header_test)
 
 extra-$(CONFIG_DRM_I915_WERROR) += \
 	$(foreach h,$(header_test),$(patsubst %.h,header_test_%.o,$(h)))
diff --git a/drivers/gpu/drm/i915/gt/Makefile.header-test b/drivers/gpu/drm/i915/gt/Makefile.header-test
index 61e06cbb4b32..50a3aa983659 100644
--- a/drivers/gpu/drm/i915/gt/Makefile.header-test
+++ b/drivers/gpu/drm/i915/gt/Makefile.header-test
@@ -4,11 +4,11 @@
 # Test the headers are compilable as standalone units
 header_test := $(notdir $(wildcard $(src)/*.h))
 
-quiet_cmd_header_test = HDRTEST $@
-      cmd_header_test = echo "\#include \"$(<F)\"" > $@
+quiet_cmd_i915_header_test = HDRTEST $@
+      cmd_i915_header_test = echo "\#include \"$(<F)\"" > $@
 
 header_test_%.c: %.h
-	$(call cmd,header_test)
+	$(call cmd,i915_header_test)
 
 extra-$(CONFIG_DRM_I915_WERROR) += \
 	$(foreach h,$(header_test),$(patsubst %.h,header_test_%.o,$(h)))
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
  2019-06-05 13:21 [PATCH] drm/i915: rename header test build commands to avoid conflicts Jani Nikula
@ 2019-06-05 13:35 ` Sam Ravnborg
  2019-06-05 14:53 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 10+ messages in thread
From: Sam Ravnborg @ 2019-06-05 13:35 UTC (permalink / raw)
  To: Jani Nikula; +Cc: Masahiro Yamada, intel-gfx

Hi Jani.

On Wed, Jun 05, 2019 at 04:21:37PM +0300, Jani Nikula wrote:
> We have a local hack to test if headers are self-contained, while
> upstreaming a proper generic solution in kbuild [1]. Now that both have
> found themselves in linux-next, the identical cmd_header_test build
> commands conflict, leading to errors such as:
> 
> >> drivers/gpu/drm/i915/header_test_intel_audio.c:1:10: fatal error:
> >> drivers/gpu/drm/i915/intel_audio.h: No such file or directory
>     #include "drivers/gpu/drm/i915/intel_audio.h"
> 	     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Rename the i915 local build command until the proper kbuild solution
> finds its way to Linus' master and gets backported to our tree, and we
> can finally switch over.
You could also ihave switched over now, and accpet that this only would be used
in -next for a few months.

Then at least you did not have to rememebr to change it again.

Any way works for me, just a suggestion.

	Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915: rename header test build commands to avoid conflicts
  2019-06-05 13:21 [PATCH] drm/i915: rename header test build commands to avoid conflicts Jani Nikula
  2019-06-05 13:35 ` Sam Ravnborg
@ 2019-06-05 14:53 ` Patchwork
  2019-06-06  3:04 ` [PATCH] " yamada.masahiro
  2019-06-07  1:50 ` ✓ Fi.CI.IGT: success for " Patchwork
  3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-06-05 14:53 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: rename header test build commands to avoid conflicts
URL   : https://patchwork.freedesktop.org/series/61655/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6195 -> Patchwork_13179
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/

Known issues
------------

  Here are the changes found in Patchwork_13179 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_exec@basic:
    - fi-cml-u:           [PASS][1] -> [INCOMPLETE][2] ([fdo#110566])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/fi-cml-u/igt@gem_ctx_exec@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/fi-cml-u/igt@gem_ctx_exec@basic.html

  
#### Possible fixes ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][3] ([fdo#102614]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-icl-u3:          [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566


Participating hosts (52 -> 44)
------------------------------

  Additional (1): fi-apl-guc 
  Missing    (9): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-kbl-7560u fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6195 -> Patchwork_13179

  CI_DRM_6195: 06b71939f2477c76f9eecb1dd5e99dcb25cb8371 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5039: 2d4f470bba1cb51ed116fb80b170f717c6294714 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13179: 372ace4ba9e48be405ce0624313d1fba5e7b76da @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

372ace4ba9e4 drm/i915: rename header test build commands to avoid conflicts

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
  2019-06-05 13:21 [PATCH] drm/i915: rename header test build commands to avoid conflicts Jani Nikula
  2019-06-05 13:35 ` Sam Ravnborg
  2019-06-05 14:53 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-06-06  3:04 ` yamada.masahiro
  2019-06-06  7:24   ` Jani Nikula
  2019-06-07  1:50 ` ✓ Fi.CI.IGT: success for " Patchwork
  3 siblings, 1 reply; 10+ messages in thread
From: yamada.masahiro @ 2019-06-06  3:04 UTC (permalink / raw)
  To: jani.nikula, intel-gfx; +Cc: masahiroy, sam

[-- Attachment #1: Type: text/plain, Size: 2078 bytes --]

Hi,

> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@intel.com]
> Sent: Wednesday, June 05, 2019 10:22 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: jani.nikula@intel.com; kbuild test robot <lkp@intel.com>; Chris Wilson
> <chris@chris-wilson.co.uk>; Yamada, Masahiro/山田 真弘
> <yamada.masahiro@socionext.com>; Sam Ravnborg <sam@ravnborg.org>
> Subject: [PATCH] drm/i915: rename header test build commands to avoid
> conflicts
> 
> We have a local hack to test if headers are self-contained, while
> upstreaming a proper generic solution in kbuild [1]. Now that both have
> found themselves in linux-next, the identical cmd_header_test build
> commands conflict, leading to errors such as:
> 
> >> drivers/gpu/drm/i915/header_test_intel_audio.c:1:10: fatal error:
> >> drivers/gpu/drm/i915/intel_audio.h: No such file or directory
>     #include "drivers/gpu/drm/i915/intel_audio.h"
> 	     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Rename the i915 local build command until the proper kbuild solution
> finds its way to Linus' master and gets backported to our tree, and we
> can finally switch over.
> 
> Note that since the kbuild header test requires CONFIG_HEADER_TEST=y,
> and our hack requires our debug option CONFIG_DRM_I915_WERROR=y, this is
> likely hit only by build test bots.
> 
> [1] http://marc.info/?i=20190604124248.5564-1-jani.nikula@intel.com
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---


This is not really queued up yet.

So, we can squash fix-up to avoid 0day bot report.


I attached two patches.

00001-FIXUP1.patch is a one-liner fixup.
If you want to clean up your Makefile by yourself later,
I will squash it.


If you want to switch to the generic notation now,
I will squash 0001-FIXUP2.patch.


Either is OK for me.


Thanks.

Masahiro Yamada


[-- Attachment #2: 0001-FIXUP1.patch --]
[-- Type: application/octet-stream, Size: 867 bytes --]

From 1f6a6367354eec9fa8d9ebae4a9e8ba66ad68af7 Mon Sep 17 00:00:00 2001
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Thu, 6 Jun 2019 11:48:44 +0900
Subject: [PATCH] FIXUP1

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
 drivers/gpu/drm/i915/Makefile.header-test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index c1c391816fa7..2a456c9223db 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -37,7 +37,7 @@ header_test := \
 	intel_workarounds_types.h
 
 quiet_cmd_header_test = HDRTEST $@
-      cmd_header_test = echo "\#include \"$(<F)\"" > $@
+override cmd_header_test = echo "\#include \"$(<F)\"" > $@
 
 header_test_%.c: %.h
 	$(call cmd,header_test)
-- 
2.17.1


[-- Attachment #3: 0001-FIXUP2.patch --]
[-- Type: application/octet-stream, Size: 1616 bytes --]

From 22f46cedb22062f158e99d7eec18564f4d5b2eed Mon Sep 17 00:00:00 2001
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Thu, 6 Jun 2019 11:50:20 +0900
Subject: [PATCH] FIXUP2

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
 drivers/gpu/drm/i915/.gitignore           |  1 -
 drivers/gpu/drm/i915/Makefile.header-test | 12 +-----------
 2 files changed, 1 insertion(+), 12 deletions(-)
 delete mode 100644 drivers/gpu/drm/i915/.gitignore

diff --git a/drivers/gpu/drm/i915/.gitignore b/drivers/gpu/drm/i915/.gitignore
deleted file mode 100644
index cff45d81f42f..000000000000
--- a/drivers/gpu/drm/i915/.gitignore
+++ /dev/null
@@ -1 +0,0 @@
-header_test_*.c
diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index c1c391816fa7..639b596a06a9 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -2,7 +2,7 @@
 # Copyright © 2019 Intel Corporation
 
 # Test the headers are compilable as standalone units
-header_test := \
+header-test-$(CONFIG_DRM_I915_WERROR) := \
 	i915_active_types.h \
 	i915_gem_context_types.h \
 	i915_priolist_types.h \
@@ -35,13 +35,3 @@ header_test := \
 	intel_sprite.h \
 	intel_tv.h \
 	intel_workarounds_types.h
-
-quiet_cmd_header_test = HDRTEST $@
-      cmd_header_test = echo "\#include \"$(<F)\"" > $@
-
-header_test_%.c: %.h
-	$(call cmd,header_test)
-
-i915-$(CONFIG_DRM_I915_WERROR) += $(foreach h,$(header_test),$(patsubst %.h,header_test_%.o,$(h)))
-
-clean-files += $(foreach h,$(header_test),$(patsubst %.h,header_test_%.c,$(h)))
-- 
2.17.1


[-- Attachment #4: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
  2019-06-06  3:04 ` [PATCH] " yamada.masahiro
@ 2019-06-06  7:24   ` Jani Nikula
  2019-06-06  7:32     ` yamada.masahiro
  0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2019-06-06  7:24 UTC (permalink / raw)
  To: yamada.masahiro, intel-gfx; +Cc: masahiroy, sam

On Thu, 06 Jun 2019, <yamada.masahiro@socionext.com> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Jani Nikula [mailto:jani.nikula@intel.com]
>> Sent: Wednesday, June 05, 2019 10:22 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: jani.nikula@intel.com; kbuild test robot <lkp@intel.com>; Chris Wilson
>> <chris@chris-wilson.co.uk>; Yamada, Masahiro/山田 真弘
>> <yamada.masahiro@socionext.com>; Sam Ravnborg <sam@ravnborg.org>
>> Subject: [PATCH] drm/i915: rename header test build commands to avoid
>> conflicts
>> 
>> We have a local hack to test if headers are self-contained, while
>> upstreaming a proper generic solution in kbuild [1]. Now that both have
>> found themselves in linux-next, the identical cmd_header_test build
>> commands conflict, leading to errors such as:
>> 
>> >> drivers/gpu/drm/i915/header_test_intel_audio.c:1:10: fatal error:
>> >> drivers/gpu/drm/i915/intel_audio.h: No such file or directory
>>     #include "drivers/gpu/drm/i915/intel_audio.h"
>> 	     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> 
>> Rename the i915 local build command until the proper kbuild solution
>> finds its way to Linus' master and gets backported to our tree, and we
>> can finally switch over.
>> 
>> Note that since the kbuild header test requires CONFIG_HEADER_TEST=y,
>> and our hack requires our debug option CONFIG_DRM_I915_WERROR=y, this is
>> likely hit only by build test bots.
>> 
>> [1] http://marc.info/?i=20190604124248.5564-1-jani.nikula@intel.com
>> 
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>
>
> This is not really queued up yet.
>
> So, we can squash fix-up to avoid 0day bot report.

Except I don't think your linux-kbuild.git baseline has the files you're
patching below. The problem only exists at the merge of our trees,
currently only linux-next, and not "for real" until the v5.3 merge
window. So I think the sane option is to patch it up in our tree.

I want to use our local hack until we can get the backmerge from
v5.3-rc1, because it's 7-8 weeks away, and I want to retain our own
pre-merge build test coverage until then rather than relying on 0day
post-merge testing on linux-next.

BR,
Jani.


>
>
> I attached two patches.
>
> 00001-FIXUP1.patch is a one-liner fixup.
> If you want to clean up your Makefile by yourself later,
> I will squash it.
>
>
> If you want to switch to the generic notation now,
> I will squash 0001-FIXUP2.patch.
>
>
> Either is OK for me.
>
>
> Thanks.
>
> Masahiro Yamada
>
> From 1f6a6367354eec9fa8d9ebae4a9e8ba66ad68af7 Mon Sep 17 00:00:00 2001
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> Date: Thu, 6 Jun 2019 11:48:44 +0900
> Subject: [PATCH] FIXUP1
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>  drivers/gpu/drm/i915/Makefile.header-test | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
> index c1c391816fa7..2a456c9223db 100644
> --- a/drivers/gpu/drm/i915/Makefile.header-test
> +++ b/drivers/gpu/drm/i915/Makefile.header-test
> @@ -37,7 +37,7 @@ header_test := \
>  	intel_workarounds_types.h
>  
>  quiet_cmd_header_test = HDRTEST $@
> -      cmd_header_test = echo "\#include \"$(<F)\"" > $@
> +override cmd_header_test = echo "\#include \"$(<F)\"" > $@
>  
>  header_test_%.c: %.h
>  	$(call cmd,header_test)
> -- 
> 2.17.1
>
> From 22f46cedb22062f158e99d7eec18564f4d5b2eed Mon Sep 17 00:00:00 2001
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> Date: Thu, 6 Jun 2019 11:50:20 +0900
> Subject: [PATCH] FIXUP2
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>  drivers/gpu/drm/i915/.gitignore           |  1 -
>  drivers/gpu/drm/i915/Makefile.header-test | 12 +-----------
>  2 files changed, 1 insertion(+), 12 deletions(-)
>  delete mode 100644 drivers/gpu/drm/i915/.gitignore
>
> diff --git a/drivers/gpu/drm/i915/.gitignore b/drivers/gpu/drm/i915/.gitignore
> deleted file mode 100644
> index cff45d81f42f..000000000000
> --- a/drivers/gpu/drm/i915/.gitignore
> +++ /dev/null
> @@ -1 +0,0 @@
> -header_test_*.c
> diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
> index c1c391816fa7..639b596a06a9 100644
> --- a/drivers/gpu/drm/i915/Makefile.header-test
> +++ b/drivers/gpu/drm/i915/Makefile.header-test
> @@ -2,7 +2,7 @@
>  # Copyright (C) 2019 Intel Corporation
>  
>  # Test the headers are compilable as standalone units
> -header_test := \
> +header-test-$(CONFIG_DRM_I915_WERROR) := \
>  	i915_active_types.h \
>  	i915_gem_context_types.h \
>  	i915_priolist_types.h \
> @@ -35,13 +35,3 @@ header_test := \
>  	intel_sprite.h \
>  	intel_tv.h \
>  	intel_workarounds_types.h
> -
> -quiet_cmd_header_test = HDRTEST $@
> -      cmd_header_test = echo "\#include \"$(<F)\"" > $@
> -
> -header_test_%.c: %.h
> -	$(call cmd,header_test)
> -
> -i915-$(CONFIG_DRM_I915_WERROR) += $(foreach h,$(header_test),$(patsubst %.h,header_test_%.o,$(h)))
> -
> -clean-files += $(foreach h,$(header_test),$(patsubst %.h,header_test_%.c,$(h)))

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
  2019-06-06  7:24   ` Jani Nikula
@ 2019-06-06  7:32     ` yamada.masahiro
  2019-06-06  8:00       ` Jani Nikula
  0 siblings, 1 reply; 10+ messages in thread
From: yamada.masahiro @ 2019-06-06  7:32 UTC (permalink / raw)
  To: jani.nikula, intel-gfx; +Cc: masahiroy, sam

Hi Jani,

> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@intel.com]
> Sent: Thursday, June 06, 2019 4:25 PM
> To: Yamada, Masahiro/山田 真弘 <yamada.masahiro@socionext.com>;
> intel-gfx@lists.freedesktop.org
> Cc: lkp@intel.com; chris@chris-wilson.co.uk; sam@ravnborg.org;
> masahiroy@kernel.org
> Subject: RE: [PATCH] drm/i915: rename header test build commands to avoid
> conflicts
> 
> On Thu, 06 Jun 2019, <yamada.masahiro@socionext.com> wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Jani Nikula [mailto:jani.nikula@intel.com]
> >> Sent: Wednesday, June 05, 2019 10:22 PM
> >> To: intel-gfx@lists.freedesktop.org
> >> Cc: jani.nikula@intel.com; kbuild test robot <lkp@intel.com>; Chris
> Wilson
> >> <chris@chris-wilson.co.uk>; Yamada, Masahiro/山田 真弘
> >> <yamada.masahiro@socionext.com>; Sam Ravnborg <sam@ravnborg.org>
> >> Subject: [PATCH] drm/i915: rename header test build commands to avoid
> >> conflicts
> >>
> >> We have a local hack to test if headers are self-contained, while
> >> upstreaming a proper generic solution in kbuild [1]. Now that both have
> >> found themselves in linux-next, the identical cmd_header_test build
> >> commands conflict, leading to errors such as:
> >>
> >> >> drivers/gpu/drm/i915/header_test_intel_audio.c:1:10: fatal error:
> >> >> drivers/gpu/drm/i915/intel_audio.h: No such file or directory
> >>     #include "drivers/gpu/drm/i915/intel_audio.h"
> >> 	     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>
> >> Rename the i915 local build command until the proper kbuild solution
> >> finds its way to Linus' master and gets backported to our tree, and we
> >> can finally switch over.
> >>
> >> Note that since the kbuild header test requires CONFIG_HEADER_TEST=y,
> >> and our hack requires our debug option CONFIG_DRM_I915_WERROR=y, this
> is
> >> likely hit only by build test bots.
> >>
> >> [1] http://marc.info/?i=20190604124248.5564-1-jani.nikula@intel.com
> >>
> >> Reported-by: kbuild test robot <lkp@intel.com>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> Cc: Sam Ravnborg <sam@ravnborg.org>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >
> >
> > This is not really queued up yet.
> >
> > So, we can squash fix-up to avoid 0day bot report.
> 
> Except I don't think your linux-kbuild.git baseline has the files you're
> patching below. The problem only exists at the merge of our trees,
> currently only linux-next, and not "for real" until the v5.3 merge
> window. So I think the sane option is to patch it up in our tree.


I do not understand.

This is a _real_ problem since
  drivers/gpu/drm/i915/Makefile.header-test
exists in Linus' tree.


The 0-day bot reported the build error against my tree,
so I must fix it in my tree.


> I want to use our local hack until we can get the backmerge from
> v5.3-rc1, because it's 7-8 weeks away, and I want to retain our own
> pre-merge build test coverage until then rather than relying on 0day
> post-merge testing on linux-next.


Neither of my patches breaks your test coverage.
CONFIG_DRM_I915_WERROR still works in linux-next too.

What am I missing?



Thanks.

Masahiro Yamada

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
  2019-06-06  7:32     ` yamada.masahiro
@ 2019-06-06  8:00       ` Jani Nikula
  2019-06-06 12:03         ` Masahiro Yamada
  0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2019-06-06  8:00 UTC (permalink / raw)
  To: yamada.masahiro, intel-gfx; +Cc: masahiroy, sam

On Thu, 06 Jun 2019, <yamada.masahiro@socionext.com> wrote:
> Hi Jani,
>
>> -----Original Message-----
>> From: Jani Nikula [mailto:jani.nikula@intel.com]
>> Sent: Thursday, June 06, 2019 4:25 PM
>> To: Yamada, Masahiro/山田 真弘 <yamada.masahiro@socionext.com>;
>> intel-gfx@lists.freedesktop.org
>> Cc: lkp@intel.com; chris@chris-wilson.co.uk; sam@ravnborg.org;
>> masahiroy@kernel.org
>> Subject: RE: [PATCH] drm/i915: rename header test build commands to avoid
>> conflicts
>> 
>> On Thu, 06 Jun 2019, <yamada.masahiro@socionext.com> wrote:
>> > Hi,
>> >
>> >> -----Original Message-----
>> >> From: Jani Nikula [mailto:jani.nikula@intel.com]
>> >> Sent: Wednesday, June 05, 2019 10:22 PM
>> >> To: intel-gfx@lists.freedesktop.org
>> >> Cc: jani.nikula@intel.com; kbuild test robot <lkp@intel.com>; Chris
>> Wilson
>> >> <chris@chris-wilson.co.uk>; Yamada, Masahiro/山田 真弘
>> >> <yamada.masahiro@socionext.com>; Sam Ravnborg <sam@ravnborg.org>
>> >> Subject: [PATCH] drm/i915: rename header test build commands to avoid
>> >> conflicts
>> >>
>> >> We have a local hack to test if headers are self-contained, while
>> >> upstreaming a proper generic solution in kbuild [1]. Now that both have
>> >> found themselves in linux-next, the identical cmd_header_test build
>> >> commands conflict, leading to errors such as:
>> >>
>> >> >> drivers/gpu/drm/i915/header_test_intel_audio.c:1:10: fatal error:
>> >> >> drivers/gpu/drm/i915/intel_audio.h: No such file or directory
>> >>     #include "drivers/gpu/drm/i915/intel_audio.h"
>> >> 	     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> >>
>> >> Rename the i915 local build command until the proper kbuild solution
>> >> finds its way to Linus' master and gets backported to our tree, and we
>> >> can finally switch over.
>> >>
>> >> Note that since the kbuild header test requires CONFIG_HEADER_TEST=y,
>> >> and our hack requires our debug option CONFIG_DRM_I915_WERROR=y, this
>> is
>> >> likely hit only by build test bots.
>> >>
>> >> [1] http://marc.info/?i=20190604124248.5564-1-jani.nikula@intel.com
>> >>
>> >> Reported-by: kbuild test robot <lkp@intel.com>
>> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> >> Cc: Sam Ravnborg <sam@ravnborg.org>
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >> ---
>> >
>> >
>> > This is not really queued up yet.
>> >
>> > So, we can squash fix-up to avoid 0day bot report.
>> 
>> Except I don't think your linux-kbuild.git baseline has the files you're
>> patching below. The problem only exists at the merge of our trees,
>> currently only linux-next, and not "for real" until the v5.3 merge
>> window. So I think the sane option is to patch it up in our tree.
>
>
> I do not understand.
>
> This is a _real_ problem since
>   drivers/gpu/drm/i915/Makefile.header-test
> exists in Linus' tree.
>
>
> The 0-day bot reported the build error against my tree,
> so I must fix it in my tree.
>
>
>> I want to use our local hack until we can get the backmerge from
>> v5.3-rc1, because it's 7-8 weeks away, and I want to retain our own
>> pre-merge build test coverage until then rather than relying on 0day
>> post-merge testing on linux-next.
>
>
> Neither of my patches breaks your test coverage.
> CONFIG_DRM_I915_WERROR still works in linux-next too.
>
> What am I missing?

Apologies, my bad. I completely failed to realize Makefile.header-test
already hit Linus' tree. *facepalm*

You're totally right, it needs to be fixed in your tree. For that, I
think the best option is your fixup patch #2.

(Now that header-test-y is behind CONFIG_HEADER_TEST=y, I don't think
this really requires CONFIG_DRM_I915_WERROR=y anymore, but no big deal
either way.)

We do have two more instances in -next that are not in Linus' tree, so
we'll need to fix those locally anyway. Part of the confusion.


BR,
Jani.



>
>
>
> Thanks.
>
> Masahiro Yamada
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
  2019-06-06  8:00       ` Jani Nikula
@ 2019-06-06 12:03         ` Masahiro Yamada
  2019-06-06 12:16           ` Jani Nikula
  0 siblings, 1 reply; 10+ messages in thread
From: Masahiro Yamada @ 2019-06-06 12:03 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx, Sam Ravnborg

On Thu, Jun 6, 2019 at 4:57 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> You're totally right, it needs to be fixed in your tree. For that, I
> think the best option is your fixup patch #2.


OK, I will squash patch #2.


-- 
Best Regards
Masahiro Yamada
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
  2019-06-06 12:03         ` Masahiro Yamada
@ 2019-06-06 12:16           ` Jani Nikula
  0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2019-06-06 12:16 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: intel-gfx, Sam Ravnborg

On Thu, 06 Jun 2019, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> On Thu, Jun 6, 2019 at 4:57 PM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> You're totally right, it needs to be fixed in your tree. For that, I
>> think the best option is your fixup patch #2.
>
>
> OK, I will squash patch #2.

Many thanks!

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* ✓ Fi.CI.IGT: success for drm/i915: rename header test build commands to avoid conflicts
  2019-06-05 13:21 [PATCH] drm/i915: rename header test build commands to avoid conflicts Jani Nikula
                   ` (2 preceding siblings ...)
  2019-06-06  3:04 ` [PATCH] " yamada.masahiro
@ 2019-06-07  1:50 ` Patchwork
  3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-06-07  1:50 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: rename header test build commands to avoid conflicts
URL   : https://patchwork.freedesktop.org/series/61655/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6195_full -> Patchwork_13179_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_13179_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@gem_exec_balancer@smoke}:
    - shard-iclb:         [PASS][1] -> [SKIP][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb1/igt@gem_exec_balancer@smoke.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb6/igt@gem_exec_balancer@smoke.html

  
Known issues
------------

  Here are the changes found in Patchwork_13179_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@in-flight-suspend:
    - shard-iclb:         [PASS][3] -> [INCOMPLETE][4] ([fdo#107713])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb5/igt@gem_eio@in-flight-suspend.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb7/igt@gem_eio@in-flight-suspend.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-kbl:          [PASS][5] -> [FAIL][6] ([fdo#108686])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-kbl6/igt@gem_tiled_swapping@non-threaded.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-kbl3/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_pm_rpm@i2c:
    - shard-hsw:          [PASS][7] -> [FAIL][8] ([fdo#104097])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-hsw7/igt@i915_pm_rpm@i2c.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-hsw1/igt@i915_pm_rpm@i2c.html

  * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
    - shard-skl:          [PASS][9] -> [FAIL][10] ([fdo#103184] / [fdo#103232])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-skl6/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-skl7/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#102887] / [fdo#105363])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-hsw2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-hsw8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
    - shard-iclb:         [PASS][13] -> [FAIL][14] ([fdo#103167]) +7 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
    - shard-hsw:          [PASS][15] -> [SKIP][16] ([fdo#109271]) +26 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-hsw6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-apl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][19] -> [FAIL][20] ([fdo#108145] / [fdo#110403])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][21] -> [FAIL][22] ([fdo#99912])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-kbl3/igt@kms_setmode@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-kbl2/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * {igt@gem_exec_balancer@bonded-imm}:
    - shard-iclb:         [FAIL][23] -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb4/igt@gem_exec_balancer@bonded-imm.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb8/igt@gem_exec_balancer@bonded-imm.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-apl:          [DMESG-WARN][25] ([fdo#108686]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-apl2/igt@gem_tiled_swapping@non-threaded.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-apl4/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +4 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-apl5/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_pm_backlight@fade_with_suspend:
    - shard-skl:          [INCOMPLETE][29] ([fdo#104108]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-skl7/igt@i915_pm_backlight@fade_with_suspend.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-skl2/igt@i915_pm_backlight@fade_with_suspend.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-skl:          [INCOMPLETE][31] ([fdo#104108] / [fdo#107807]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-skl9/igt@i915_pm_rpm@system-suspend-execbuf.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-skl9/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][33] ([fdo#109349]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_frontbuffer_tracking@fbc-1p-rte:
    - shard-iclb:         [FAIL][35] ([fdo#103167] / [fdo#110378]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-rte.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
    - shard-hsw:          [SKIP][37] ([fdo#109271]) -> [PASS][38] +19 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [SKIP][39] ([fdo#109441]) -> [PASS][40] +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb7/igt@kms_psr@psr2_suspend.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb2/igt@kms_psr@psr2_suspend.html

  
#### Warnings ####

  * igt@gem_mmap_gtt@forked-big-copy-odd:
    - shard-iclb:         [INCOMPLETE][41] ([fdo#107713] / [fdo#109100]) -> [TIMEOUT][42] ([fdo#109673])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb3/igt@gem_mmap_gtt@forked-big-copy-odd.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb6/igt@gem_mmap_gtt@forked-big-copy-odd.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [FAIL][43] ([fdo#108686]) -> [INCOMPLETE][44] ([fdo#107713] / [fdo#108686])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-iclb6/igt@gem_tiled_swapping@non-threaded.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-iclb2/igt@gem_tiled_swapping@non-threaded.html
    - shard-hsw:          [FAIL][45] ([fdo#108686]) -> [INCOMPLETE][46] ([fdo#103540])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-hsw1/igt@gem_tiled_swapping@non-threaded.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-hsw7/igt@gem_tiled_swapping@non-threaded.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          [SKIP][47] ([fdo#109271]) -> [FAIL][48] ([fdo#105767])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-skl:          [FAIL][49] ([fdo#108040]) -> [FAIL][50] ([fdo#103167])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6195/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
  [fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6195 -> Patchwork_13179

  CI_DRM_6195: 06b71939f2477c76f9eecb1dd5e99dcb25cb8371 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5039: 2d4f470bba1cb51ed116fb80b170f717c6294714 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13179: 372ace4ba9e48be405ce0624313d1fba5e7b76da @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13179/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-06-07  1:50 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 13:21 [PATCH] drm/i915: rename header test build commands to avoid conflicts Jani Nikula
2019-06-05 13:35 ` Sam Ravnborg
2019-06-05 14:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-06  3:04 ` [PATCH] " yamada.masahiro
2019-06-06  7:24   ` Jani Nikula
2019-06-06  7:32     ` yamada.masahiro
2019-06-06  8:00       ` Jani Nikula
2019-06-06 12:03         ` Masahiro Yamada
2019-06-06 12:16           ` Jani Nikula
2019-06-07  1:50 ` ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.