Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa_init

From: Matthias Brugger <matthias.bgg@gmail.com>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
	Roman Gushchin <guro@fb.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	John Garry <john.garry@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"Zengtao (B)" <prime.zeng@hisilicon.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"hch@lst.de" <hch@lst.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa_init
Date: Tue, 9 Jun 2020 17:33:45 +0200	[thread overview]
Message-ID: <a1ef3b6c-edc5-b190-5ce6-e446cf73ccc8@gmail.com> (raw)
In-Reply-To: <B926444035E5E2439431908E3842AFD24E1ED7@DGGEMI525-MBS.china.huawei.com>

On 08/06/2020 02:50, Song Bao Hua (Barry Song) wrote:
> 
> 
>> -----Original Message-----
>> From: Matthias Brugger [mailto:matthias.bgg@gmail.com]
>> Sent: Monday, June 8, 2020 8:15 AM
>> To: Roman Gushchin <guro@fb.com>; Song Bao Hua (Barry Song)
>> <song.bao.hua@hisilicon.com>
>> Cc: catalin.marinas@arm.com; John Garry <john.garry@huawei.com>;
>> linux-kernel@vger.kernel.org; Linuxarm <linuxarm@huawei.com>;
>> iommu@lists.linux-foundation.org; Zengtao (B) <prime.zeng@hisilicon.com>;
>> Jonathan Cameron <jonathan.cameron@huawei.com>;
>> robin.murphy@arm.com; hch@lst.de; linux-arm-kernel@lists.infradead.org;
>> m.szyprowski@samsung.com
>> Subject: Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa_init
>>
>>
>>
>> On 03/06/2020 05:22, Roman Gushchin wrote:
>>> On Wed, Jun 03, 2020 at 02:42:30PM +1200, Barry Song wrote:
>>>> hugetlb_cma_reserve() is called at the wrong place. numa_init has not been
>>>> done yet. so all reserved memory will be located at node0.
>>>>
>>>> Cc: Roman Gushchin <guro@fb.com>
>>>> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
>>>
>>> Acked-by: Roman Gushchin <guro@fb.com>
>>>
>>
>> When did this break or was it broken since the beginning?
>> In any case, could you provide a "Fixes" tag for it, so that it can easily be
>> backported to older releases.
> 
> I guess it was broken at the first beginning.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf11e85fc08cc
> 
> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
> 
> Would you think it is better for me to send v2 for this patch separately with this tag and take this out of my original patch set for per-numa CMA?
> Please give your suggestion.
> 

I'm not the maintainer but I think it could help to get the patch accepted
earlier while you address the rest of the series.

Regards,
Matthias