* [qemu-web RFC] CONTRIBUTING.md: Mention maintainers
@ 2021-09-06 17:00 Hanna Reitz
2021-09-07 12:57 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Hanna Reitz @ 2021-09-06 17:00 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Hanna Reitz, Thomas Huth
All patches to the QEMU website should be CC-ed to the website
maintainers, who (right now) are Thomas and Paolo.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
This is an RFC first because I feel bad about sending a patch that
gives people responsibilities who aren't me. But Thomas seemed to agree
with me that making this requirement explicit would be nice, so I guess
someone has to send a patch for it...
Second, I'm not sure whether this is the ideal place. Perhaps we should
have a MAINTAINERS file, but on the other hand, maybe that would be a
bit too much.
---
CONTRIBUTING.md | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b5209ac..d5cbf07 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -5,6 +5,11 @@ the the developer mailing list:
https://lists.nongnu.org/mailman/listinfo/qemu-devel
+You should also CC the website maintainers:
+
+* Thomas Huth <thuth@redhat.com>
+* Paolo Bonzini <pbonzini@redhat.com>
+
For further guidance on sending patches consult:
https://wiki.qemu.org/Contribute/SubmitAPatch
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [qemu-web RFC] CONTRIBUTING.md: Mention maintainers
2021-09-06 17:00 [qemu-web RFC] CONTRIBUTING.md: Mention maintainers Hanna Reitz
@ 2021-09-07 12:57 ` Paolo Bonzini
2021-09-07 13:40 ` Thomas Huth
2021-09-07 13:56 ` Hanna Reitz
0 siblings, 2 replies; 5+ messages in thread
From: Paolo Bonzini @ 2021-09-07 12:57 UTC (permalink / raw)
To: Hanna Reitz, qemu-devel; +Cc: Thomas Huth
On 06/09/21 19:00, Hanna Reitz wrote:
> This is an RFC first because I feel bad about sending a patch that
> gives people responsibilities who aren't me. But Thomas seemed to agree
> with me that making this requirement explicit would be nice, so I guess
> someone has to send a patch for it...
Don't feel bad, I'll make sure you'll have to send a v2. Actually I'm
kidding, this looks good to me and I've merged it.
But we should make a decision on accepting qemu-web merge requests on
GitLab. For that, apart from touching the CONTRIBUTING.md file, we
should also edit
https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/ which
suggests using "git send-email".
Paolo
> Second, I'm not sure whether this is the ideal place. Perhaps we should
> have a MAINTAINERS file, but on the other hand, maybe that would be a
> bit too much.
> ---
> CONTRIBUTING.md | 5 +++++
> 1 file changed, 5 insertions(+)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [qemu-web RFC] CONTRIBUTING.md: Mention maintainers
2021-09-07 12:57 ` Paolo Bonzini
@ 2021-09-07 13:40 ` Thomas Huth
2021-09-08 6:02 ` Paolo Bonzini
2021-09-07 13:56 ` Hanna Reitz
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2021-09-07 13:40 UTC (permalink / raw)
To: Paolo Bonzini, Hanna Reitz, qemu-devel
On 07/09/2021 14.57, Paolo Bonzini wrote:
> On 06/09/21 19:00, Hanna Reitz wrote:
>> This is an RFC first because I feel bad about sending a patch that
>> gives people responsibilities who aren't me. But Thomas seemed to agree
>> with me that making this requirement explicit would be nice, so I guess
>> someone has to send a patch for it...
>
> Don't feel bad, I'll make sure you'll have to send a v2. Actually I'm
> kidding, this looks good to me and I've merged it.
Yes, that was a good idea. Ack from my side, too.
> But we should make a decision on accepting qemu-web merge requests on
> GitLab. For that, apart from touching the CONTRIBUTING.md file, we should
> also edit https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/ which
> suggests using "git send-email".
Not sure whether that old blog post is the right place for this information
... we should maybe have a pointer to the information on
https://www.qemu.org/contribute/ instead?
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [qemu-web RFC] CONTRIBUTING.md: Mention maintainers
2021-09-07 12:57 ` Paolo Bonzini
2021-09-07 13:40 ` Thomas Huth
@ 2021-09-07 13:56 ` Hanna Reitz
1 sibling, 0 replies; 5+ messages in thread
From: Hanna Reitz @ 2021-09-07 13:56 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Thomas Huth
On 07.09.21 14:57, Paolo Bonzini wrote:
> On 06/09/21 19:00, Hanna Reitz wrote:
>> This is an RFC first because I feel bad about sending a patch that
>> gives people responsibilities who aren't me. But Thomas seemed to agree
>> with me that making this requirement explicit would be nice, so I guess
>> someone has to send a patch for it...
>
> Don't feel bad, I'll make sure you'll have to send a v2.
Well, as long as you aren’t asking me to take responsibility so I could
feel less bad...
> Actually I'm kidding, this looks good to me and I've merged it.
Thanks!
> But we should make a decision on accepting qemu-web merge requests on
> GitLab. For that, apart from touching the CONTRIBUTING.md file, we
> should also edit
> https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/ which
> suggests using "git send-email".
Well, it’s definitely not my decision to make, but FWIW I’m in favor.
Hanna
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [qemu-web RFC] CONTRIBUTING.md: Mention maintainers
2021-09-07 13:40 ` Thomas Huth
@ 2021-09-08 6:02 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2021-09-08 6:02 UTC (permalink / raw)
To: Thomas Huth, Hanna Reitz, qemu-devel
On 07/09/21 15:40, Thomas Huth wrote:
> we should maybe have a pointer to the information on
> https://www.qemu.org/contribute/ instead?
Yes - right now contribute/ links to the old blog post for "Improve the
web site", but I guess it couuld just go to
https://gitlab.com/qemu-project/qemu-web/-/merge_requests; "whoever has
ears, let them hear".
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-08 6:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 17:00 [qemu-web RFC] CONTRIBUTING.md: Mention maintainers Hanna Reitz
2021-09-07 12:57 ` Paolo Bonzini
2021-09-07 13:40 ` Thomas Huth
2021-09-08 6:02 ` Paolo Bonzini
2021-09-07 13:56 ` Hanna Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.