All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Schiffer <mschiffer@universe-factory.net>
To: Johannes Berg <johannes@sipsolutions.net>, Jiri Benc <jbenc@redhat.com>
Cc: davem@davemloft.net, hannes@stressinduktion.org, pshelar@ovn.org,
	aduyck@mirantis.com, roopa@cumulusnetworks.com,
	netdev@vger.kernel.org, dev@openvswitch.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration
Date: Fri, 23 Jun 2017 14:02:26 +0200	[thread overview]
Message-ID: <a250dc2b-1249-2cfe-6f39-06b7f0874f59@universe-factory.net> (raw)
In-Reply-To: <1498213402.2595.3.camel@sipsolutions.net>


[-- Attachment #1.1: Type: text/plain, Size: 876 bytes --]

On 06/23/2017 12:23 PM, Johannes Berg wrote:
> On Fri, 2017-06-23 at 12:13 +0200, Matthias Schiffer wrote:
>>
>> I was told the extended netlink error facilities were not ready yet,
>> has that changed since the last release?
> 
> Yes, the facility is in the kernel tree now.
> 
>> Anyways, I will gladly work on improving the error handling if
>> someone can give me a pointer how these extended netlink errors are
>> used.
> 
> Just grep for 'netlink_ext_ack' :)
> 
> johannes
> 

Thanks for the hint.

It seems though that rtnl_link_ops.newlink/changelink don't allow passing
the extack yet... how do we proceed here? Treewide change (maybe by someone
who knows their Coccinelle-fu?), or would the introduction of new versions
of the newlink and changelink fields be more acceptable, so drivers can be
moved to the new API one by one?

Matthias


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Schiffer <mschiffer-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	roopa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	aduyck-nYU0QVwCCFFWk0Htik3J/w@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration
Date: Fri, 23 Jun 2017 14:02:26 +0200	[thread overview]
Message-ID: <a250dc2b-1249-2cfe-6f39-06b7f0874f59@universe-factory.net> (raw)
In-Reply-To: <1498213402.2595.3.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 876 bytes --]

On 06/23/2017 12:23 PM, Johannes Berg wrote:
> On Fri, 2017-06-23 at 12:13 +0200, Matthias Schiffer wrote:
>>
>> I was told the extended netlink error facilities were not ready yet,
>> has that changed since the last release?
> 
> Yes, the facility is in the kernel tree now.
> 
>> Anyways, I will gladly work on improving the error handling if
>> someone can give me a pointer how these extended netlink errors are
>> used.
> 
> Just grep for 'netlink_ext_ack' :)
> 
> johannes
> 

Thanks for the hint.

It seems though that rtnl_link_ops.newlink/changelink don't allow passing
the extack yet... how do we proceed here? Treewide change (maybe by someone
who knows their Coccinelle-fu?), or would the introduction of new versions
of the newlink and changelink fields be more acceptable, so drivers can be
moved to the new API one by one?

Matthias


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2017-06-23 12:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19  8:03 [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support Matthias Schiffer
2017-06-19  8:03 ` [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration Matthias Schiffer
2017-06-19  8:03   ` Matthias Schiffer
2017-06-23  8:52   ` Jiri Benc
2017-06-23  8:52     ` Jiri Benc
2017-06-23 10:13     ` Matthias Schiffer
2017-06-23 10:13       ` Matthias Schiffer
2017-06-23 10:23       ` Johannes Berg
2017-06-23 10:23         ` Johannes Berg
2017-06-23 12:02         ` Matthias Schiffer [this message]
2017-06-23 12:02           ` Matthias Schiffer
2017-06-23 13:31           ` Johannes Berg
2017-06-23 13:31             ` Johannes Berg
2017-06-19  8:03 ` [PATCH net-next v3 2/6] vxlan: get rid of redundant vxlan_dev.flags Matthias Schiffer
2017-06-19  8:03   ` Matthias Schiffer
2017-06-19  8:03 ` [PATCH net-next v3 3/6] vxlan: improve validation of address family configuration Matthias Schiffer
2017-06-19  8:03 ` [PATCH net-next v3 4/6] vxlan: check valid combinations of address scopes Matthias Schiffer
2017-06-19  8:03 ` [PATCH net-next v3 5/6] vxlan: fix snooping for link-local IPv6 addresses Matthias Schiffer
2017-06-19  8:04 ` [PATCH net-next v3 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses Matthias Schiffer
2017-06-20 17:37 ` [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a250dc2b-1249-2cfe-6f39-06b7f0874f59@universe-factory.net \
    --to=mschiffer@universe-factory.net \
    --cc=aduyck@mirantis.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=hannes@stressinduktion.org \
    --cc=jbenc@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.