From: Jiri Slaby <jirislaby@kernel.org> To: Xianting Tian <xianting.tian@linux.alibaba.com>, gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de Cc: linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, osandov@fb.com Subject: Re: [PATCH 2/2] virtio-console: remove unnecessary kmemdup() Date: Mon, 2 Aug 2021 10:40:03 +0200 [thread overview] Message-ID: <a2598ec9-7bc9-be42-bcab-fa19c9e734f7@kernel.org> (raw) In-Reply-To: <5ad81a0e-fbb2-a849-6db7-f5718633d282@linux.alibaba.com> On 02. 08. 21, 10:32, Xianting Tian wrote: > > 在 2021/8/2 下午3:25, Jiri Slaby 写道: >> Hi, >> >> why is this 2/2? I seem (Lore neither) to find 1/2. > You didn't receive 1/2? > [PATCH 1/2] tty: hvc: pass DMA capable memory to put_chars() > https://lkml.org/lkml/2021/8/1/8 <https://lkml.org/lkml/2021/8/1/8> Oh, I did, but it's not properly threaded. PLease fix your setup. >> On 01. 08. 21, 7:16, Xianting Tian wrote: >>> hvc framework will never pass stack memory to the put_chars() function, >> >> Am I blind or missing something? >> >> hvc_console_print(...) >> { >> char c[N_OUTBUF] >> ... >> cons_ops[index]->put_chars(vtermnos[index], c, i); >> >> The same here: >> >> hvc_poll_put_char(..., char ch) >> { >> ... >> n = hp->ops->put_chars(hp->vtermno, &ch, 1); >> >> AFAICS both of them *pass* a pointer to stack variable. > > yes, I discussed the issue with Arnd before in below thread, you can > get the history, thanks > > https://lkml.org/lkml/2021/7/27/494 <https://lkml.org/lkml/2021/7/27/494> So is this a v2? You should have noted that. And what changed from v1 too. >>> So the calling of kmemdup() is unnecessary, remove it. >>> >>> Fixes: c4baad5029 ("virtio-console: avoid DMA from stack") >> >> This patch doesn't "Fix" -- it reverts the commit. You should've CCed >> the author too. > > yes, we discussed ther issue in above thread, which we CCed the author. I don't see any input from the author? Anyway, 1/2 does not even build, so you will send v3 with all the above fixed, hopefully. thanks, -- js
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org> To: Xianting Tian <xianting.tian@linux.alibaba.com>, gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de Cc: osandov@fb.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 2/2] virtio-console: remove unnecessary kmemdup() Date: Mon, 2 Aug 2021 10:40:03 +0200 [thread overview] Message-ID: <a2598ec9-7bc9-be42-bcab-fa19c9e734f7@kernel.org> (raw) In-Reply-To: <5ad81a0e-fbb2-a849-6db7-f5718633d282@linux.alibaba.com> On 02. 08. 21, 10:32, Xianting Tian wrote: > > 在 2021/8/2 下午3:25, Jiri Slaby 写道: >> Hi, >> >> why is this 2/2? I seem (Lore neither) to find 1/2. > You didn't receive 1/2? > [PATCH 1/2] tty: hvc: pass DMA capable memory to put_chars() > https://lkml.org/lkml/2021/8/1/8 <https://lkml.org/lkml/2021/8/1/8> Oh, I did, but it's not properly threaded. PLease fix your setup. >> On 01. 08. 21, 7:16, Xianting Tian wrote: >>> hvc framework will never pass stack memory to the put_chars() function, >> >> Am I blind or missing something? >> >> hvc_console_print(...) >> { >> char c[N_OUTBUF] >> ... >> cons_ops[index]->put_chars(vtermnos[index], c, i); >> >> The same here: >> >> hvc_poll_put_char(..., char ch) >> { >> ... >> n = hp->ops->put_chars(hp->vtermno, &ch, 1); >> >> AFAICS both of them *pass* a pointer to stack variable. > > yes, I discussed the issue with Arnd before in below thread, you can > get the history, thanks > > https://lkml.org/lkml/2021/7/27/494 <https://lkml.org/lkml/2021/7/27/494> So is this a v2? You should have noted that. And what changed from v1 too. >>> So the calling of kmemdup() is unnecessary, remove it. >>> >>> Fixes: c4baad5029 ("virtio-console: avoid DMA from stack") >> >> This patch doesn't "Fix" -- it reverts the commit. You should've CCed >> the author too. > > yes, we discussed ther issue in above thread, which we CCed the author. I don't see any input from the author? Anyway, 1/2 does not even build, so you will send v3 with all the above fixed, hopefully. thanks, -- js
next prev parent reply other threads:[~2021-08-02 8:40 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-01 5:16 [PATCH 2/2] virtio-console: remove unnecessary kmemdup() Xianting Tian 2021-08-01 5:16 ` Xianting Tian 2021-08-02 7:25 ` Jiri Slaby 2021-08-02 7:25 ` Jiri Slaby 2021-08-02 8:32 ` Xianting Tian 2021-08-02 8:40 ` Jiri Slaby [this message] 2021-08-02 8:40 ` Jiri Slaby 2021-08-02 8:55 ` Xianting Tian 2021-08-02 8:55 ` Xianting Tian
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a2598ec9-7bc9-be42-bcab-fa19c9e734f7@kernel.org \ --to=jirislaby@kernel.org \ --cc=amit@kernel.org \ --cc=arnd@arndb.de \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=osandov@fb.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xianting.tian@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.