* [PATCH] gitlab-ci.yml: Merge the trace-backend testing into other jobs
@ 2021-03-19 9:57 Thomas Huth
2021-03-19 13:26 ` Wainer dos Santos Moschetta
2021-03-19 13:56 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-03-19 9:57 UTC (permalink / raw)
To: qemu-devel, Alex Bennée
Cc: Willian Rampazzo, Stefan Hajnoczi, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta
Our gitlab-ci got quite slow in the past weeks, due to the immense amount
of jobs that we have, so we should try to reduce the number of jobs.
There is no real good reason for having separate jobs just to test the
trace backends, we can do this just fine in other jobs, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.gitlab-ci.yml | 30 +++---------------------------
1 file changed, 3 insertions(+), 27 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 0cc6d53f7e..cbbd67f139 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -87,7 +87,7 @@ build-system-alpine:
TARGETS: aarch64-softmmu alpha-softmmu cris-softmmu hppa-softmmu
moxie-softmmu microblazeel-softmmu mips64el-softmmu
MAKE_CHECK_ARGS: check-build
- CONFIGURE_ARGS: --enable-docs
+ CONFIGURE_ARGS: --enable-docs --enable-trace-backends=log,simple,syslog
artifacts:
expire_in: 2 days
paths:
@@ -608,7 +608,7 @@ tsan-build:
variables:
IMAGE: ubuntu2004
CONFIGURE_ARGS: --enable-tsan --cc=clang-10 --cxx=clang++-10 --disable-docs
- --enable-fdt=system --enable-slirp=system
+ --enable-trace-backends=ust --enable-fdt=system --enable-slirp=system
TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user
MAKE_CHECK_ARGS: bench V=1
@@ -706,6 +706,7 @@ build-coroutine-sigaltstack:
variables:
IMAGE: ubuntu2004
CONFIGURE_ARGS: --with-coroutine=sigaltstack --disable-tcg
+ --enable-trace-backends=ftrace
MAKE_CHECK_ARGS: check-unit
# Most jobs test latest gcrypt or nettle builds
@@ -743,31 +744,6 @@ crypto-only-gnutls:
MAKE_CHECK_ARGS: check
-# We don't need to exercise every backend with every front-end
-build-trace-multi-user:
- <<: *native_build_job_definition
- needs:
- job: amd64-ubuntu2004-container
- variables:
- IMAGE: ubuntu2004
- CONFIGURE_ARGS: --enable-trace-backends=log,simple,syslog --disable-system
-
-build-trace-ftrace-system:
- <<: *native_build_job_definition
- needs:
- job: amd64-ubuntu2004-container
- variables:
- IMAGE: ubuntu2004
- CONFIGURE_ARGS: --enable-trace-backends=ftrace --target-list=x86_64-softmmu
-
-build-trace-ust-system:
- <<: *native_build_job_definition
- needs:
- job: amd64-ubuntu2004-container
- variables:
- IMAGE: ubuntu2004
- CONFIGURE_ARGS: --enable-trace-backends=ust --target-list=x86_64-softmmu
-
# Check our reduced build configurations
build-without-default-devices:
<<: *native_build_job_definition
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitlab-ci.yml: Merge the trace-backend testing into other jobs
2021-03-19 9:57 [PATCH] gitlab-ci.yml: Merge the trace-backend testing into other jobs Thomas Huth
@ 2021-03-19 13:26 ` Wainer dos Santos Moschetta
2021-03-19 13:56 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-03-19 13:26 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Alex Bennée
Cc: Willian Rampazzo, Philippe Mathieu-Daudé, Stefan Hajnoczi
Hi,
On 3/19/21 6:57 AM, Thomas Huth wrote:
> Our gitlab-ci got quite slow in the past weeks, due to the immense amount
> of jobs that we have, so we should try to reduce the number of jobs.
> There is no real good reason for having separate jobs just to test the
> trace backends, we can do this just fine in other jobs, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .gitlab-ci.yml | 30 +++---------------------------
> 1 file changed, 3 insertions(+), 27 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 0cc6d53f7e..cbbd67f139 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -87,7 +87,7 @@ build-system-alpine:
> TARGETS: aarch64-softmmu alpha-softmmu cris-softmmu hppa-softmmu
> moxie-softmmu microblazeel-softmmu mips64el-softmmu
> MAKE_CHECK_ARGS: check-build
> - CONFIGURE_ARGS: --enable-docs
> + CONFIGURE_ARGS: --enable-docs --enable-trace-backends=log,simple,syslog
> artifacts:
> expire_in: 2 days
> paths:
> @@ -608,7 +608,7 @@ tsan-build:
> variables:
> IMAGE: ubuntu2004
> CONFIGURE_ARGS: --enable-tsan --cc=clang-10 --cxx=clang++-10 --disable-docs
> - --enable-fdt=system --enable-slirp=system
> + --enable-trace-backends=ust --enable-fdt=system --enable-slirp=system
> TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user
> MAKE_CHECK_ARGS: bench V=1
>
> @@ -706,6 +706,7 @@ build-coroutine-sigaltstack:
> variables:
> IMAGE: ubuntu2004
> CONFIGURE_ARGS: --with-coroutine=sigaltstack --disable-tcg
> + --enable-trace-backends=ftrace
Nit: different indentation from the previous CONFIGURE_ARGS
Regardless,
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> MAKE_CHECK_ARGS: check-unit
>
> # Most jobs test latest gcrypt or nettle builds
> @@ -743,31 +744,6 @@ crypto-only-gnutls:
> MAKE_CHECK_ARGS: check
>
>
> -# We don't need to exercise every backend with every front-end
> -build-trace-multi-user:
> - <<: *native_build_job_definition
> - needs:
> - job: amd64-ubuntu2004-container
> - variables:
> - IMAGE: ubuntu2004
> - CONFIGURE_ARGS: --enable-trace-backends=log,simple,syslog --disable-system
> -
> -build-trace-ftrace-system:
> - <<: *native_build_job_definition
> - needs:
> - job: amd64-ubuntu2004-container
> - variables:
> - IMAGE: ubuntu2004
> - CONFIGURE_ARGS: --enable-trace-backends=ftrace --target-list=x86_64-softmmu
> -
> -build-trace-ust-system:
> - <<: *native_build_job_definition
> - needs:
> - job: amd64-ubuntu2004-container
> - variables:
> - IMAGE: ubuntu2004
> - CONFIGURE_ARGS: --enable-trace-backends=ust --target-list=x86_64-softmmu
> -
> # Check our reduced build configurations
> build-without-default-devices:
> <<: *native_build_job_definition
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitlab-ci.yml: Merge the trace-backend testing into other jobs
2021-03-19 9:57 [PATCH] gitlab-ci.yml: Merge the trace-backend testing into other jobs Thomas Huth
2021-03-19 13:26 ` Wainer dos Santos Moschetta
@ 2021-03-19 13:56 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2021-03-19 13:56 UTC (permalink / raw)
To: Thomas Huth
Cc: Willian Rampazzo, Stefan Hajnoczi, qemu-devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé
Thomas Huth <thuth@redhat.com> writes:
> Our gitlab-ci got quite slow in the past weeks, due to the immense amount
> of jobs that we have, so we should try to reduce the number of jobs.
> There is no real good reason for having separate jobs just to test the
> trace backends, we can do this just fine in other jobs, too.
Queued to for-6.0/fixes-for-rc1, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-19 13:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 9:57 [PATCH] gitlab-ci.yml: Merge the trace-backend testing into other jobs Thomas Huth
2021-03-19 13:26 ` Wainer dos Santos Moschetta
2021-03-19 13:56 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.