From: Jia He <hejianet@gmail.com> To: Marc Zyngier <marc.zyngier@arm.com>, Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jia He <jia.he@hxt-semitech.com> Subject: Re: [PATCH] irqchip/gic-v3-its: cap lpi_id_bits to reduce memory footprint Date: Tue, 28 Aug 2018 20:08:04 +0800 [thread overview] Message-ID: <a28b854e-3bc9-0c10-2faf-63e4d44ec14b@gmail.com> (raw) In-Reply-To: <865zzuyijp.wl-marc.zyngier@arm.com> On 8/28/2018 4:58 PM, Marc Zyngier Wrote: > On Tue, 28 Aug 2018 05:53:26 +0100, > Jia He <hejianet@gmail.com> wrote: >> >> In commit fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs"), >> it removes the cap for lpi_id_bits. But it will cause more pointless >> memory footprint. >> >> There is a WARN_ON when my QDF2400 server boots up (pagesize is 4k) >> ============begin=============== > > [trimming not-so-useful trace] > >> ============end============ >> >> In its_alloc_lpi_tables, lpi_id_bits is 24 in QDF2400. Then >> its_allocate_prop_table will try to allocate 16M(order 12 if >> pagesize=4k). Thus it causes the WARN_ON. >> >> As said by Marc, >> Capping lpi_id_bits at 16 (which is what we had before) is plenty, >> will save a some memory, and gives some margin before we need to push >> it up again. >> >> This patch re-caps the lpi_id_bits. >> >> Fixes: fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs") >> Signed-off-by: Jia He <jia.he@hxt-semitech.com> >> Suggested-by: Marc Zyngier <marc.zyngier@arm.com> > > Thanks for doing this. Small problem with this patch: > > The email comes from hejianet@gmail.com, while the sign off is by > jia.he@hxt-semitech.com. Your email should start with a: > > From: Jia He <jia.he@hxt-semitech.com> > Thanks for the pointing. And sorry for that problem. --- Cheers, Jia > Other than that: > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> > > Thomas, would you mind picking this up so that it gets into the next > convenient -rc? > > Thanks, > > M. (/me goes back hiking...) > >
WARNING: multiple messages have this Message-ID (diff)
From: hejianet@gmail.com (Jia He) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] irqchip/gic-v3-its: cap lpi_id_bits to reduce memory footprint Date: Tue, 28 Aug 2018 20:08:04 +0800 [thread overview] Message-ID: <a28b854e-3bc9-0c10-2faf-63e4d44ec14b@gmail.com> (raw) In-Reply-To: <865zzuyijp.wl-marc.zyngier@arm.com> On 8/28/2018 4:58 PM, Marc Zyngier Wrote: > On Tue, 28 Aug 2018 05:53:26 +0100, > Jia He <hejianet@gmail.com> wrote: >> >> In commit fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs"), >> it removes the cap for lpi_id_bits. But it will cause more pointless >> memory footprint. >> >> There is a WARN_ON when my QDF2400 server boots up (pagesize is 4k) >> ============begin=============== > > [trimming not-so-useful trace] > >> ============end============ >> >> In its_alloc_lpi_tables, lpi_id_bits is 24 in QDF2400. Then >> its_allocate_prop_table will try to allocate 16M(order 12 if >> pagesize=4k). Thus it causes the WARN_ON. >> >> As said by Marc, >> Capping lpi_id_bits at 16 (which is what we had before) is plenty, >> will save a some memory, and gives some margin before we need to push >> it up again. >> >> This patch re-caps the lpi_id_bits. >> >> Fixes: fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs") >> Signed-off-by: Jia He <jia.he@hxt-semitech.com> >> Suggested-by: Marc Zyngier <marc.zyngier@arm.com> > > Thanks for doing this. Small problem with this patch: > > The email comes from hejianet at gmail.com, while the sign off is by > jia.he at hxt-semitech.com. Your email should start with a: > > From: Jia He <jia.he@hxt-semitech.com> > Thanks for the pointing. And sorry for that problem. --- Cheers, Jia > Other than that: > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> > > Thomas, would you mind picking this up so that it gets into the next > convenient -rc? > > Thanks, > > M. (/me goes back hiking...) > >
next prev parent reply other threads:[~2018-08-28 12:08 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-28 4:53 [PATCH] irqchip/gic-v3-its: cap lpi_id_bits to reduce memory footprint Jia He 2018-08-28 4:53 ` Jia He 2018-08-28 8:58 ` Marc Zyngier 2018-08-28 8:58 ` Marc Zyngier 2018-08-28 12:08 ` Jia He [this message] 2018-08-28 12:08 ` Jia He 2018-08-31 15:38 ` Olof Johansson 2018-08-31 15:38 ` Olof Johansson 2018-09-06 18:36 ` [tip:irq/urgent] irqchip/gic-v3-its: Cap " tip-bot for Jia He
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a28b854e-3bc9-0c10-2faf-63e4d44ec14b@gmail.com \ --to=hejianet@gmail.com \ --cc=jason@lakedaemon.net \ --cc=jia.he@hxt-semitech.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.