* [PATCH net] mpls: load mpls_gso after mpls_iptunnel
@ 2020-10-20 11:02 Alexander Ovechkin
2020-10-21 0:16 ` David Ahern
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Ovechkin @ 2020-10-20 11:02 UTC (permalink / raw)
To: netdev
mpls_iptunnel is used only for mpls encapsuation, and if encaplusated
packet is larger than MTU we need mpls_gso for segmentation.
---
net/mpls/mpls_iptunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c
index 2def85718d94..ef59e25dc482 100644
--- a/net/mpls/mpls_iptunnel.c
+++ b/net/mpls/mpls_iptunnel.c
@@ -300,5 +300,6 @@ static void __exit mpls_iptunnel_exit(void)
module_exit(mpls_iptunnel_exit);
MODULE_ALIAS_RTNL_LWT(MPLS);
+MODULE_SOFTDEP("post: mpls_gso");
MODULE_DESCRIPTION("MultiProtocol Label Switching IP Tunnels");
MODULE_LICENSE("GPL v2");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] mpls: load mpls_gso after mpls_iptunnel
2020-10-20 11:02 [PATCH net] mpls: load mpls_gso after mpls_iptunnel Alexander Ovechkin
@ 2020-10-21 0:16 ` David Ahern
0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2020-10-21 0:16 UTC (permalink / raw)
To: Alexander Ovechkin, netdev
On 10/20/20 5:02 AM, Alexander Ovechkin wrote:
> mpls_iptunnel is used only for mpls encapsuation, and if encaplusated
> packet is larger than MTU we need mpls_gso for segmentation.
Familiar with that problem
> ---
> net/mpls/mpls_iptunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c
> index 2def85718d94..ef59e25dc482 100644
> --- a/net/mpls/mpls_iptunnel.c
> +++ b/net/mpls/mpls_iptunnel.c
> @@ -300,5 +300,6 @@ static void __exit mpls_iptunnel_exit(void)
> module_exit(mpls_iptunnel_exit);
>
> MODULE_ALIAS_RTNL_LWT(MPLS);
> +MODULE_SOFTDEP("post: mpls_gso");
> MODULE_DESCRIPTION("MultiProtocol Label Switching IP Tunnels");
> MODULE_LICENSE("GPL v2");
>
interesting solution. did not know about the SOFTDEP.
LGTM
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-21 0:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 11:02 [PATCH net] mpls: load mpls_gso after mpls_iptunnel Alexander Ovechkin
2020-10-21 0:16 ` David Ahern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.