* [PATCH] DTS: Linksys Board: Add default trigger for sata led
@ 2017-02-17 20:42 ` Ansuel Smith
0 siblings, 0 replies; 6+ messages in thread
From: Ansuel Smith @ 2017-02-17 20:42 UTC (permalink / raw)
To: jason
Cc: andrew, gregory.clement, sebastian.hesselbarth, linux-arm-kernel,
linux-kernel, Ansuel Smith
In others board we have the sata led set to funcion with the sata led trigger by default.
This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
index f3cee91..a1b6e68 100644
--- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
@@ -109,6 +109,7 @@
sata {
label = "caiman:white:sata";
+ linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
index 1110718..a1a75af 100644
--- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
@@ -109,6 +109,7 @@
sata {
label = "cobra:white:sata";
+ linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 83ac884..dcd73ab 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -156,6 +156,7 @@
esata@4 {
label = "mamba:white:esata";
reg = <0x4>;
+ linux,default-trigger = "disk-activity";
};
usb2@5 {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] DTS: Linksys Board: Add default trigger for sata led
@ 2017-02-17 20:42 ` Ansuel Smith
0 siblings, 0 replies; 6+ messages in thread
From: Ansuel Smith @ 2017-02-17 20:42 UTC (permalink / raw)
To: linux-arm-kernel
In others board we have the sata led set to funcion with the sata led trigger by default.
This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
index f3cee91..a1b6e68 100644
--- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
@@ -109,6 +109,7 @@
sata {
label = "caiman:white:sata";
+ linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
index 1110718..a1a75af 100644
--- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
@@ -109,6 +109,7 @@
sata {
label = "cobra:white:sata";
+ linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 83ac884..dcd73ab 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -156,6 +156,7 @@
esata at 4 {
label = "mamba:white:esata";
reg = <0x4>;
+ linux,default-trigger = "disk-activity";
};
usb2 at 5 {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led
2017-02-17 20:42 ` Ansuel Smith
@ 2017-02-18 14:12 ` Jason Cooper
-1 siblings, 0 replies; 6+ messages in thread
From: Jason Cooper @ 2017-02-18 14:12 UTC (permalink / raw)
To: Ansuel Smith
Cc: andrew, gregory.clement, sebastian.hesselbarth, linux-arm-kernel,
linux-kernel
Hi Ansuel,
On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
> In others board we have the sata led set to funcion with the sata led trigger by default.
> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Please line wrap the commit message. Other than that,
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
> ---
> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> index f3cee91..a1b6e68 100644
> --- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> +++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> @@ -109,6 +109,7 @@
>
> sata {
> label = "caiman:white:sata";
> + linux,default-trigger = "disk-activity";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> index 1110718..a1a75af 100644
> --- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> +++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> @@ -109,6 +109,7 @@
>
> sata {
> label = "cobra:white:sata";
> + linux,default-trigger = "disk-activity";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> index 83ac884..dcd73ab 100644
> --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> @@ -156,6 +156,7 @@
> esata@4 {
> label = "mamba:white:esata";
> reg = <0x4>;
> + linux,default-trigger = "disk-activity";
> };
>
> usb2@5 {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] DTS: Linksys Board: Add default trigger for sata led
@ 2017-02-18 14:12 ` Jason Cooper
0 siblings, 0 replies; 6+ messages in thread
From: Jason Cooper @ 2017-02-18 14:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ansuel,
On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
> In others board we have the sata led set to funcion with the sata led trigger by default.
> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Please line wrap the commit message. Other than that,
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
> ---
> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> index f3cee91..a1b6e68 100644
> --- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> +++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> @@ -109,6 +109,7 @@
>
> sata {
> label = "caiman:white:sata";
> + linux,default-trigger = "disk-activity";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> index 1110718..a1a75af 100644
> --- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> +++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> @@ -109,6 +109,7 @@
>
> sata {
> label = "cobra:white:sata";
> + linux,default-trigger = "disk-activity";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> index 83ac884..dcd73ab 100644
> --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> @@ -156,6 +156,7 @@
> esata at 4 {
> label = "mamba:white:esata";
> reg = <0x4>;
> + linux,default-trigger = "disk-activity";
> };
>
> usb2 at 5 {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led
2017-02-18 14:12 ` Jason Cooper
@ 2017-02-19 0:01 ` Andreas Färber
-1 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2017-02-19 0:01 UTC (permalink / raw)
To: Jason Cooper, Ansuel Smith
Cc: gregory.clement, andrew, linux-kernel, linux-arm-kernel,
sebastian.hesselbarth
Hi,
Am 18.02.2017 um 15:12 schrieb Jason Cooper:
> On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
>> In others board we have the sata led set to funcion with the sata led trigger by default.
>> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
>
> Please line wrap the commit message.
The subject could also use some love, like mentioning "ARM:" and
"armada" and dropping "Board". Compare git log --oneline.
Regards,
Andreas
> Other than that,
>
>>
>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>
> Acked-by: Jason Cooper <jason@lakedaemon.net>
>
> thx,
>
> Jason.
>
>> ---
>> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
>> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
>> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
>> 3 files changed, 3 insertions(+)
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] DTS: Linksys Board: Add default trigger for sata led
@ 2017-02-19 0:01 ` Andreas Färber
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2017-02-19 0:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Am 18.02.2017 um 15:12 schrieb Jason Cooper:
> On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
>> In others board we have the sata led set to funcion with the sata led trigger by default.
>> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
>
> Please line wrap the commit message.
The subject could also use some love, like mentioning "ARM:" and
"armada" and dropping "Board". Compare git log --oneline.
Regards,
Andreas
> Other than that,
>
>>
>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>
> Acked-by: Jason Cooper <jason@lakedaemon.net>
>
> thx,
>
> Jason.
>
>> ---
>> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
>> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
>> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
>> 3 files changed, 3 insertions(+)
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-19 0:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-17 20:42 [PATCH] DTS: Linksys Board: Add default trigger for sata led Ansuel Smith
2017-02-17 20:42 ` Ansuel Smith
2017-02-18 14:12 ` Jason Cooper
2017-02-18 14:12 ` Jason Cooper
2017-02-19 0:01 ` Andreas Färber
2017-02-19 0:01 ` Andreas Färber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.