From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
ALSA <alsa-devel@alsa-project.org>, Mark <broonie@kernel.org>,
Takashi <tiwai@suse.de>,
patches.audio@intel.com, alan@linux.intel.com,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Sagar Dharia <sdharia@codeaurora.org>,
srinivas.kandagatla@linaro.org, plai@codeaurora.org,
Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support
Date: Fri, 1 Dec 2017 18:02:24 -0600 [thread overview]
Message-ID: <a3167578-df2b-e871-cd5e-94adcc549a4e@linux.intel.com> (raw)
In-Reply-To: <1512122177-2889-13-git-send-email-vinod.koul@intel.com>
> struct sdw_cdns {
> struct device *dev;
> struct sdw_bus bus;
> unsigned int instance;
>
> + u32 response_buf[0x80];
last nit-pick: use a #define for the size.
Also are you sure about the value? I vaguely recall that the FIFO was
32-deep, you are confusing bytes and words here?
> + struct completion tx_complete;
> + struct sdw_defer *defer;
> +
> void __iomem *registers;
>
> bool link_up;
> + unsigned int msg_count;
> };
>
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: ALSA <alsa-devel@alsa-project.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Sudheer Papothi <spapothi@codeaurora.org>,
Takashi <tiwai@suse.de>,
plai@codeaurora.org, LKML <linux-kernel@vger.kernel.org>,
patches.audio@intel.com, Mark <broonie@kernel.org>,
srinivas.kandagatla@linaro.org,
Sagar Dharia <sdharia@codeaurora.org>,
alan@linux.intel.com
Subject: Re: [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support
Date: Fri, 1 Dec 2017 18:02:24 -0600 [thread overview]
Message-ID: <a3167578-df2b-e871-cd5e-94adcc549a4e@linux.intel.com> (raw)
In-Reply-To: <1512122177-2889-13-git-send-email-vinod.koul@intel.com>
> struct sdw_cdns {
> struct device *dev;
> struct sdw_bus bus;
> unsigned int instance;
>
> + u32 response_buf[0x80];
last nit-pick: use a #define for the size.
Also are you sure about the value? I vaguely recall that the FIFO was
32-deep, you are confusing bytes and words here?
> + struct completion tx_complete;
> + struct sdw_defer *defer;
> +
> void __iomem *registers;
>
> bool link_up;
> + unsigned int msg_count;
> };
>
next prev parent reply other threads:[~2017-12-02 0:02 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 9:56 [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem Vinod Koul
2017-12-01 9:56 ` [PATCH v4 01/15] Documentation: Add SoundWire summary Vinod Koul
2017-12-01 9:56 ` [PATCH v4 02/15] soundwire: Add SoundWire bus type Vinod Koul
2017-12-01 9:56 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 03/15] soundwire: Add Master registration Vinod Koul
2017-12-01 22:10 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-03 16:41 ` Vinod Koul
2017-12-04 2:44 ` Pierre-Louis Bossart
2017-12-04 2:59 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 04/15] soundwire: Add MIPI DisCo property helpers Vinod Koul
2017-12-01 9:56 ` Vinod Koul
2017-12-01 22:49 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-03 16:52 ` Vinod Koul
2017-12-03 16:52 ` Vinod Koul
2017-12-04 2:50 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-04 2:50 ` Pierre-Louis Bossart
2017-12-01 9:56 ` [PATCH v4 05/15] soundwire: Add SoundWire MIPI defined registers Vinod Koul
2017-12-01 9:56 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 06/15] soundwire: Add IO transfer Vinod Koul
2017-12-01 23:27 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-03 17:04 ` Vinod Koul
2017-12-03 17:04 ` Vinod Koul
2017-12-04 3:01 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-05 6:31 ` Vinod Koul
2017-12-05 13:43 ` Pierre-Louis Bossart
2017-12-05 14:48 ` Pierre-Louis Bossart
2017-12-05 14:48 ` Pierre-Louis Bossart
2017-12-06 5:58 ` [alsa-devel] " Vinod Koul
2017-12-06 13:32 ` Pierre-Louis Bossart
2017-12-06 13:32 ` Pierre-Louis Bossart
2017-12-06 14:44 ` [alsa-devel] " Vinod Koul
2017-12-01 9:56 ` [PATCH v4 07/15] regmap: Add SoundWire bus support Vinod Koul
2017-12-01 9:56 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 08/15] soundwire: Add Slave status handling helpers Vinod Koul
2017-12-01 23:36 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-03 17:08 ` Vinod Koul
2017-12-04 3:07 ` Pierre-Louis Bossart
2017-12-04 3:07 ` Pierre-Louis Bossart
2017-12-04 3:13 ` [alsa-devel] " Vinod Koul
2017-12-04 3:13 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 09/15] soundwire: Add slave status handling Vinod Koul
2017-12-01 23:52 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-03 17:11 ` Vinod Koul
2017-12-03 17:11 ` Vinod Koul
2017-12-04 3:11 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-04 3:21 ` Vinod Koul
2017-12-04 3:21 ` Vinod Koul
2017-12-04 3:52 ` [alsa-devel] " Pierre-Louis Bossart
2017-12-04 3:52 ` Pierre-Louis Bossart
2017-12-06 9:44 ` [alsa-devel] " Vinod Koul
2017-12-06 9:44 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 10/15] soundwire: Add sysfs for SoundWire DisCo properties Vinod Koul
2017-12-01 9:56 ` [PATCH v4 11/15] soundwire: cdns: Add cadence library Vinod Koul
2017-12-01 9:56 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support Vinod Koul
2017-12-02 0:02 ` Pierre-Louis Bossart [this message]
2017-12-02 0:02 ` Pierre-Louis Bossart
2017-12-03 17:10 ` [alsa-devel] " Vinod Koul
2017-12-03 17:10 ` Vinod Koul
2017-12-01 9:56 ` [PATCH v4 13/15] soundwire: intel: Add Intel Master driver Vinod Koul
2017-12-01 9:56 ` [PATCH v4 14/15] soundwire: intel: Add Intel init module Vinod Koul
2017-12-01 9:56 ` [PATCH v4 15/15] MAINTAINERS: Add SoundWire entry Vinod Koul
2017-12-02 0:24 ` [alsa-devel] [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem Pierre-Louis Bossart
2017-12-02 0:24 ` Pierre-Louis Bossart
2017-12-03 17:12 ` [alsa-devel] " Vinod Koul
2017-12-03 17:12 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3167578-df2b-e871-cd5e-94adcc549a4e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches.audio@intel.com \
--cc=plai@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.