[PATCH] drm/omap: use true,false for bool variable

[PATCH] drm/omap: use true,false for bool variable

[Zheng Bin]

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:681:1-15: WARNING: Assignment of 0/1 to bool variable
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:732:1-15: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
index 564e3e1..3ec6a55 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
@@ -678,7 +678,7 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
 	if (r)
 		goto err;

-	ddata->enabled = 1;
+	ddata->enabled = true;

 	if (!ddata->intro_printed) {
 		dev_info(&ddata->pdev->dev, "panel revision %02x.%02x.%02x\n",
@@ -729,7 +729,7 @@ static void dsicm_power_off(struct panel_drv_data *ddata)
 	if (ddata->vpnl)
 		regulator_disable(ddata->vpnl);

-	ddata->enabled = 0;
+	ddata->enabled = false;
 }

 static int dsicm_panel_reset(struct panel_drv_data *ddata)
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/omap: use true,false for bool variable

[Tomi Valkeinen]

On 23/01/2020 09:05, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:681:1-15: WARNING: Assignment of 0/1 to bool variable
> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:732:1-15: WARNING: Assignment of 0/1 to bool variable
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
>   drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> index 564e3e1..3ec6a55 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> @@ -678,7 +678,7 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
>   	if (r)
>   		goto err;
> 
> -	ddata->enabled = 1;
> +	ddata->enabled = true;
> 
>   	if (!ddata->intro_printed) {
>   		dev_info(&ddata->pdev->dev, "panel revision %02x.%02x.%02x\n",
> @@ -729,7 +729,7 @@ static void dsicm_power_off(struct panel_drv_data *ddata)
>   	if (ddata->vpnl)
>   		regulator_disable(ddata->vpnl);
> 
> -	ddata->enabled = 0;
> +	ddata->enabled = false;
>   }
> 
>   static int dsicm_panel_reset(struct panel_drv_data *ddata)
> --
> 2.7.4
> 

Thanks, applied.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel