All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Philippe CORNU <philippe.cornu@st.com>,
	Yannick FERTRE <yannick.fertre@st.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Vincent ABRIOU <vincent.abriou@st.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>
Subject: Re: [PATCH] drm/stm: repair runtime power management
Date: Thu, 2 Jul 2020 12:53:22 +0200	[thread overview]
Message-ID: <a35217e6-21ce-6d36-c1bb-9e057ae35be1@denx.de> (raw)
In-Reply-To: <3121f339-c513-f75d-569e-81c5c0f3cd1a@st.com>

On 7/2/20 12:07 PM, Philippe CORNU wrote:

Hi,

[...]

>>>> Thank for your patch. Pm_runtime_put_sync is also done into function ltdc_crtc_mode_fixup.
>>>> To avoid several call of Pm_runtime_put_sync, it could be better to check pm_runtime activity:
>>>>
>>>> +	int ret;
>>>>    
>>>>    	DRM_DEBUG_DRIVER("\n");
>>>>    
>>>> +	if (!pm_runtime_active(ddev->dev)) {
>>>> +		ret = pm_runtime_get_sync(ddev->dev);
>>>> +		if (ret) {
>>>> +			DRM_ERROR("Failed to enable crtc, cannot get sync\n");
>>>> +			return;
>>>> +		}
>>>> +	}
>>>> +
>>>
>>> Where should this go ? And wouldn't that only hide nastier PM imbalance
>>> issues ?
>> Hi Marek,
>> I tested the patch &  it generate an error when I try wake up / sleep
>> the board STM32MP1 DK2 with weston application.
>> It need an additional patch
>> drm-stm-ltdc-remove-call-of-pm-runtime-functions.
>>
>> Thanks for the patch.
>>
>> Tested-by: Yannick Fertre <yannick.fertre@st.com>
>>
> 
> Hi Marek,
> before merging the 2 patches, I would like to be sure that Yannick's 
> patch does not "break" your use case (Qt I think)?
> May I ask you please to give it a try?
> Note: If you think there is no need to do extra checks, simply tell me 
> of course
It's fine, thanks !

-- 
Best regards,
Marek Vasut

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Philippe CORNU <philippe.cornu@st.com>,
	Yannick FERTRE <yannick.fertre@st.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Vincent ABRIOU <vincent.abriou@st.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>
Subject: Re: [PATCH] drm/stm: repair runtime power management
Date: Thu, 2 Jul 2020 12:53:22 +0200	[thread overview]
Message-ID: <a35217e6-21ce-6d36-c1bb-9e057ae35be1@denx.de> (raw)
In-Reply-To: <3121f339-c513-f75d-569e-81c5c0f3cd1a@st.com>

On 7/2/20 12:07 PM, Philippe CORNU wrote:

Hi,

[...]

>>>> Thank for your patch. Pm_runtime_put_sync is also done into function ltdc_crtc_mode_fixup.
>>>> To avoid several call of Pm_runtime_put_sync, it could be better to check pm_runtime activity:
>>>>
>>>> +	int ret;
>>>>    
>>>>    	DRM_DEBUG_DRIVER("\n");
>>>>    
>>>> +	if (!pm_runtime_active(ddev->dev)) {
>>>> +		ret = pm_runtime_get_sync(ddev->dev);
>>>> +		if (ret) {
>>>> +			DRM_ERROR("Failed to enable crtc, cannot get sync\n");
>>>> +			return;
>>>> +		}
>>>> +	}
>>>> +
>>>
>>> Where should this go ? And wouldn't that only hide nastier PM imbalance
>>> issues ?
>> Hi Marek,
>> I tested the patch &  it generate an error when I try wake up / sleep
>> the board STM32MP1 DK2 with weston application.
>> It need an additional patch
>> drm-stm-ltdc-remove-call-of-pm-runtime-functions.
>>
>> Thanks for the patch.
>>
>> Tested-by: Yannick Fertre <yannick.fertre@st.com>
>>
> 
> Hi Marek,
> before merging the 2 patches, I would like to be sure that Yannick's 
> patch does not "break" your use case (Qt I think)?
> May I ask you please to give it a try?
> Note: If you think there is no need to do extra checks, simply tell me 
> of course
It's fine, thanks !

-- 
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-07-02 10:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29 22:16 [PATCH] drm/stm: repair runtime power management Marek Vasut
2020-02-29 22:16 ` Marek Vasut
2020-03-09 10:35 ` Yannick FERTRE
2020-03-09 10:35   ` Yannick FERTRE
2020-03-09 11:57   ` Marek Vasut
2020-03-09 11:57     ` Marek Vasut
2020-07-01 12:14     ` Yannick FERTRE
2020-07-01 12:14       ` Yannick FERTRE
2020-07-02 10:07       ` Philippe CORNU
2020-07-02 10:07         ` Philippe CORNU
2020-07-02 10:53         ` Marek Vasut [this message]
2020-07-02 10:53           ` Marek Vasut
2020-07-02 12:31 ` Philippe CORNU
2020-07-02 12:31   ` Philippe CORNU
2020-07-08  9:49   ` Benjamin Gaignard
2020-07-08  9:49     ` Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a35217e6-21ce-6d36-c1bb-9e057ae35be1@denx.de \
    --to=marex@denx.de \
    --cc=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=philippe.cornu@st.com \
    --cc=vincent.abriou@st.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.