From: Weiwei Li <liweiwei@iscas.ac.cn> To: Alistair Francis <alistair23@gmail.com> Cc: lazyparser@gmail.com, "open list:RISC-V" <qemu-riscv@nongnu.org>, lustrew@foxmail.com, wangjunqiang <wangjunqiang@iscas.ac.cn>, Bin Meng <bin.meng@windriver.com>, Richard Henderson <richard.henderson@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Palmer Dabbelt <palmer@dabbelt.com>, luruibo2000@163.com, Alistair Francis <alistair.francis@wdc.com> Subject: Re: [PATCH v4 0/7] support subsets of scalar crypto extension Date: Tue, 18 Jan 2022 16:24:17 +0800 [thread overview] Message-ID: <a39932a0-ab57-3a13-a75f-b3d0bcffd51c@iscas.ac.cn> (raw) In-Reply-To: <CAKmqyKOxD33qVpT1k3-BU1MRSZS3+vN-f7z-kaGQ0RhXWKhBqQ@mail.gmail.com> 在 2022/1/18 下午12:41, Alistair Francis 写道: > On Tue, Jan 11, 2022 at 1:54 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote: >> This patchset implements RISC-V scalar crypto extension v1.0.0 version instructions. >> Partial instructions are reused from B-extension. >> >> Specification: >> https://github.com/riscv/riscv-crypto >> >> The port is available here: >> https://github.com/plctlab/plct-qemu/tree/plct-k-upstream-v4 >> >> To test rvk implementation, specify cpu argument with 'zks=true,zkn=true' >> or >> "zbkb=true,zbkc=true,zbkx=true,zknd=true,zkne=true,zknh=true,zksed=true,zksh=true,zkr=true" >> to enable K-extension support. This implementation can pass the ACT tests >> for K with our extended act support for qemu (available at >> https://github.com/plctlab/plct-qemu/tree/plct-k-upstream-v4-with-act) >> >> v4: >> * drop "x-" in exposed properties >> * delete unrelated changes >> >> v3: >> * add extension check for SEED csr access >> >> v2: >> * optimize implementation for brev8, xperm, zip, unzip >> * use aes related sbox array from crypto/aes.h >> * move sm4_sbox to crypto/sm4.c, and share it with target/arm >> >> Weiwei Li (7): >> target/riscv: rvk: add cfg properties for zbk* and zk* >> target/riscv: rvk: add implementation of instructions for Zbk* >> crypto include/crypto target/arm: move sm4_sbox to crypto >> target/riscv: rvk: add implementation of instructions for Zk* >> target/riscv: rvk: add CSR support for Zkr >> disas/riscv.c: rvk: add disas support for Zbk* and Zk* instructions >> target/riscv: rvk: expose zbk* and zk* properties > Thanks for the patches! > > Overall this looks good, just some small comments on the individual patches. > > For the next version do you mind splitting the patches up a little bit > more? That will make it easier and faster to review > > Alistair > Thanks for your comments. Sorry for the big patches. I'll divide them. Regards, Weiwei Li >> crypto/meson.build | 1 + >> crypto/sm4.c | 49 +++ >> disas/riscv.c | 170 +++++++++ >> include/crypto/sm4.h | 6 + >> target/arm/crypto_helper.c | 36 +- >> target/riscv/bitmanip_helper.c | 74 ++++ >> target/riscv/cpu.c | 37 ++ >> target/riscv/cpu.h | 13 + >> target/riscv/cpu_bits.h | 9 + >> target/riscv/crypto_helper.c | 446 ++++++++++++++++++++++ >> target/riscv/csr.c | 74 ++++ >> target/riscv/helper.h | 42 +++ >> target/riscv/insn32.decode | 94 ++++- >> target/riscv/insn_trans/trans_rvb.c.inc | 127 ++++++- >> target/riscv/insn_trans/trans_rvk.c.inc | 467 ++++++++++++++++++++++++ >> target/riscv/meson.build | 3 +- >> target/riscv/pmp.h | 8 +- >> target/riscv/translate.c | 8 + >> 18 files changed, 1594 insertions(+), 70 deletions(-) >> create mode 100644 crypto/sm4.c >> create mode 100644 include/crypto/sm4.h >> create mode 100644 target/riscv/crypto_helper.c >> create mode 100644 target/riscv/insn_trans/trans_rvk.c.inc >> >> -- >> 2.17.1 >> >>
WARNING: multiple messages have this Message-ID (diff)
From: Weiwei Li <liweiwei@iscas.ac.cn> To: Alistair Francis <alistair23@gmail.com> Cc: Richard Henderson <richard.henderson@linaro.org>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Bin Meng <bin.meng@windriver.com>, "open list:RISC-V" <qemu-riscv@nongnu.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, wangjunqiang <wangjunqiang@iscas.ac.cn>, lazyparser@gmail.com, luruibo2000@163.com, lustrew@foxmail.com Subject: Re: [PATCH v4 0/7] support subsets of scalar crypto extension Date: Tue, 18 Jan 2022 16:24:17 +0800 [thread overview] Message-ID: <a39932a0-ab57-3a13-a75f-b3d0bcffd51c@iscas.ac.cn> (raw) In-Reply-To: <CAKmqyKOxD33qVpT1k3-BU1MRSZS3+vN-f7z-kaGQ0RhXWKhBqQ@mail.gmail.com> 在 2022/1/18 下午12:41, Alistair Francis 写道: > On Tue, Jan 11, 2022 at 1:54 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote: >> This patchset implements RISC-V scalar crypto extension v1.0.0 version instructions. >> Partial instructions are reused from B-extension. >> >> Specification: >> https://github.com/riscv/riscv-crypto >> >> The port is available here: >> https://github.com/plctlab/plct-qemu/tree/plct-k-upstream-v4 >> >> To test rvk implementation, specify cpu argument with 'zks=true,zkn=true' >> or >> "zbkb=true,zbkc=true,zbkx=true,zknd=true,zkne=true,zknh=true,zksed=true,zksh=true,zkr=true" >> to enable K-extension support. This implementation can pass the ACT tests >> for K with our extended act support for qemu (available at >> https://github.com/plctlab/plct-qemu/tree/plct-k-upstream-v4-with-act) >> >> v4: >> * drop "x-" in exposed properties >> * delete unrelated changes >> >> v3: >> * add extension check for SEED csr access >> >> v2: >> * optimize implementation for brev8, xperm, zip, unzip >> * use aes related sbox array from crypto/aes.h >> * move sm4_sbox to crypto/sm4.c, and share it with target/arm >> >> Weiwei Li (7): >> target/riscv: rvk: add cfg properties for zbk* and zk* >> target/riscv: rvk: add implementation of instructions for Zbk* >> crypto include/crypto target/arm: move sm4_sbox to crypto >> target/riscv: rvk: add implementation of instructions for Zk* >> target/riscv: rvk: add CSR support for Zkr >> disas/riscv.c: rvk: add disas support for Zbk* and Zk* instructions >> target/riscv: rvk: expose zbk* and zk* properties > Thanks for the patches! > > Overall this looks good, just some small comments on the individual patches. > > For the next version do you mind splitting the patches up a little bit > more? That will make it easier and faster to review > > Alistair > Thanks for your comments. Sorry for the big patches. I'll divide them. Regards, Weiwei Li >> crypto/meson.build | 1 + >> crypto/sm4.c | 49 +++ >> disas/riscv.c | 170 +++++++++ >> include/crypto/sm4.h | 6 + >> target/arm/crypto_helper.c | 36 +- >> target/riscv/bitmanip_helper.c | 74 ++++ >> target/riscv/cpu.c | 37 ++ >> target/riscv/cpu.h | 13 + >> target/riscv/cpu_bits.h | 9 + >> target/riscv/crypto_helper.c | 446 ++++++++++++++++++++++ >> target/riscv/csr.c | 74 ++++ >> target/riscv/helper.h | 42 +++ >> target/riscv/insn32.decode | 94 ++++- >> target/riscv/insn_trans/trans_rvb.c.inc | 127 ++++++- >> target/riscv/insn_trans/trans_rvk.c.inc | 467 ++++++++++++++++++++++++ >> target/riscv/meson.build | 3 +- >> target/riscv/pmp.h | 8 +- >> target/riscv/translate.c | 8 + >> 18 files changed, 1594 insertions(+), 70 deletions(-) >> create mode 100644 crypto/sm4.c >> create mode 100644 include/crypto/sm4.h >> create mode 100644 target/riscv/crypto_helper.c >> create mode 100644 target/riscv/insn_trans/trans_rvk.c.inc >> >> -- >> 2.17.1 >> >>
next prev parent reply other threads:[~2022-01-18 8:30 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-11 3:51 [PATCH v4 0/7] support subsets of scalar crypto extension Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-11 3:51 ` [PATCH v4 1/7] target/riscv: rvk: add cfg properties for zbk* and zk* Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-11 3:51 ` [PATCH v4 2/7] target/riscv: rvk: add implementation of instructions for Zbk* Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-18 4:40 ` Alistair Francis 2022-01-18 4:40 ` Alistair Francis 2022-01-18 8:21 ` Weiwei Li 2022-01-18 8:21 ` Weiwei Li 2022-01-11 3:51 ` [PATCH v4 3/7] crypto include/crypto target/arm: move sm4_sbox to crypto Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-17 23:28 ` Alistair Francis 2022-01-17 23:28 ` Alistair Francis 2022-01-18 1:09 ` Weiwei Li 2022-01-18 1:09 ` Weiwei Li 2022-01-11 3:51 ` [PATCH v4 4/7] target/riscv: rvk: add implementation of instructions for Zk* Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-18 4:21 ` Alistair Francis 2022-01-18 4:21 ` Alistair Francis 2022-01-18 8:08 ` Weiwei Li 2022-01-18 8:08 ` Weiwei Li 2022-01-11 3:51 ` [PATCH v4 5/7] target/riscv: rvk: add CSR support for Zkr Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-18 4:36 ` Alistair Francis 2022-01-18 4:36 ` Alistair Francis 2022-01-18 8:14 ` Weiwei Li 2022-01-18 8:14 ` Weiwei Li 2022-01-11 3:51 ` [PATCH v4 6/7] disas/riscv.c: rvk: add disas support for Zbk* and Zk* instructions Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-11 3:51 ` [PATCH v4 7/7] target/riscv: rvk: expose zbk* and zk* properties Weiwei Li 2022-01-11 3:51 ` Weiwei Li 2022-01-18 4:23 ` Alistair Francis 2022-01-18 4:23 ` Alistair Francis 2022-01-18 8:09 ` Weiwei Li 2022-01-18 8:09 ` Weiwei Li 2022-01-18 4:41 ` [PATCH v4 0/7] support subsets of scalar crypto extension Alistair Francis 2022-01-18 4:41 ` Alistair Francis 2022-01-18 8:24 ` Weiwei Li [this message] 2022-01-18 8:24 ` Weiwei Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a39932a0-ab57-3a13-a75f-b3d0bcffd51c@iscas.ac.cn \ --to=liweiwei@iscas.ac.cn \ --cc=alistair.francis@wdc.com \ --cc=alistair23@gmail.com \ --cc=bin.meng@windriver.com \ --cc=lazyparser@gmail.com \ --cc=luruibo2000@163.com \ --cc=lustrew@foxmail.com \ --cc=palmer@dabbelt.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=wangjunqiang@iscas.ac.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.