[Weekly meetings] MoM - 5th of August 2021

[Weekly meetings] MoM - 5th of August 2021

[Matthieu Baerts]

Hello everyone,

Today, we had our 159th meeting with Mat and Ossama (Intel), Florian and
Paolo (RedHat), Geliang (Xiaomi) and myself (Tessares).


Thanks again for this new good meeting!

Here are the minutes of the meeting:



Accepted patches:
    - The list of accepted patches can be seen on PatchWork:
      https://patchwork.kernel.org/project/mptcp/list/?state=3


    netdev (if mptcp ML is in cc) (by: Yajun Deng):

12416657  [net] mptcp: drop unused rcu member in mptcp_pm_addr_entry


    our repo (by: Geliang Tang, Matthieu Baerts):

12418007  [mptcp-next] Squash to "mptcp: remote addresses fullmesh"

12417989  [mptcp-next] Squash to "selftests: mptcp: add fullmesh testcases

12408461  [v4,mptcp-next] Squash to "mptcp: drop flags and ifindex
arguments"

12408121  [v7,mptcp-next,5/5] selftests: mptcp: add MP_FAIL mibs check
12408119  [v7,mptcp-next,4/5] mptcp: add the mibs for MP_FAIL
12408117  [v7,mptcp-next,3/5] mptcp: send out MP_FAIL when data checksum
fails
12408115  [v7,mptcp-next,2/5] mptcp: MP_FAIL suboption receiving
12408113  [v7,mptcp-next,1/5] mptcp: MP_FAIL suboption sending

12407893  [v7,mptcp-next,6/6] selftests: mptcp: delete uncontinuous
removing ids
12407891  [v7,mptcp-next,5/6] selftests: mptcp: add fullmesh testcases
12407889  [v7,mptcp-next,4/6] selftests: mptcp: set and print the
fullmesh flag
12407887  [v7,mptcp-next,3/6] mptcp: local addresses fullmesh
12407885  [v7,mptcp-next,2/6] mptcp: remote addresses fullmesh
12407883  [v7,mptcp-next,1/6] mptcp: drop flags and ifindex arguments



Pending patches:
    - The list of pending patches can be seen on PatchWork:
      https://patchwork.kernel.org/project/mptcp/list/?state=*


    netdev (if mptcp ML is in cc) (by: Mat Martineau):

12417747  [net-next,v2] net: Modify sock_set_keepalive() for more scenarios


    our repo (by: Florian Westphal, Jiapeng Chong, Matthieu Baerts,
Paolo Abeni):

12279739: RFC: [RFC,3/4] mptcp: move the whole rx path under msk socket
lock protection:
    - WIP

12282219: RFC: [RESEND,RFC,2/4] tcp: move selected mptcp helpers to
tcp.h/mptcp.h
12282221: RFC: [RESEND,RFC,4/4] tcp: parse tcp options contained in
reset packets:
    - WIP

12282223: RFC: [RESEND,RFC,mptpcp-next] mptcp: add ooo prune support:
    - WIP

12282225: RFC: [RESEND,1/5] tcp: make two mptcp helpers available to tcp
stack
12282227: RFC: [RESEND,5/5] mptcp: send fastclose if userspace closes
socket with unread data:
    - WIP

12321111: Changes Requested: mptcp: Remove redundant assignment to
remaining:
    - TODO

12394261: RFC: [RFC] mptcp: add MPTCP_INFO getsockopt:
    - Discussions continued on the ML
    - Florian almost restarted from scratch
    - Added tests cases, more coverage
    - Will send a version later to have more discussions.



Issues on Github:
    https://github.com/multipath-tcp/mptcp_net-next/issues/

    Recently opened (latest from last week: 218)

  223  [syzkaller] Memory leak in mptcp_nl_cmd_add_addr:
      - there is a reproducer, seems easy to repro, maybe due to recent
changes
      - Geliang will look at that
      - TODO: assign Geliang on it → Done

  222  Netlink event API: add SUBFLOW_CREATED event [enhancement]:
      - linked to the discussion from last week: the userspace needs an
event when the subflow is created to be able to interact with it (get
the final 5-tuple) if it is not established.

  221  selftests: join: "backup flow used, multi links fail" is unstable
[bug] [selftests]:
      - We miss additional MP_JOIN
      - e.g. it should create 2 additional SF but only created one
      - maybe related to the fact we now have all ADD_ADDR in a
dedicated TCP (pure) ACK
      - there is also an MP_JOIN HMAC error that looks suspicious
      - Matth: TODO: check if it is linked

  220  support for setsockopt(SOL_IP) [enhancement]:
      - Linked to a discussion from last week
      - Poorva is looking at that
      - TODO: Matth: assign Poorva → Poorva needs to accept joining the
MPTCP team first.

  219  [syzkaller] divide error in tcp_write_xmit [bug] [syzkaller]:
      -  Opened during the meeting last week


    Bugs (opened, flagged as "bug" and assigned)

/


    Bugs (opened and flagged as "bug" and not assigned)

  221  selftests: join: "backup flow used, multi links fail" is unstable
[bug] [selftests]:
      - See above

  219  [syzkaller] divide error in tcp_write_xmit [bug] [syzkaller]
  203  PM: server: accept subflows [bug]
  181  implement data_fin ack retransmission for subflow in  TIME_WAIT
state [bug]
  137  selftests: simult_flows.sh: unbalanced bwidth tests are unstable
[bug]
   65  packetdrill/fixes: clearing properly the status in
listen()/disconnect [bug]


    In Progress (opened and assigned)

  218  Add support for MPTCP_INFO, similar to TCP_INFO [enhancement]
@fw-strlen:
      - See discussions above

  216  The infinite mapping support [enhancement] @geliangtang
  194  Round-robin packet scheduler support [enhancement] @geliangtang
  186  Add netlink command support [enhancement] @mjmartineau
  167  packetdrill: add coverage for RM_ADDR [enhancement] [packetdrill]
@dcaratti
  158  iproute2: change backup mode (MP_PRIO) for active connections
[enhancement] [iproute2] @dcaratti


    Recently closed (since last week)

  206  MPTCP-level retransmission strategy is probably too aggressive.
[enhancement] @pabeni
  193  Fullmesh path manager support [enhancement] @geliangtang
   52  MP_FAIL support [enhancement] @geliangtang



FYI: Current Roadmap:
    - Bugs: https://github.com/multipath-tcp/mptcp_net-next/projects/2
    - Current/Coming merge window (5.15):
https://github.com/multipath-tcp/mptcp_net-next/projects/10
    - For later: https://github.com/multipath-tcp/mptcp_net-next/projects/4



Patches to send to netdev:
    - net:
        - /

    - net-next:
        - scheduler refactoring (Paolo):
            - maybe best to wait to have more coverage? see issues 219
and 221 and 223
        - ADD_ADDR/RM_ADDR refactoring (Yonglong & Geliang):
            - maybe best to wait to have more coverage? see issues 219
and 221 and 223
        - mptcp_out_options refactor (Paolo):
            - maybe best to wait to have more coverage? see issues 219
and 221 and 223
        - Fullmesh support (Geliang):
            - has just been merged in our tree, maybe best to wait mid
of week
        - MP_FAIL (Geliang):
            - has just been merged in our tree, maybe best to wait mid
of week
            - but depends on "mptcp_out_options refactor"



Extra tests:
    - news about Syzkaller? (Mat & Christoph):
        - Mat's Syzkaller found 2 issues: 223 and one on IRC, already
fixed by Paolo (not in MPTCP code)
        - Mat will relaunch it on latest export branch

    - news about interop with mptcp.org? (Christoph):
        - /

    - news about Intel's kbuild? (Mat):
        - some issues not related to MPTCP last week
        - now pretty stable
        - just one deadlock when trying to remove a virtual device,
probably not related to MPTCP.

    - packetdrill (Davide):
        - some modifications due to behaviour changes in the kernel
(Paolo) → merged
        - some reviews for Poorva have been done

    - Patchew:
        - /

    - CI (Matth):
        - the join selftests are quite unstable for the moment with a
debug kernel: see issue 221



Next meeting:
    - On Thursday, the 12th of August.
    - Usual UTC time: 15:00 UTC (8am PDT, 5pm CEST, 11pm CST)
    - Still open to everyone!
    - https://annuel2.framapad.org/p/mptcp_upstreaming_20210812



Feel free to comment on these points and propose new ones for the next
meeting!

Talk to you on Thursday,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net