[PATCH] sandbox: Fix VPL instructions

[PATCH] sandbox: Fix VPL instructions

[Simon Glass]

Fix the devicetree used with sandbox. This is needed because the
default (full) devicetree must be used by all phases of boot, with
sandbox.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 doc/arch/sandbox/sandbox.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/arch/sandbox/sandbox.rst b/doc/arch/sandbox/sandbox.rst
index 23902dee89e7..9c69dea81ed1 100644
--- a/doc/arch/sandbox/sandbox.rst
+++ b/doc/arch/sandbox/sandbox.rst
@@ -427,7 +427,7 @@ VPL (Verifying Program Loader)
 Sandbox provides an example build of vpl called `sandbox_vpl`. This can be run
 using::
 
-   /path/to/sandbox_vpl/tpl/u-boot-tpl -D
+   /path/to/sandbox_vpl/tpl/u-boot-tpl -d /tmp/b/sandbox_vpl/u-boot.dtb
 
 It starts up TPL (first-stage init), then VPL, then runs SPL and finally U-Boot
 proper, following the normal flow for a verified boot. At present, no
-- 
2.42.0.869.gea05f2083d-goog

Re: [PATCH] sandbox: Fix VPL instructions

[Heinrich Schuchardt]

On 11/12/23 15:44, Simon Glass wrote:
> Fix the devicetree used with sandbox. This is needed because the
> default (full) devicetree must be used by all phases of boot, with
> sandbox.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   doc/arch/sandbox/sandbox.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/arch/sandbox/sandbox.rst b/doc/arch/sandbox/sandbox.rst
> index 23902dee89e7..9c69dea81ed1 100644
> --- a/doc/arch/sandbox/sandbox.rst
> +++ b/doc/arch/sandbox/sandbox.rst
> @@ -427,7 +427,7 @@ VPL (Verifying Program Loader)
>   Sandbox provides an example build of vpl called `sandbox_vpl`. This can be run

This will be confusing to a rookie. Please refer to sandbox_vpl_defconfig.

>   using::

using:

.. code-block:: bash

>
> -   /path/to/sandbox_vpl/tpl/u-boot-tpl -D

Please provide the full instructions:

make sandbox_vpl_defconfig
make
tpl/u-boot-tpl -d u-boot.dtb

> +   /path/to/sandbox_vpl/tpl/u-boot-tpl -d /tmp/b/sandbox_vpl/u-boot.dtb

Do we really use /tmp? We should place all build artifacts in the build
directory instead.

I could not find any directory called sandbox_vpl in my /tmp directory.

I could not make the example work:

$ make sandbox_vpl_defconfig
$ make
$ tpl/u-boot-tpl -d u-boot.dtb

U-Boot TPL 2024.01-rc2-00002-g66024fa8d5 (Nov 13 2023 - 01:09:03 +0100)
Trying to boot from sandbox_image
Trying to boot from sandbox_file
(tpl/u-boot-vpl not found, error -2)
TPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

u-boot-vpl is not in tpl/ but in vpl/.
The VPL example seems to need rework.

>
>   It starts up TPL (first-stage init), then VPL, then runs SPL and finally U-Boot
>   proper, following the normal flow for a verified boot. At present, no

Best regards

Heinrich