From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
anan.sun@mediatek.com, lc.kan@mediatek.com, yi.kuo@mediatek.com,
anthony.huang@mediatek.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable
Date: Wed, 12 Jan 2022 11:20:11 +0100 [thread overview]
Message-ID: <a3c48c27-515d-f741-e447-98e0ddfe3b01@canonical.com> (raw)
In-Reply-To: <20220111063904.7583-5-yong.wu@mediatek.com>
On 11/01/2022 07:39, Yong Wu wrote:
> The successful return value for clk_bulk_prepare_enable is 0, rather than
> "< 0". Fix this.
I do not understand. The commit description does not match the code.
What is the error here?
>
> Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops")
There is no bug to fix...
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/memory/mtk-smi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index b883dcc0bbfa..e7b1a22b12ea 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev)
> int ret;
>
> ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks);
> - if (ret < 0)
> + if (ret)
> return ret;
>
> /* Configure the basic setting for this larb */
>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org,
yi.kuo@mediatek.com, srv_heupstream@mediatek.com,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org, lc.kan@mediatek.com,
anthony.huang@mediatek.com, anan.sun@mediatek.com,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable
Date: Wed, 12 Jan 2022 11:20:11 +0100 [thread overview]
Message-ID: <a3c48c27-515d-f741-e447-98e0ddfe3b01@canonical.com> (raw)
In-Reply-To: <20220111063904.7583-5-yong.wu@mediatek.com>
On 11/01/2022 07:39, Yong Wu wrote:
> The successful return value for clk_bulk_prepare_enable is 0, rather than
> "< 0". Fix this.
I do not understand. The commit description does not match the code.
What is the error here?
>
> Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops")
There is no bug to fix...
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/memory/mtk-smi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index b883dcc0bbfa..e7b1a22b12ea 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev)
> int ret;
>
> ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks);
> - if (ret < 0)
> + if (ret)
> return ret;
>
> /* Configure the basic setting for this larb */
>
Best regards,
Krzysztof
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
anan.sun@mediatek.com, lc.kan@mediatek.com, yi.kuo@mediatek.com,
anthony.huang@mediatek.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable
Date: Wed, 12 Jan 2022 11:20:11 +0100 [thread overview]
Message-ID: <a3c48c27-515d-f741-e447-98e0ddfe3b01@canonical.com> (raw)
In-Reply-To: <20220111063904.7583-5-yong.wu@mediatek.com>
On 11/01/2022 07:39, Yong Wu wrote:
> The successful return value for clk_bulk_prepare_enable is 0, rather than
> "< 0". Fix this.
I do not understand. The commit description does not match the code.
What is the error here?
>
> Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops")
There is no bug to fix...
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/memory/mtk-smi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index b883dcc0bbfa..e7b1a22b12ea 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev)
> int ret;
>
> ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks);
> - if (ret < 0)
> + if (ret)
> return ret;
>
> /* Configure the basic setting for this larb */
>
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
anan.sun@mediatek.com, lc.kan@mediatek.com, yi.kuo@mediatek.com,
anthony.huang@mediatek.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable
Date: Wed, 12 Jan 2022 11:20:11 +0100 [thread overview]
Message-ID: <a3c48c27-515d-f741-e447-98e0ddfe3b01@canonical.com> (raw)
In-Reply-To: <20220111063904.7583-5-yong.wu@mediatek.com>
On 11/01/2022 07:39, Yong Wu wrote:
> The successful return value for clk_bulk_prepare_enable is 0, rather than
> "< 0". Fix this.
I do not understand. The commit description does not match the code.
What is the error here?
>
> Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops")
There is no bug to fix...
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/memory/mtk-smi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index b883dcc0bbfa..e7b1a22b12ea 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev)
> int ret;
>
> ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks);
> - if (ret < 0)
> + if (ret)
> return ret;
>
> /* Configure the basic setting for this larb */
>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-12 10:20 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 6:38 [PATCH v2 0/6] MT8186 SMI SUPPORT Yong Wu
2022-01-11 6:38 ` Yong Wu
2022-01-11 6:38 ` Yong Wu
2022-01-11 6:38 ` Yong Wu
2022-01-11 6:38 ` [PATCH v2 1/6] dt-bindings: memory: mtk-smi: Fix larb-id dtbs_check warning Yong Wu
2022-01-11 6:38 ` Yong Wu
2022-01-11 6:38 ` Yong Wu
2022-01-11 6:38 ` Yong Wu
2022-01-12 10:11 ` Krzysztof Kozlowski
2022-01-12 10:11 ` Krzysztof Kozlowski
2022-01-12 10:11 ` Krzysztof Kozlowski
2022-01-12 10:11 ` Krzysztof Kozlowski
2022-01-11 6:39 ` [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-12 10:18 ` Krzysztof Kozlowski
2022-01-12 10:18 ` Krzysztof Kozlowski
2022-01-12 10:18 ` Krzysztof Kozlowski
2022-01-12 10:18 ` Krzysztof Kozlowski
2022-01-13 6:06 ` Yong Wu
2022-01-13 6:06 ` Yong Wu
2022-01-13 6:06 ` Yong Wu
2022-01-13 6:06 ` Yong Wu
2022-01-11 6:39 ` [PATCH v2 3/6] dt-bindings: memory: mediatek: Add mt8186 support Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 9:10 ` AngeloGioacchino Del Regno
2022-01-11 9:10 ` AngeloGioacchino Del Regno
2022-01-11 9:10 ` AngeloGioacchino Del Regno
2022-01-11 9:10 ` AngeloGioacchino Del Regno
2022-01-13 6:05 ` Yong Wu
2022-01-13 6:05 ` Yong Wu
2022-01-13 6:05 ` Yong Wu
2022-01-13 6:05 ` Yong Wu
2022-01-12 10:20 ` Krzysztof Kozlowski [this message]
2022-01-12 10:20 ` Krzysztof Kozlowski
2022-01-12 10:20 ` Krzysztof Kozlowski
2022-01-12 10:20 ` Krzysztof Kozlowski
2022-01-11 6:39 ` [PATCH v2 5/6] memory: mtk-smi: Add sleep ctrl function Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 9:14 ` AngeloGioacchino Del Regno
2022-01-11 9:14 ` AngeloGioacchino Del Regno
2022-01-11 9:14 ` AngeloGioacchino Del Regno
2022-01-11 9:14 ` AngeloGioacchino Del Regno
2022-01-12 10:27 ` Krzysztof Kozlowski
2022-01-12 10:27 ` Krzysztof Kozlowski
2022-01-12 10:27 ` Krzysztof Kozlowski
2022-01-12 10:27 ` Krzysztof Kozlowski
2022-01-13 6:02 ` Yong Wu
2022-01-13 6:02 ` Yong Wu
2022-01-13 6:02 ` Yong Wu
2022-01-13 6:02 ` Yong Wu
2022-01-11 6:39 ` [PATCH v2 6/6] memory: mtk-smi: mt8186: Add smi support Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
2022-01-11 6:39 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c48c27-515d-f741-e447-98e0ddfe3b01@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=lc.kan@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.