[PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Chris Wilson]

drm_atomic_helper allows for up to one outstanding cleanup task to be in
flight before a new modeset (see stall_commit in stall_checks()), In
lieu of hooking up a debugfs to force flushing of the outstanding work,
submit enough blocking modesets to ensure that the pending work is
completed before continuing.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_universal_plane.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index 58f329e68..f875fd194 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_plane_set_fb(primary, NULL);
 	igt_plane_set_fb(cursor, NULL);
 	igt_display_commit2(display, COMMIT_LEGACY);
+	igt_display_commit2(display, COMMIT_LEGACY);
 	cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
 
 	/* We should be back to the same framebuffer count as when we started */
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Chris Wilson]

drm_atomic_helper allows for up to one outstanding cleanup task to be in
flight before a new modeset (see stall_commit in stall_checks()), In
lieu of hooking up a debugfs to force flushing of the outstanding work,
submit enough blocking modesets to ensure that the pending work is
completed before continuing.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_universal_plane.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index 58f329e68..f875fd194 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_plane_set_fb(primary, NULL);
 	igt_plane_set_fb(cursor, NULL);
 	igt_display_commit2(display, COMMIT_LEGACY);
+	igt_display_commit2(display, COMMIT_LEGACY);
 	cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
 
 	/* We should be back to the same framebuffer count as when we started */
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Maarten Lankhorst]

Op 28-06-18 om 12:51 schreef Chris Wilson:
> drm_atomic_helper allows for up to one outstanding cleanup task to be in
> flight before a new modeset (see stall_commit in stall_checks()), In
> lieu of hooking up a debugfs to force flushing of the outstanding work,
> submit enough blocking modesets to ensure that the pending work is
> completed before continuing.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_universal_plane.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> index 58f329e68..f875fd194 100644
> --- a/tests/kms_universal_plane.c
> +++ b/tests/kms_universal_plane.c
> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>  	igt_plane_set_fb(primary, NULL);
>  	igt_plane_set_fb(cursor, NULL);
>  	igt_display_commit2(display, COMMIT_LEGACY);
> +	igt_display_commit2(display, COMMIT_LEGACY);
>  	cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
>  
>  	/* We should be back to the same framebuffer count as when we started */

This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.

Testcase: kms_universal_plane@cursor-fb-leak-*

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Maarten Lankhorst]

Op 28-06-18 om 12:51 schreef Chris Wilson:
> drm_atomic_helper allows for up to one outstanding cleanup task to be in
> flight before a new modeset (see stall_commit in stall_checks()), In
> lieu of hooking up a debugfs to force flushing of the outstanding work,
> submit enough blocking modesets to ensure that the pending work is
> completed before continuing.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_universal_plane.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> index 58f329e68..f875fd194 100644
> --- a/tests/kms_universal_plane.c
> +++ b/tests/kms_universal_plane.c
> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>  	igt_plane_set_fb(primary, NULL);
>  	igt_plane_set_fb(cursor, NULL);
>  	igt_display_commit2(display, COMMIT_LEGACY);
> +	igt_display_commit2(display, COMMIT_LEGACY);
>  	cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
>  
>  	/* We should be back to the same framebuffer count as when we started */

This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.

Testcase: kms_universal_plane@cursor-fb-leak-*

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Chris Wilson]

Quoting Maarten Lankhorst (2018-06-28 12:06:35)
> Op 28-06-18 om 12:51 schreef Chris Wilson:
> > drm_atomic_helper allows for up to one outstanding cleanup task to be in
> > flight before a new modeset (see stall_commit in stall_checks()), In
> > lieu of hooking up a debugfs to force flushing of the outstanding work,
> > submit enough blocking modesets to ensure that the pending work is
> > completed before continuing.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> >  tests/kms_universal_plane.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> > index 58f329e68..f875fd194 100644
> > --- a/tests/kms_universal_plane.c
> > +++ b/tests/kms_universal_plane.c
> > @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> >       igt_plane_set_fb(primary, NULL);
> >       igt_plane_set_fb(cursor, NULL);
> >       igt_display_commit2(display, COMMIT_LEGACY);
> > +     igt_display_commit2(display, COMMIT_LEGACY);
> >       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
> >  
> >       /* We should be back to the same framebuffer count as when we started */
> 
> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.

Fill in the details above. :-p

Is that igt or the kernel? I have this belief that when I ask it to do
something, it should ;)

igt_display_commit3(display, COMMIT_LEGACY, DOIT);
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Chris Wilson]

Quoting Maarten Lankhorst (2018-06-28 12:06:35)
> Op 28-06-18 om 12:51 schreef Chris Wilson:
> > drm_atomic_helper allows for up to one outstanding cleanup task to be in
> > flight before a new modeset (see stall_commit in stall_checks()), In
> > lieu of hooking up a debugfs to force flushing of the outstanding work,
> > submit enough blocking modesets to ensure that the pending work is
> > completed before continuing.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> >  tests/kms_universal_plane.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> > index 58f329e68..f875fd194 100644
> > --- a/tests/kms_universal_plane.c
> > +++ b/tests/kms_universal_plane.c
> > @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> >       igt_plane_set_fb(primary, NULL);
> >       igt_plane_set_fb(cursor, NULL);
> >       igt_display_commit2(display, COMMIT_LEGACY);
> > +     igt_display_commit2(display, COMMIT_LEGACY);
> >       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
> >  
> >       /* We should be back to the same framebuffer count as when we started */
> 
> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.

Fill in the details above. :-p

Is that igt or the kernel? I have this belief that when I ask it to do
something, it should ;)

igt_display_commit3(display, COMMIT_LEGACY, DOIT);
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for igt/kms_universal_plane: Flush pending cleanups

[Patchwork]

== Series Details ==

Series: igt/kms_universal_plane: Flush pending cleanups
URL   : https://patchwork.freedesktop.org/series/45570/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4373 -> IGTPW_1508 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/45570/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1508 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ringfill@basic-default-hang:
      fi-pnv-d510:        NOTRUN -> DMESG-WARN (fdo#101600)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128) -> PASS

    
  fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128


== Participating hosts (43 -> 39) ==

  Additional (1): fi-pnv-d510 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4529 -> IGTPW_1508

  CI_DRM_4373: be7193758db79443ad5dc45072a166746819ba7e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1508: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1508/
  IGT_4529: 23d50a49413aff619d00ec50fc2e051e9b45baa5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1508/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Maarten Lankhorst]

Op 28-06-18 om 13:16 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2018-06-28 12:06:35)
>> Op 28-06-18 om 12:51 schreef Chris Wilson:
>>> drm_atomic_helper allows for up to one outstanding cleanup task to be in
>>> flight before a new modeset (see stall_commit in stall_checks()), In
>>> lieu of hooking up a debugfs to force flushing of the outstanding work,
>>> submit enough blocking modesets to ensure that the pending work is
>>> completed before continuing.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> ---
>>>  tests/kms_universal_plane.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
>>> index 58f329e68..f875fd194 100644
>>> --- a/tests/kms_universal_plane.c
>>> +++ b/tests/kms_universal_plane.c
>>> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>>       igt_plane_set_fb(primary, NULL);
>>>       igt_plane_set_fb(cursor, NULL);
>>>       igt_display_commit2(display, COMMIT_LEGACY);
>>> +     igt_display_commit2(display, COMMIT_LEGACY);
>>>       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
>>>  
>>>       /* We should be back to the same framebuffer count as when we started */
>> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.
> Fill in the details above. :-p
>
> Is that igt or the kernel? I have this belief that when I ask it to do
> something, it should ;)
>
> igt_display_commit3(display, COMMIT_LEGACY, DOIT);
> -Chris

But you didn't tell it to do anything, nothing changed from last commit, so nothing gets committed.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Maarten Lankhorst]

Op 28-06-18 om 13:16 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2018-06-28 12:06:35)
>> Op 28-06-18 om 12:51 schreef Chris Wilson:
>>> drm_atomic_helper allows for up to one outstanding cleanup task to be in
>>> flight before a new modeset (see stall_commit in stall_checks()), In
>>> lieu of hooking up a debugfs to force flushing of the outstanding work,
>>> submit enough blocking modesets to ensure that the pending work is
>>> completed before continuing.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> ---
>>>  tests/kms_universal_plane.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
>>> index 58f329e68..f875fd194 100644
>>> --- a/tests/kms_universal_plane.c
>>> +++ b/tests/kms_universal_plane.c
>>> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>>       igt_plane_set_fb(primary, NULL);
>>>       igt_plane_set_fb(cursor, NULL);
>>>       igt_display_commit2(display, COMMIT_LEGACY);
>>> +     igt_display_commit2(display, COMMIT_LEGACY);
>>>       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
>>>  
>>>       /* We should be back to the same framebuffer count as when we started */
>> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.
> Fill in the details above. :-p
>
> Is that igt or the kernel? I have this belief that when I ask it to do
> something, it should ;)
>
> igt_display_commit3(display, COMMIT_LEGACY, DOIT);
> -Chris

But you didn't tell it to do anything, nothing changed from last commit, so nothing gets committed.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Chris Wilson]

Quoting Maarten Lankhorst (2018-06-28 12:25:18)
> Op 28-06-18 om 13:16 schreef Chris Wilson:
> > Quoting Maarten Lankhorst (2018-06-28 12:06:35)
> >> Op 28-06-18 om 12:51 schreef Chris Wilson:
> >>> drm_atomic_helper allows for up to one outstanding cleanup task to be in
> >>> flight before a new modeset (see stall_commit in stall_checks()), In
> >>> lieu of hooking up a debugfs to force flushing of the outstanding work,
> >>> submit enough blocking modesets to ensure that the pending work is
> >>> completed before continuing.
> >>>
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >>> ---
> >>>  tests/kms_universal_plane.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> >>> index 58f329e68..f875fd194 100644
> >>> --- a/tests/kms_universal_plane.c
> >>> +++ b/tests/kms_universal_plane.c
> >>> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> >>>       igt_plane_set_fb(primary, NULL);
> >>>       igt_plane_set_fb(cursor, NULL);
> >>>       igt_display_commit2(display, COMMIT_LEGACY);
> >>> +     igt_display_commit2(display, COMMIT_LEGACY);
> >>>       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
> >>>  
> >>>       /* We should be back to the same framebuffer count as when we started */
> >> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.
> > Fill in the details above. :-p
> >
> > Is that igt or the kernel? I have this belief that when I ask it to do
> > something, it should ;)
> >
> > igt_display_commit3(display, COMMIT_LEGACY, DOIT);
> > -Chris
> 
> But you didn't tell it to do anything, nothing changed from last commit, so nothing gets committed.

But I want it to reapply the commit I built up. That's how I think of
it, since I'm used to a stateless API.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Chris Wilson]

Quoting Maarten Lankhorst (2018-06-28 12:25:18)
> Op 28-06-18 om 13:16 schreef Chris Wilson:
> > Quoting Maarten Lankhorst (2018-06-28 12:06:35)
> >> Op 28-06-18 om 12:51 schreef Chris Wilson:
> >>> drm_atomic_helper allows for up to one outstanding cleanup task to be in
> >>> flight before a new modeset (see stall_commit in stall_checks()), In
> >>> lieu of hooking up a debugfs to force flushing of the outstanding work,
> >>> submit enough blocking modesets to ensure that the pending work is
> >>> completed before continuing.
> >>>
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >>> ---
> >>>  tests/kms_universal_plane.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> >>> index 58f329e68..f875fd194 100644
> >>> --- a/tests/kms_universal_plane.c
> >>> +++ b/tests/kms_universal_plane.c
> >>> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> >>>       igt_plane_set_fb(primary, NULL);
> >>>       igt_plane_set_fb(cursor, NULL);
> >>>       igt_display_commit2(display, COMMIT_LEGACY);
> >>> +     igt_display_commit2(display, COMMIT_LEGACY);
> >>>       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
> >>>  
> >>>       /* We should be back to the same framebuffer count as when we started */
> >> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.
> > Fill in the details above. :-p
> >
> > Is that igt or the kernel? I have this belief that when I ask it to do
> > something, it should ;)
> >
> > igt_display_commit3(display, COMMIT_LEGACY, DOIT);
> > -Chris
> 
> But you didn't tell it to do anything, nothing changed from last commit, so nothing gets committed.

But I want it to reapply the commit I built up. That's how I think of
it, since I'm used to a stateless API.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Maarten Lankhorst]

Op 28-06-18 om 13:34 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2018-06-28 12:25:18)
>> Op 28-06-18 om 13:16 schreef Chris Wilson:
>>> Quoting Maarten Lankhorst (2018-06-28 12:06:35)
>>>> Op 28-06-18 om 12:51 schreef Chris Wilson:
>>>>> drm_atomic_helper allows for up to one outstanding cleanup task to be in
>>>>> flight before a new modeset (see stall_commit in stall_checks()), In
>>>>> lieu of hooking up a debugfs to force flushing of the outstanding work,
>>>>> submit enough blocking modesets to ensure that the pending work is
>>>>> completed before continuing.
>>>>>
>>>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>>> ---
>>>>>  tests/kms_universal_plane.c | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
>>>>> index 58f329e68..f875fd194 100644
>>>>> --- a/tests/kms_universal_plane.c
>>>>> +++ b/tests/kms_universal_plane.c
>>>>> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>>>>       igt_plane_set_fb(primary, NULL);
>>>>>       igt_plane_set_fb(cursor, NULL);
>>>>>       igt_display_commit2(display, COMMIT_LEGACY);
>>>>> +     igt_display_commit2(display, COMMIT_LEGACY);
>>>>>       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
>>>>>  
>>>>>       /* We should be back to the same framebuffer count as when we started */
>>>> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.
>>> Fill in the details above. :-p
>>>
>>> Is that igt or the kernel? I have this belief that when I ask it to do
>>> something, it should ;)
>>>
>>> igt_display_commit3(display, COMMIT_LEGACY, DOIT);
>>> -Chris
>> But you didn't tell it to do anything, nothing changed from last commit, so nothing gets committed.
> But I want it to reapply the commit I built up. That's how I think of
> it, since I'm used to a stateless API.
> -Chris

But there's nothing to apply, the commit is already applied.

That's how the api has always worked, at least. :)

~Maarten

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

[Maarten Lankhorst]

Op 28-06-18 om 13:34 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2018-06-28 12:25:18)
>> Op 28-06-18 om 13:16 schreef Chris Wilson:
>>> Quoting Maarten Lankhorst (2018-06-28 12:06:35)
>>>> Op 28-06-18 om 12:51 schreef Chris Wilson:
>>>>> drm_atomic_helper allows for up to one outstanding cleanup task to be in
>>>>> flight before a new modeset (see stall_commit in stall_checks()), In
>>>>> lieu of hooking up a debugfs to force flushing of the outstanding work,
>>>>> submit enough blocking modesets to ensure that the pending work is
>>>>> completed before continuing.
>>>>>
>>>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>>> ---
>>>>>  tests/kms_universal_plane.c | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
>>>>> index 58f329e68..f875fd194 100644
>>>>> --- a/tests/kms_universal_plane.c
>>>>> +++ b/tests/kms_universal_plane.c
>>>>> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>>>>       igt_plane_set_fb(primary, NULL);
>>>>>       igt_plane_set_fb(cursor, NULL);
>>>>>       igt_display_commit2(display, COMMIT_LEGACY);
>>>>> +     igt_display_commit2(display, COMMIT_LEGACY);
>>>>>       cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
>>>>>  
>>>>>       /* We should be back to the same framebuffer count as when we started */
>>>> This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.
>>> Fill in the details above. :-p
>>>
>>> Is that igt or the kernel? I have this belief that when I ask it to do
>>> something, it should ;)
>>>
>>> igt_display_commit3(display, COMMIT_LEGACY, DOIT);
>>> -Chris
>> But you didn't tell it to do anything, nothing changed from last commit, so nothing gets committed.
> But I want it to reapply the commit I built up. That's how I think of
> it, since I'm used to a stateless API.
> -Chris

But there's nothing to apply, the commit is already applied.

That's how the api has always worked, at least. :)

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for igt/kms_universal_plane: Flush pending cleanups

[Patchwork]

== Series Details ==

Series: igt/kms_universal_plane: Flush pending cleanups
URL   : https://patchwork.freedesktop.org/series/45570/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4529_full -> IGTPW_1508_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1508_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1508_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/45570/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1508_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in IGTPW_1508_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-snb:          PASS -> FAIL (fdo#106886)
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106886)

    igt@gem_exec_big:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822, fdo#104724)

    igt@kms_frontbuffer_tracking@basic:
      shard-glk:          PASS -> FAIL (fdo#103167, fdo#104724)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
      {shard-glk9}:       NOTRUN -> FAIL (fdo#103167, fdo#104724)

    igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-render:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          PASS -> FAIL (fdo#103166, fdo#104724)

    igt@kms_vblank@pipe-a-accuracy-idle:
      shard-glk:          PASS -> FAIL (fdo#102583)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      shard-apl:          DMESG-FAIL (fdo#106947, fdo#106560) -> PASS

    igt@gem_exec_params@rs-invalid-on-bsd-ring:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_cursor_crc@cursor-64x64-onscreen:
      shard-glk:          INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    igt@kms_flip@2x-plain-flip-fb-recreate:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip@dpms-vs-vblank-race:
      shard-glk:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
      shard-snb:          FAIL (fdo#103167, fdo#104724) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      shard-glk:          DMESG-WARN (fdo#106247) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-hsw:          FAIL (fdo#103925, fdo#104724) -> PASS

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          FAIL (fdo#103925, fdo#104724) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 6) ==

  Additional (1): shard-glk9 


== Build changes ==

    * IGT: IGT_4529 -> IGTPW_1508
    * Linux: CI_DRM_4371 -> CI_DRM_4373

  CI_DRM_4371: 9094e9d97a6e13db8c1a444d08c0988adad9a002 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4373: be7193758db79443ad5dc45072a166746819ba7e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1508: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1508/
  IGT_4529: 23d50a49413aff619d00ec50fc2e051e9b45baa5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1508/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev