All of lore.kernel.org
 help / color / mirror / Atom feed
* Semodule accepts bad modules every other time
@ 2020-05-18  9:40 Topi Miettinen
  2020-05-18 13:55 ` Stephen Smalley
  0 siblings, 1 reply; 4+ messages in thread
From: Topi Miettinen @ 2020-05-18  9:40 UTC (permalink / raw)
  To: SElinux list

Hi,

I have a module, which can be compiled without problems but it can still 
generate errors during load. However, every other time the load succeeds.

Here's the example:
# cat foo.te
module foo 1.0;

type file_type;

require {
         type user_t; # dummy require statement to keep checkmodule happy
}
# make
Compiling default foo module
Creating default foo.pp policy package
rm tmp/foo.mod.fc tmp/foo.mod
# make QUIET=n load
Loading default modules: foo
/usr/sbin/semodule -i foo.pp
Re-declaration of type file_type
Failed to create node
Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
/usr/sbin/semodule:  Failed!
make: *** [/usr/share/selinux/devel/include/Makefile:148: tmp/loaded] 
Error 1
# make QUIET=n load
Loading default modules: foo
/usr/sbin/semodule -i foo.pp
(no error)

Running semodule directly:
# semodule -i foo.pp
Re-declaration of type file_type
Failed to create node
Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
semodule:  Failed!
# semodule -i foo.pp
# semodule -i foo.pp
Re-declaration of type file_type
Failed to create node
Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
semodule:  Failed!
# semodule -i foo.pp

Maybe the failing transaction is not reverted properly and then the 
failed module changes the system somehow? Some problem with detecting 
redeclarations?

-Topi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Semodule accepts bad modules every other time
  2020-05-18  9:40 Semodule accepts bad modules every other time Topi Miettinen
@ 2020-05-18 13:55 ` Stephen Smalley
  2020-05-18 14:41   ` James Carter
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Smalley @ 2020-05-18 13:55 UTC (permalink / raw)
  To: Topi Miettinen, James Carter; +Cc: SElinux list

On Mon, May 18, 2020 at 5:43 AM Topi Miettinen <toiwoton@gmail.com> wrote:
>
> Hi,
>
> I have a module, which can be compiled without problems but it can still
> generate errors during load. However, every other time the load succeeds.
>
> Here's the example:
> # cat foo.te
> module foo 1.0;
>
> type file_type;
>
> require {
>          type user_t; # dummy require statement to keep checkmodule happy
> }
> # make
> Compiling default foo module
> Creating default foo.pp policy package
> rm tmp/foo.mod.fc tmp/foo.mod
> # make QUIET=n load
> Loading default modules: foo
> /usr/sbin/semodule -i foo.pp
> Re-declaration of type file_type
> Failed to create node
> Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
> /usr/sbin/semodule:  Failed!
> make: *** [/usr/share/selinux/devel/include/Makefile:148: tmp/loaded]
> Error 1
> # make QUIET=n load
> Loading default modules: foo
> /usr/sbin/semodule -i foo.pp
> (no error)
>
> Running semodule directly:
> # semodule -i foo.pp
> Re-declaration of type file_type
> Failed to create node
> Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
> semodule:  Failed!
> # semodule -i foo.pp
> # semodule -i foo.pp
> Re-declaration of type file_type
> Failed to create node
> Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
> semodule:  Failed!
> # semodule -i foo.pp
>
> Maybe the failing transaction is not reverted properly and then the
> failed module changes the system somehow? Some problem with detecting
> redeclarations?

Looks like a bug in libsepol to me:
# valgrind semodule -i foo.pp
==5989== Memcheck, a memory error detector
==5989== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==5989== Using Valgrind-3.16.0.GIT and LibVEX; rerun with -h for copyright info
==5989== Command: semodule -i foo.pp
==5989==
==5989== Conditional jump or move depends on uninitialised value(s)
==5989==    at 0x48E02F5: cil_gen_node (cil_build_ast.c:129)
==5989==    by 0x48E3FD3: cil_gen_type (cil_build_ast.c:2315)
==5989==    by 0x48EBDC0: __cil_build_ast_node_helper (cil_build_ast.c:6261)
==5989==    by 0x490AF1D: cil_tree_walk_core (cil_tree.c:272)
==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
==5989==    by 0x490AF8F: cil_tree_walk_core (cil_tree.c:284)
==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
==5989==    by 0x490AF8F: cil_tree_walk_core (cil_tree.c:284)
==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
==5989==    by 0x48ED269: cil_build_ast (cil_build_ast.c:6571)
==5989==    by 0x48D019F: cil_compile@@LIBSEPOL_1.1 (cil.c:564)
==5989==    by 0x498A646: semanage_direct_commit (direct_api.c:1419)
==5989==
Re-declaration of type file_type
Failed to create node
Bad type declaration at /var/lib/selinux/targeted/tmp/modules/400/foo/cil:1
semodule:  Failed!

Without valgrind, I get a segfault.  This is with make DEBUG=1.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Semodule accepts bad modules every other time
  2020-05-18 13:55 ` Stephen Smalley
@ 2020-05-18 14:41   ` James Carter
  2020-05-19  9:32     ` Topi Miettinen
  0 siblings, 1 reply; 4+ messages in thread
From: James Carter @ 2020-05-18 14:41 UTC (permalink / raw)
  To: Stephen Smalley; +Cc: Topi Miettinen, SElinux list

On Mon, May 18, 2020 at 9:56 AM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Mon, May 18, 2020 at 5:43 AM Topi Miettinen <toiwoton@gmail.com> wrote:
> >
> > Hi,
> >
> > I have a module, which can be compiled without problems but it can still
> > generate errors during load. However, every other time the load succeeds.
> >
> > Here's the example:
> > # cat foo.te
> > module foo 1.0;
> >
> > type file_type;
> >
> > require {
> >          type user_t; # dummy require statement to keep checkmodule happy
> > }
> > # make
> > Compiling default foo module
> > Creating default foo.pp policy package
> > rm tmp/foo.mod.fc tmp/foo.mod
> > # make QUIET=n load
> > Loading default modules: foo
> > /usr/sbin/semodule -i foo.pp
> > Re-declaration of type file_type
> > Failed to create node
> > Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
> > /usr/sbin/semodule:  Failed!
> > make: *** [/usr/share/selinux/devel/include/Makefile:148: tmp/loaded]
> > Error 1
> > # make QUIET=n load
> > Loading default modules: foo
> > /usr/sbin/semodule -i foo.pp
> > (no error)
> >
> > Running semodule directly:
> > # semodule -i foo.pp
> > Re-declaration of type file_type
> > Failed to create node
> > Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
> > semodule:  Failed!
> > # semodule -i foo.pp
> > # semodule -i foo.pp
> > Re-declaration of type file_type
> > Failed to create node
> > Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
> > semodule:  Failed!
> > # semodule -i foo.pp
> >
> > Maybe the failing transaction is not reverted properly and then the
> > failed module changes the system somehow? Some problem with detecting
> > redeclarations?
>
> Looks like a bug in libsepol to me:
> # valgrind semodule -i foo.pp
> ==5989== Memcheck, a memory error detector
> ==5989== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
> ==5989== Using Valgrind-3.16.0.GIT and LibVEX; rerun with -h for copyright info
> ==5989== Command: semodule -i foo.pp
> ==5989==
> ==5989== Conditional jump or move depends on uninitialised value(s)
> ==5989==    at 0x48E02F5: cil_gen_node (cil_build_ast.c:129)
> ==5989==    by 0x48E3FD3: cil_gen_type (cil_build_ast.c:2315)
> ==5989==    by 0x48EBDC0: __cil_build_ast_node_helper (cil_build_ast.c:6261)
> ==5989==    by 0x490AF1D: cil_tree_walk_core (cil_tree.c:272)
> ==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
> ==5989==    by 0x490AF8F: cil_tree_walk_core (cil_tree.c:284)
> ==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
> ==5989==    by 0x490AF8F: cil_tree_walk_core (cil_tree.c:284)
> ==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
> ==5989==    by 0x48ED269: cil_build_ast (cil_build_ast.c:6571)
> ==5989==    by 0x48D019F: cil_compile@@LIBSEPOL_1.1 (cil.c:564)
> ==5989==    by 0x498A646: semanage_direct_commit (direct_api.c:1419)
> ==5989==
> Re-declaration of type file_type
> Failed to create node
> Bad type declaration at /var/lib/selinux/targeted/tmp/modules/400/foo/cil:1
> semodule:  Failed!
>
> Without valgrind, I get a segfault.  This is with make DEBUG=1.

I didn't try valgrind with semodule -i (it only segfaults for me when
running under valgrind), but I did notice a segault every other time I
did semodule -vB (with or without valgrind).

Since file_type is declared as an attribute, there definitely should
be an error when you try to declare it as a type.

I'll take a closer look.

Jim

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Semodule accepts bad modules every other time
  2020-05-18 14:41   ` James Carter
@ 2020-05-19  9:32     ` Topi Miettinen
  0 siblings, 0 replies; 4+ messages in thread
From: Topi Miettinen @ 2020-05-19  9:32 UTC (permalink / raw)
  To: James Carter, Stephen Smalley; +Cc: SElinux list

On 18.5.2020 17.41, James Carter wrote:
> On Mon, May 18, 2020 at 9:56 AM Stephen Smalley
> <stephen.smalley.work@gmail.com> wrote:
>>
>> On Mon, May 18, 2020 at 5:43 AM Topi Miettinen <toiwoton@gmail.com> wrote:
>>>
>>> Hi,
>>>
>>> I have a module, which can be compiled without problems but it can still
>>> generate errors during load. However, every other time the load succeeds.
>>>
>>> Here's the example:
>>> # cat foo.te
>>> module foo 1.0;
>>>
>>> type file_type;
>>>
>>> require {
>>>           type user_t; # dummy require statement to keep checkmodule happy
>>> }
>>> # make
>>> Compiling default foo module
>>> Creating default foo.pp policy package
>>> rm tmp/foo.mod.fc tmp/foo.mod
>>> # make QUIET=n load
>>> Loading default modules: foo
>>> /usr/sbin/semodule -i foo.pp
>>> Re-declaration of type file_type
>>> Failed to create node
>>> Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
>>> /usr/sbin/semodule:  Failed!
>>> make: *** [/usr/share/selinux/devel/include/Makefile:148: tmp/loaded]
>>> Error 1
>>> # make QUIET=n load
>>> Loading default modules: foo
>>> /usr/sbin/semodule -i foo.pp
>>> (no error)
>>>
>>> Running semodule directly:
>>> # semodule -i foo.pp
>>> Re-declaration of type file_type
>>> Failed to create node
>>> Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
>>> semodule:  Failed!
>>> # semodule -i foo.pp
>>> # semodule -i foo.pp
>>> Re-declaration of type file_type
>>> Failed to create node
>>> Bad type declaration at /var/lib/selinux/default/tmp/modules/400/foo/cil:1
>>> semodule:  Failed!
>>> # semodule -i foo.pp
>>>
>>> Maybe the failing transaction is not reverted properly and then the
>>> failed module changes the system somehow? Some problem with detecting
>>> redeclarations?
>>
>> Looks like a bug in libsepol to me:
>> # valgrind semodule -i foo.pp
>> ==5989== Memcheck, a memory error detector
>> ==5989== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
>> ==5989== Using Valgrind-3.16.0.GIT and LibVEX; rerun with -h for copyright info
>> ==5989== Command: semodule -i foo.pp
>> ==5989==
>> ==5989== Conditional jump or move depends on uninitialised value(s)
>> ==5989==    at 0x48E02F5: cil_gen_node (cil_build_ast.c:129)
>> ==5989==    by 0x48E3FD3: cil_gen_type (cil_build_ast.c:2315)
>> ==5989==    by 0x48EBDC0: __cil_build_ast_node_helper (cil_build_ast.c:6261)
>> ==5989==    by 0x490AF1D: cil_tree_walk_core (cil_tree.c:272)
>> ==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
>> ==5989==    by 0x490AF8F: cil_tree_walk_core (cil_tree.c:284)
>> ==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
>> ==5989==    by 0x490AF8F: cil_tree_walk_core (cil_tree.c:284)
>> ==5989==    by 0x490B06C: cil_tree_walk (cil_tree.c:316)
>> ==5989==    by 0x48ED269: cil_build_ast (cil_build_ast.c:6571)
>> ==5989==    by 0x48D019F: cil_compile@@LIBSEPOL_1.1 (cil.c:564)
>> ==5989==    by 0x498A646: semanage_direct_commit (direct_api.c:1419)
>> ==5989==
>> Re-declaration of type file_type
>> Failed to create node
>> Bad type declaration at /var/lib/selinux/targeted/tmp/modules/400/foo/cil:1
>> semodule:  Failed!
>>
>> Without valgrind, I get a segfault.  This is with make DEBUG=1.
> 
> I didn't try valgrind with semodule -i (it only segfaults for me when
> running under valgrind), but I did notice a segault every other time I
> did semodule -vB (with or without valgrind).
> 
> Since file_type is declared as an attribute, there definitely should
> be an error when you try to declare it as a type.

Replacing 'type' with 'attribute':
module foo 1.0;

#type file_type;
attribute file_type;

require {
         type user_t; # dummy require statement to keep checkmodule happy
}

Compiling default foo module
Creating default foo.pp policy package
rm tmp/foo.mod.fc tmp/foo.mod
# make load
Loading default modules: foo
Re-declaration of typeattribute file_type
Failed to create node
Bad typeattribute declaration at 
/var/lib/selinux/default/tmp/modules/400/foo/cil:1
/usr/sbin/semodule:  Failed!
make: *** [/usr/share/selinux/devel/include/Makefile:148: tmp/loaded] 
Error 1
# semodule -i foo.pp
# semodule -i foo.pp
Re-declaration of typeattribute file_type
Failed to create node
Bad typeattribute declaration at 
/var/lib/selinux/default/tmp/modules/400/foo/cil:1
semodule:  Failed!

-Topi

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-19  9:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18  9:40 Semodule accepts bad modules every other time Topi Miettinen
2020-05-18 13:55 ` Stephen Smalley
2020-05-18 14:41   ` James Carter
2020-05-19  9:32     ` Topi Miettinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.