All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/mpd: add option for async file access using io_uring
@ 2022-02-16 15:49 Andreas Ziegler
  2022-07-24 14:09 ` Romain Naour
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Ziegler @ 2022-02-16 15:49 UTC (permalink / raw)
  To: buildroot; +Cc: Andreas Ziegler, Jörg Krause

In version 0.22 mpd added an option to use the io_uring kernel interface for 
asynchronous access to local files. Buildroot added the necessary library 
(package/liburing) in commit 03ca6f4e39874583060317e7e15e9e360220877e.

Add an option for mpd to optionally enable asynchronous file access using 
io_uring (via liburing).

Signed-off-by: Andreas Ziegler <br015@umbiko.net>
---
 package/mpd/Config.in | 10 ++++++++++
 package/mpd/mpd.mk    |  7 +++++++
 2 files changed, 17 insertions(+)

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index fc0f409448..c5a50898e2 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -347,6 +347,16 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
 comment "avahi support needs a toolchain w/ dynamic library"
 	depends on BR2_STATIC_LIBS
 
+config BR2_PACKAGE_MPD_IO_URING
+	bool "io_uring"
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
+	select BR2_PACKAGE_LIBURING
+	help
+	  Asynchronous I/O using kernel io_uring subsystem
+
+comment "io_uring needs at least kernel version 5.1"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
+
 config BR2_PACKAGE_MPD_LIBMPDCLIENT
 	bool "libmpdclient"
 	select BR2_PACKAGE_LIBMPDCLIENT
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index a55e4adde2..a0cebedc64 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -119,6 +119,13 @@ else
 MPD_CONF_OPTS += -Did3tag=disabled
 endif
 
+ifeq ($(BR2_PACKAGE_MPD_IO_URING),y)
+MPD_DEPENDENCIES += liburing
+MPD_CONF_OPTS += -Dio_uring=enabled
+else
+MPD_CONF_OPTS += -Dio_uring=disabled
+endif
+
 ifeq ($(BR2_PACKAGE_MPD_JACK2),y)
 MPD_DEPENDENCIES += jack2
 MPD_CONF_OPTS += -Djack=enabled
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/mpd: add option for async file access using io_uring
  2022-02-16 15:49 [Buildroot] [PATCH 1/1] package/mpd: add option for async file access using io_uring Andreas Ziegler
@ 2022-07-24 14:09 ` Romain Naour
  2022-07-25 12:30   ` [Buildroot] [PATCH v2 1/1] package/mpd: add io_uring optional dependency Andreas Ziegler
  0 siblings, 1 reply; 4+ messages in thread
From: Romain Naour @ 2022-07-24 14:09 UTC (permalink / raw)
  To: Andreas Ziegler, buildroot; +Cc: Jörg Krause

Hello Andreas

Le 16/02/2022 à 16:49, Andreas Ziegler a écrit :
> In version 0.22 mpd added an option to use the io_uring kernel interface for 
> asynchronous access to local files. Buildroot added the necessary library 
> (package/liburing) in commit 03ca6f4e39874583060317e7e15e9e360220877e.
> 
> Add an option for mpd to optionally enable asynchronous file access using 
> io_uring (via liburing).

The commit title could be

"package/mpd: add io_uring optional dependency"

> 
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> ---
>  package/mpd/Config.in | 10 ++++++++++
>  package/mpd/mpd.mk    |  7 +++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index fc0f409448..c5a50898e2 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -347,6 +347,16 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
>  comment "avahi support needs a toolchain w/ dynamic library"
>  	depends on BR2_STATIC_LIBS
>  
> +config BR2_PACKAGE_MPD_IO_URING
> +	bool "io_uring"
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
> +	select BR2_PACKAGE_LIBURING
> +	help
> +	  Asynchronous I/O using kernel io_uring subsystem
> +
> +comment "io_uring needs at least kernel version 5.1"

It's not a kernel version dependency but a toolchain kernel headers dependency.

Usually we use the following comment format:

"io_uring support needs a toolchain w/ headers >= 5.1"

Reviewed-by: Romain Naour <romain.naour@smile.fr>

Best regards,
Romain

> +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
> +
>  config BR2_PACKAGE_MPD_LIBMPDCLIENT
>  	bool "libmpdclient"
>  	select BR2_PACKAGE_LIBMPDCLIENT
> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
> index a55e4adde2..a0cebedc64 100644
> --- a/package/mpd/mpd.mk
> +++ b/package/mpd/mpd.mk
> @@ -119,6 +119,13 @@ else
>  MPD_CONF_OPTS += -Did3tag=disabled
>  endif
>  
> +ifeq ($(BR2_PACKAGE_MPD_IO_URING),y)
> +MPD_DEPENDENCIES += liburing
> +MPD_CONF_OPTS += -Dio_uring=enabled
> +else
> +MPD_CONF_OPTS += -Dio_uring=disabled
> +endif
> +
>  ifeq ($(BR2_PACKAGE_MPD_JACK2),y)
>  MPD_DEPENDENCIES += jack2
>  MPD_CONF_OPTS += -Djack=enabled

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/mpd: add io_uring optional dependency
  2022-07-24 14:09 ` Romain Naour
@ 2022-07-25 12:30   ` Andreas Ziegler
  2022-07-25 22:22     ` Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Ziegler @ 2022-07-25 12:30 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour, Jörg Krause, Andreas Ziegler

Since version 0.22 mpd provides an option to use the io_uring kernel interface 
for asynchronous access to local files. Buildroot has the necessary library 
(package/liburing) since commit 03ca6f4e39874583060317e7e15e9e360220877e.

Add an optional dependency on liburing to enable asynchronous file access using 
the kernel io_uring interface.

Signed-off-by: Andreas Ziegler <br015@umbiko.net>
Reviewed-by: Romain Naour <romain.naour@smile.fr>
---
Changes v1 -> v2:
  Commit message (Romain Naour)
  Dependency comment (Romain Naour)
  Modify patch description to match commit message

 package/mpd/Config.in | 10 ++++++++++
 package/mpd/mpd.mk    |  7 +++++++
 2 files changed, 17 insertions(+)

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index fc0f409448..8f0af7b2d3 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -347,6 +347,16 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
 comment "avahi support needs a toolchain w/ dynamic library"
 	depends on BR2_STATIC_LIBS
 
+config BR2_PACKAGE_MPD_IO_URING
+	bool "io_uring"
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
+	select BR2_PACKAGE_LIBURING
+	help
+	  Asynchronous I/O using kernel io_uring subsystem
+
+comment "io_uring support needs a toolchain w/ headers >= 5.1"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
+
 config BR2_PACKAGE_MPD_LIBMPDCLIENT
 	bool "libmpdclient"
 	select BR2_PACKAGE_LIBMPDCLIENT
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index e265a9fc4f..c21426b873 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -119,6 +119,13 @@ else
 MPD_CONF_OPTS += -Did3tag=disabled
 endif
 
+ifeq ($(BR2_PACKAGE_MPD_IO_URING),y)
+MPD_DEPENDENCIES += liburing
+MPD_CONF_OPTS += -Dio_uring=enabled
+else
+MPD_CONF_OPTS += -Dio_uring=disabled
+endif
+
 ifeq ($(BR2_PACKAGE_MPD_JACK2),y)
 MPD_DEPENDENCIES += jack2
 MPD_CONF_OPTS += -Djack=enabled
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/mpd: add io_uring optional dependency
  2022-07-25 12:30   ` [Buildroot] [PATCH v2 1/1] package/mpd: add io_uring optional dependency Andreas Ziegler
@ 2022-07-25 22:22     ` Arnout Vandecappelle
  0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2022-07-25 22:22 UTC (permalink / raw)
  To: Andreas Ziegler, buildroot; +Cc: Romain Naour, Jörg Krause



On 25/07/2022 14:30, Andreas Ziegler wrote:
> Since version 0.22 mpd provides an option to use the io_uring kernel interface
> for asynchronous access to local files. Buildroot has the necessary library
> (package/liburing) since commit 03ca6f4e39874583060317e7e15e9e360220877e.
> 
> Add an optional dependency on liburing to enable asynchronous file access using
> the kernel io_uring interface.
> 
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> Reviewed-by: Romain Naour <romain.naour@smile.fr>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
> Changes v1 -> v2:
>    Commit message (Romain Naour)
>    Dependency comment (Romain Naour)
>    Modify patch description to match commit message
> 
>   package/mpd/Config.in | 10 ++++++++++
>   package/mpd/mpd.mk    |  7 +++++++
>   2 files changed, 17 insertions(+)
> 
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index fc0f409448..8f0af7b2d3 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -347,6 +347,16 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
>   comment "avahi support needs a toolchain w/ dynamic library"
>   	depends on BR2_STATIC_LIBS
>   
> +config BR2_PACKAGE_MPD_IO_URING
> +	bool "io_uring"
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
> +	select BR2_PACKAGE_LIBURING
> +	help
> +	  Asynchronous I/O using kernel io_uring subsystem
> +
> +comment "io_uring support needs a toolchain w/ headers >= 5.1"
> +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
> +
>   config BR2_PACKAGE_MPD_LIBMPDCLIENT
>   	bool "libmpdclient"
>   	select BR2_PACKAGE_LIBMPDCLIENT
> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
> index e265a9fc4f..c21426b873 100644
> --- a/package/mpd/mpd.mk
> +++ b/package/mpd/mpd.mk
> @@ -119,6 +119,13 @@ else
>   MPD_CONF_OPTS += -Did3tag=disabled
>   endif
>   
> +ifeq ($(BR2_PACKAGE_MPD_IO_URING),y)
> +MPD_DEPENDENCIES += liburing
> +MPD_CONF_OPTS += -Dio_uring=enabled
> +else
> +MPD_CONF_OPTS += -Dio_uring=disabled
> +endif
> +
>   ifeq ($(BR2_PACKAGE_MPD_JACK2),y)
>   MPD_DEPENDENCIES += jack2
>   MPD_CONF_OPTS += -Djack=enabled
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-25 22:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 15:49 [Buildroot] [PATCH 1/1] package/mpd: add option for async file access using io_uring Andreas Ziegler
2022-07-24 14:09 ` Romain Naour
2022-07-25 12:30   ` [Buildroot] [PATCH v2 1/1] package/mpd: add io_uring optional dependency Andreas Ziegler
2022-07-25 22:22     ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.