* [PATCH] [net-next] ipa: add remoteproc dependency
@ 2021-01-25 11:35 Arnd Bergmann
2021-01-25 15:23 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-25 11:35 UTC (permalink / raw)
To: Alex Elder, David S. Miller, Jakub Kicinski, Bjorn Andersson
Cc: Arnd Bergmann, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Compile-testing without CONFIG_REMOTEPROC results in a build failure:
>>> referenced by ipa_main.c
>>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
ld.lld: error: undefined symbol: rproc_put
>>> referenced by ipa_main.c
>>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
>>> referenced by ipa_main.c
>>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
Add a new dependency to avoid this.
Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ipa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
index b68f1289b89e..aa1c0ae3cf01 100644
--- a/drivers/net/ipa/Kconfig
+++ b/drivers/net/ipa/Kconfig
@@ -3,6 +3,7 @@ config QCOM_IPA
depends on 64BIT && NET && QCOM_SMEM
depends on ARCH_QCOM || COMPILE_TEST
depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
+ depends on REMOTEPROC
select QCOM_MDT_LOADER if ARCH_QCOM
select QCOM_QMI_HELPERS
help
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [net-next] ipa: add remoteproc dependency
2021-01-25 11:35 [PATCH] [net-next] ipa: add remoteproc dependency Arnd Bergmann
@ 2021-01-25 15:23 ` Bjorn Andersson
2021-01-25 15:30 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2021-01-25 15:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alex Elder, David S. Miller, Jakub Kicinski, Arnd Bergmann,
netdev, linux-kernel
On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing without CONFIG_REMOTEPROC results in a build failure:
>
> >>> referenced by ipa_main.c
> >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> ld.lld: error: undefined symbol: rproc_put
> >>> referenced by ipa_main.c
> >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> >>> referenced by ipa_main.c
> >>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
>
> Add a new dependency to avoid this.
>
Afaict this should be addressed by:
86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")
which is present in linux-next.
Regards,
Bjorn
> Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ipa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
> index b68f1289b89e..aa1c0ae3cf01 100644
> --- a/drivers/net/ipa/Kconfig
> +++ b/drivers/net/ipa/Kconfig
> @@ -3,6 +3,7 @@ config QCOM_IPA
> depends on 64BIT && NET && QCOM_SMEM
> depends on ARCH_QCOM || COMPILE_TEST
> depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
> + depends on REMOTEPROC
> select QCOM_MDT_LOADER if ARCH_QCOM
> select QCOM_QMI_HELPERS
> help
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [net-next] ipa: add remoteproc dependency
2021-01-25 15:23 ` Bjorn Andersson
@ 2021-01-25 15:30 ` Arnd Bergmann
2021-01-25 15:33 ` Alex Elder
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-25 15:30 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Alex Elder, David S. Miller, Jakub Kicinski, Arnd Bergmann,
Networking, linux-kernel
On Mon, Jan 25, 2021 at 4:23 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote:
>
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Compile-testing without CONFIG_REMOTEPROC results in a build failure:
> >
> > >>> referenced by ipa_main.c
> > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> > ld.lld: error: undefined symbol: rproc_put
> > >>> referenced by ipa_main.c
> > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> > >>> referenced by ipa_main.c
> > >>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
> >
> > Add a new dependency to avoid this.
> >
>
> Afaict this should be addressed by:
>
> 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")
>
> which is present in linux-next.
Ok, good. I was testing with next-20210122, which was
still lacking that commit.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [net-next] ipa: add remoteproc dependency
2021-01-25 15:30 ` Arnd Bergmann
@ 2021-01-25 15:33 ` Alex Elder
0 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2021-01-25 15:33 UTC (permalink / raw)
To: Arnd Bergmann, Bjorn Andersson
Cc: Alex Elder, David S. Miller, Jakub Kicinski, Arnd Bergmann,
Networking, linux-kernel
On 1/25/21 9:30 AM, Arnd Bergmann wrote:
> On Mon, Jan 25, 2021 at 4:23 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>>
>> On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote:
>>
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Compile-testing without CONFIG_REMOTEPROC results in a build failure:
>>>
>>>>>> referenced by ipa_main.c
>>>>>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
>>> ld.lld: error: undefined symbol: rproc_put
>>>>>> referenced by ipa_main.c
>>>>>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
>>>>>> referenced by ipa_main.c
>>>>>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
>>>
>>> Add a new dependency to avoid this.
>>>
>>
>> Afaict this should be addressed by:
>>
>> 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")
>>
>> which is present in linux-next.
>
> Ok, good. I was testing with next-20210122, which was
> still lacking that commit.
Yes, for various reasons this took a while to get incorporated.
It just got accepted over the weekend. Thanks for mentioning it.
-Alex
>
> Arnd
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26 19:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 11:35 [PATCH] [net-next] ipa: add remoteproc dependency Arnd Bergmann
2021-01-25 15:23 ` Bjorn Andersson
2021-01-25 15:30 ` Arnd Bergmann
2021-01-25 15:33 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.