* [PATCH 0/2] Add R8A77980/V3HSK GEther support
@ 2018-05-18 19:37 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-18 19:37 UTC (permalink / raw)
To: Rob Herring, Catalin Marinas, Will Deacon, Simon Horman,
devicetree, linux-renesas-soc
Cc: Mark Rutland, Magnus Damm, linux-arm-kernel
Hello!
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20180518-v4.17-rc5' tag plus the R8A77980 SMP support patch.
I'm adding the device tree support for mounting the NFS root on the R8A77980-
based V3H Starter Kit board. The 'sh_eth' driver patches adding R8A77980
GEther support patches needed for these 2 patches to work have been posted
and are close to be merged...
[1/2] arm64: dts: renesas: r8a77980: add GEther support
[2/2] arm64: dts: renesas: v3hsk: add GEther support
WBR, Sergei
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 0/2] Add R8A77980/V3HSK GEther support
@ 2018-05-18 19:37 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-18 19:37 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20180518-v4.17-rc5' tag plus the R8A77980 SMP support patch.
I'm adding the device tree support for mounting the NFS root on the R8A77980-
based V3H Starter Kit board. The 'sh_eth' driver patches adding R8A77980
GEther support patches needed for these 2 patches to work have been posted
and are close to be merged...
[1/2] arm64: dts: renesas: r8a77980: add GEther support
[2/2] arm64: dts: renesas: v3hsk: add GEther support
WBR, Sergei
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
2018-05-18 19:37 ` Sergei Shtylyov
@ 2018-05-18 19:45 ` Sergei Shtylyov
-1 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-18 19:45 UTC (permalink / raw)
To: Rob Herring, Catalin Marinas, Will Deacon, Simon Horman,
devicetree, linux-renesas-soc
Cc: Mark Rutland, Magnus Damm, linux-arm-kernel
Define the generic R8A77980 part of the GEther device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -417,6 +417,17 @@
dma-channels = <16>;
};
+ gether: ethernet@e7400000 {
+ compatible = "renesas,gether-r8a77980";
+ reg = <0 0xe7400000 0 0x1000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 813>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
mmc0: mmc@ee140000 {
compatible = "renesas,sdhi-r8a77980",
"renesas,rcar-gen3-sdhi";
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-18 19:45 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-18 19:45 UTC (permalink / raw)
To: linux-arm-kernel
Define the generic R8A77980 part of the GEther device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -417,6 +417,17 @@
dma-channels = <16>;
};
+ gether: ethernet at e7400000 {
+ compatible = "renesas,gether-r8a77980";
+ reg = <0 0xe7400000 0 0x1000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 813>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
mmc0: mmc at ee140000 {
compatible = "renesas,sdhi-r8a77980",
"renesas,rcar-gen3-sdhi";
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
2018-05-18 19:37 ` Sergei Shtylyov
@ 2018-05-18 19:46 ` Sergei Shtylyov
-1 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-18 19:46 UTC (permalink / raw)
To: Rob Herring, Catalin Marinas, Will Deacon, Simon Horman,
devicetree, linux-renesas-soc
Cc: Mark Rutland, Magnus Damm, linux-arm-kernel
Define the V3H Starter Kit board dependent part of the GEther device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
@@ -15,6 +15,7 @@
aliases {
serial0 = &scif0;
+ ethernet0 = &gether;
};
chosen {
@@ -36,7 +37,27 @@
clock-frequency = <32768>;
};
+&gether {
+ pinctrl-0 = <&gether_pins>;
+ pinctrl-names = "default";
+
+ phy-mode = "rgmii";
+ phy-handle = <&phy0>;
+ renesas,no-ether-link;
+ status = "okay";
+
+ phy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+};
+
&pfc {
+ gether_pins: gether {
+ groups = "gether_mdio_a", "gether_rgmii",
+ "gether_txcrefclk", "gether_txcrefclk_mega";
+ function = "gether";
+ };
+
scif0_pins: scif0 {
groups = "scif0_data";
function = "scif0";
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
@ 2018-05-18 19:46 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-18 19:46 UTC (permalink / raw)
To: linux-arm-kernel
Define the V3H Starter Kit board dependent part of the GEther device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
@@ -15,6 +15,7 @@
aliases {
serial0 = &scif0;
+ ethernet0 = &gether;
};
chosen {
@@ -36,7 +37,27 @@
clock-frequency = <32768>;
};
+&gether {
+ pinctrl-0 = <&gether_pins>;
+ pinctrl-names = "default";
+
+ phy-mode = "rgmii";
+ phy-handle = <&phy0>;
+ renesas,no-ether-link;
+ status = "okay";
+
+ phy0: ethernet-phy at 0 {
+ reg = <0>;
+ };
+};
+
&pfc {
+ gether_pins: gether {
+ groups = "gether_mdio_a", "gether_rgmii",
+ "gether_txcrefclk", "gether_txcrefclk_mega";
+ function = "gether";
+ };
+
scif0_pins: scif0 {
groups = "scif0_data";
function = "scif0";
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
2018-05-18 19:45 ` Sergei Shtylyov
(?)
@ 2018-05-22 8:52 ` Simon Horman
-1 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-22 8:52 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland, devicetree, Magnus Damm, Catalin Marinas,
Will Deacon, linux-renesas-soc, Rob Herring, linux-arm-kernel
On Fri, May 18, 2018 at 10:45:36PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77980 part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
This looks fine but I will wait to see if there are other reviews before
applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-22 8:52 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-22 8:52 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Rob Herring, Catalin Marinas, Will Deacon, devicetree,
linux-renesas-soc, Mark Rutland, Magnus Damm, linux-arm-kernel
On Fri, May 18, 2018 at 10:45:36PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77980 part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
This looks fine but I will wait to see if there are other reviews before
applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-22 8:52 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-22 8:52 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 18, 2018 at 10:45:36PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77980 part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
This looks fine but I will wait to see if there are other reviews before
applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
2018-05-18 19:46 ` Sergei Shtylyov
(?)
@ 2018-05-22 8:52 ` Simon Horman
-1 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-22 8:52 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland, devicetree, Magnus Damm, Catalin Marinas,
Will Deacon, linux-renesas-soc, Rob Herring, linux-arm-kernel
On Fri, May 18, 2018 at 10:46:19PM +0300, Sergei Shtylyov wrote:
> Define the V3H Starter Kit board dependent part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
This looks fine but I will wait to see if there are other reviews before
applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
@ 2018-05-22 8:52 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-22 8:52 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Rob Herring, Catalin Marinas, Will Deacon, devicetree,
linux-renesas-soc, Mark Rutland, Magnus Damm, linux-arm-kernel
On Fri, May 18, 2018 at 10:46:19PM +0300, Sergei Shtylyov wrote:
> Define the V3H Starter Kit board dependent part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
This looks fine but I will wait to see if there are other reviews before
applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
@ 2018-05-22 8:52 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-22 8:52 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 18, 2018 at 10:46:19PM +0300, Sergei Shtylyov wrote:
> Define the V3H Starter Kit board dependent part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
This looks fine but I will wait to see if there are other reviews before
applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
2018-05-18 19:45 ` Sergei Shtylyov
(?)
@ 2018-05-22 11:48 ` Geert Uytterhoeven
-1 siblings, 0 replies; 30+ messages in thread
From: Geert Uytterhoeven @ 2018-05-22 11:48 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Simon Horman, Catalin Marinas, Will Deacon,
Linux-Renesas, Rob Herring, Linux ARM
Hi Sergei,
On Fri, May 18, 2018 at 9:45 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A77980 part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
With the below addressed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -417,6 +417,17 @@
> dma-channels = <16>;
> };
>
> + gether: ethernet@e7400000 {
> + compatible = "renesas,gether-r8a77980";
> + reg = <0 0xe7400000 0 0x1000>;
> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 813>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
resets = <&cpg 813>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
Any default phy-mode needed?
> + };
> +
> mmc0: mmc@ee140000 {
> compatible = "renesas,sdhi-r8a77980",
> "renesas,rcar-gen3-sdhi";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-22 11:48 ` Geert Uytterhoeven
0 siblings, 0 replies; 30+ messages in thread
From: Geert Uytterhoeven @ 2018-05-22 11:48 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Rob Herring, Catalin Marinas, Will Deacon, Simon Horman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Mark Rutland, Magnus Damm, Linux ARM
Hi Sergei,
On Fri, May 18, 2018 at 9:45 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A77980 part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
With the below addressed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -417,6 +417,17 @@
> dma-channels = <16>;
> };
>
> + gether: ethernet@e7400000 {
> + compatible = "renesas,gether-r8a77980";
> + reg = <0 0xe7400000 0 0x1000>;
> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 813>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
resets = <&cpg 813>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
Any default phy-mode needed?
> + };
> +
> mmc0: mmc@ee140000 {
> compatible = "renesas,sdhi-r8a77980",
> "renesas,rcar-gen3-sdhi";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-22 11:48 ` Geert Uytterhoeven
0 siblings, 0 replies; 30+ messages in thread
From: Geert Uytterhoeven @ 2018-05-22 11:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Fri, May 18, 2018 at 9:45 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A77980 part of the GEther device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
With the below addressed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -417,6 +417,17 @@
> dma-channels = <16>;
> };
>
> + gether: ethernet at e7400000 {
> + compatible = "renesas,gether-r8a77980";
> + reg = <0 0xe7400000 0 0x1000>;
> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 813>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
resets = <&cpg 813>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
Any default phy-mode needed?
> + };
> +
> mmc0: mmc at ee140000 {
> compatible = "renesas,sdhi-r8a77980",
> "renesas,rcar-gen3-sdhi";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
2018-05-22 11:48 ` Geert Uytterhoeven
(?)
@ 2018-05-22 15:44 ` Sergei Shtylyov
-1 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-22 15:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Simon Horman, Catalin Marinas, Will Deacon,
Linux-Renesas, Rob Herring, Linux ARM
On 05/22/2018 02:48 PM, Geert Uytterhoeven wrote:
>> Define the generic R8A77980 part of the GEther device node.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks for your patch!
>
> With the below addressed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> @@ -417,6 +417,17 @@
>> dma-channels = <16>;
>> };
>>
>> + gether: ethernet@e7400000 {
>> + compatible = "renesas,gether-r8a77980";
>> + reg = <0 0xe7400000 0 0x1000>;
>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 813>;
>> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>
> resets = <&cpg 813>;
As usual...
>
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "disabled";
>
> Any default phy-mode needed?
A default "phy-mode" IMO make sense when the MAC supports a single
PHY interface mode. In this case, both RMII and RGMII are supported, so
I coulsn't choose a default...
>> + };
>> +
>> mmc0: mmc@ee140000 {
>> compatible = "renesas,sdhi-r8a77980",
>> "renesas,rcar-gen3-sdhi";
>
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-22 15:44 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-22 15:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Catalin Marinas, Will Deacon, Simon Horman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Mark Rutland, Magnus Damm, Linux ARM
On 05/22/2018 02:48 PM, Geert Uytterhoeven wrote:
>> Define the generic R8A77980 part of the GEther device node.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks for your patch!
>
> With the below addressed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> @@ -417,6 +417,17 @@
>> dma-channels = <16>;
>> };
>>
>> + gether: ethernet@e7400000 {
>> + compatible = "renesas,gether-r8a77980";
>> + reg = <0 0xe7400000 0 0x1000>;
>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 813>;
>> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>
> resets = <&cpg 813>;
As usual...
>
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "disabled";
>
> Any default phy-mode needed?
A default "phy-mode" IMO make sense when the MAC supports a single
PHY interface mode. In this case, both RMII and RGMII are supported, so
I coulsn't choose a default...
>> + };
>> +
>> mmc0: mmc@ee140000 {
>> compatible = "renesas,sdhi-r8a77980",
>> "renesas,rcar-gen3-sdhi";
>
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-22 15:44 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-22 15:44 UTC (permalink / raw)
To: linux-arm-kernel
On 05/22/2018 02:48 PM, Geert Uytterhoeven wrote:
>> Define the generic R8A77980 part of the GEther device node.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks for your patch!
>
> With the below addressed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> @@ -417,6 +417,17 @@
>> dma-channels = <16>;
>> };
>>
>> + gether: ethernet at e7400000 {
>> + compatible = "renesas,gether-r8a77980";
>> + reg = <0 0xe7400000 0 0x1000>;
>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 813>;
>> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>
> resets = <&cpg 813>;
As usual...
>
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "disabled";
>
> Any default phy-mode needed?
A default "phy-mode" IMO make sense when the MAC supports a single
PHY interface mode. In this case, both RMII and RGMII are supported, so
I coulsn't choose a default...
>> + };
>> +
>> mmc0: mmc at ee140000 {
>> compatible = "renesas,sdhi-r8a77980",
>> "renesas,rcar-gen3-sdhi";
>
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
2018-05-22 15:44 ` Sergei Shtylyov
(?)
@ 2018-05-23 8:41 ` Simon Horman
-1 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 8:41 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Catalin Marinas, Will Deacon, Linux-Renesas,
Rob Herring, Geert Uytterhoeven, Linux ARM
On Tue, May 22, 2018 at 06:44:59PM +0300, Sergei Shtylyov wrote:
> On 05/22/2018 02:48 PM, Geert Uytterhoeven wrote:
>
> >> Define the generic R8A77980 part of the GEther device node.
> >>
> >> Based on the original (and large) patch by Vladimir Barinov.
> >>
> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > Thanks for your patch!
> >
> > With the below addressed:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks!
>
> >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> @@ -417,6 +417,17 @@
> >> dma-channels = <16>;
> >> };
> >>
> >> + gether: ethernet@e7400000 {
> >> + compatible = "renesas,gether-r8a77980";
> >> + reg = <0 0xe7400000 0 0x1000>;
> >> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&cpg CPG_MOD 813>;
> >> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> >
> > resets = <&cpg 813>;
>
> As usual...
>
> >
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + status = "disabled";
> >
> > Any default phy-mode needed?
>
> A default "phy-mode" IMO make sense when the MAC supports a single
> PHY interface mode. In this case, both RMII and RGMII are supported, so
> I coulsn't choose a default...
I would think making an arbitrary choice is better than no choice.
How does the driver behave in the absence of a default?
>
> >> + };
> >> +
> >> mmc0: mmc@ee140000 {
> >> compatible = "renesas,sdhi-r8a77980",
> >> "renesas,rcar-gen3-sdhi";
> >
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-23 8:41 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 8:41 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Geert Uytterhoeven, Rob Herring, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Mark Rutland, Magnus Damm, Linux ARM
On Tue, May 22, 2018 at 06:44:59PM +0300, Sergei Shtylyov wrote:
> On 05/22/2018 02:48 PM, Geert Uytterhoeven wrote:
>
> >> Define the generic R8A77980 part of the GEther device node.
> >>
> >> Based on the original (and large) patch by Vladimir Barinov.
> >>
> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > Thanks for your patch!
> >
> > With the below addressed:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks!
>
> >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> @@ -417,6 +417,17 @@
> >> dma-channels = <16>;
> >> };
> >>
> >> + gether: ethernet@e7400000 {
> >> + compatible = "renesas,gether-r8a77980";
> >> + reg = <0 0xe7400000 0 0x1000>;
> >> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&cpg CPG_MOD 813>;
> >> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> >
> > resets = <&cpg 813>;
>
> As usual...
>
> >
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + status = "disabled";
> >
> > Any default phy-mode needed?
>
> A default "phy-mode" IMO make sense when the MAC supports a single
> PHY interface mode. In this case, both RMII and RGMII are supported, so
> I coulsn't choose a default...
I would think making an arbitrary choice is better than no choice.
How does the driver behave in the absence of a default?
>
> >> + };
> >> +
> >> mmc0: mmc@ee140000 {
> >> compatible = "renesas,sdhi-r8a77980",
> >> "renesas,rcar-gen3-sdhi";
> >
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-23 8:41 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 8:41 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 22, 2018 at 06:44:59PM +0300, Sergei Shtylyov wrote:
> On 05/22/2018 02:48 PM, Geert Uytterhoeven wrote:
>
> >> Define the generic R8A77980 part of the GEther device node.
> >>
> >> Based on the original (and large) patch by Vladimir Barinov.
> >>
> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > Thanks for your patch!
> >
> > With the below addressed:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks!
>
> >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> @@ -417,6 +417,17 @@
> >> dma-channels = <16>;
> >> };
> >>
> >> + gether: ethernet at e7400000 {
> >> + compatible = "renesas,gether-r8a77980";
> >> + reg = <0 0xe7400000 0 0x1000>;
> >> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&cpg CPG_MOD 813>;
> >> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> >
> > resets = <&cpg 813>;
>
> As usual...
>
> >
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + status = "disabled";
> >
> > Any default phy-mode needed?
>
> A default "phy-mode" IMO make sense when the MAC supports a single
> PHY interface mode. In this case, both RMII and RGMII are supported, so
> I coulsn't choose a default...
I would think making an arbitrary choice is better than no choice.
How does the driver behave in the absence of a default?
>
> >> + };
> >> +
> >> mmc0: mmc at ee140000 {
> >> compatible = "renesas,sdhi-r8a77980",
> >> "renesas,rcar-gen3-sdhi";
> >
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
2018-05-23 8:41 ` Simon Horman
(?)
@ 2018-05-23 9:05 ` Sergei Shtylyov
-1 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-23 9:05 UTC (permalink / raw)
To: Simon Horman
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Catalin Marinas, Will Deacon, Linux-Renesas,
Rob Herring, Geert Uytterhoeven, Linux ARM
Hello!
On 5/23/2018 11:41 AM, Simon Horman wrote:
>>>> Define the generic R8A77980 part of the GEther device node.
>>>>
>>>> Based on the original (and large) patch by Vladimir Barinov.
>>>>
>>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> Thanks for your patch!
>>>
>>> With the below addressed:
>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> Thanks!
>>
>>>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>>>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>>>> @@ -417,6 +417,17 @@
>>>> dma-channels = <16>;
>>>> };
>>>>
>>>> + gether: ethernet@e7400000 {
>>>> + compatible = "renesas,gether-r8a77980";
>>>> + reg = <0 0xe7400000 0 0x1000>;
>>>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>>>> + clocks = <&cpg CPG_MOD 813>;
>>>> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>>>
>>> resets = <&cpg 813>;
>>
>> As usual...
>>
>>>
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> + status = "disabled";
>>>
>>> Any default phy-mode needed?
>>
>> A default "phy-mode" IMO make sense when the MAC supports a single
>> PHY interface mode. In this case, both RMII and RGMII are supported, so
>> I coulsn't choose a default...
>
> I would think making an arbitrary choice is better than no choice.
> How does the driver behave in the absence of a default?
The board DT *must* assign some "phy-mode" -- it's a required prop.
In this particular case, iff the mode is still unspecified, the driver
will select the MII mode for the RMII_MII reg (which is a reserved value for
this GEther)...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-23 9:05 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-23 9:05 UTC (permalink / raw)
To: Simon Horman
Cc: Geert Uytterhoeven, Rob Herring, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Mark Rutland, Magnus Damm, Linux ARM
Hello!
On 5/23/2018 11:41 AM, Simon Horman wrote:
>>>> Define the generic R8A77980 part of the GEther device node.
>>>>
>>>> Based on the original (and large) patch by Vladimir Barinov.
>>>>
>>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> Thanks for your patch!
>>>
>>> With the below addressed:
>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> Thanks!
>>
>>>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>>>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>>>> @@ -417,6 +417,17 @@
>>>> dma-channels = <16>;
>>>> };
>>>>
>>>> + gether: ethernet@e7400000 {
>>>> + compatible = "renesas,gether-r8a77980";
>>>> + reg = <0 0xe7400000 0 0x1000>;
>>>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>>>> + clocks = <&cpg CPG_MOD 813>;
>>>> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>>>
>>> resets = <&cpg 813>;
>>
>> As usual...
>>
>>>
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> + status = "disabled";
>>>
>>> Any default phy-mode needed?
>>
>> A default "phy-mode" IMO make sense when the MAC supports a single
>> PHY interface mode. In this case, both RMII and RGMII are supported, so
>> I coulsn't choose a default...
>
> I would think making an arbitrary choice is better than no choice.
> How does the driver behave in the absence of a default?
The board DT *must* assign some "phy-mode" -- it's a required prop.
In this particular case, iff the mode is still unspecified, the driver
will select the MII mode for the RMII_MII reg (which is a reserved value for
this GEther)...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-23 9:05 ` Sergei Shtylyov
0 siblings, 0 replies; 30+ messages in thread
From: Sergei Shtylyov @ 2018-05-23 9:05 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 5/23/2018 11:41 AM, Simon Horman wrote:
>>>> Define the generic R8A77980 part of the GEther device node.
>>>>
>>>> Based on the original (and large) patch by Vladimir Barinov.
>>>>
>>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> Thanks for your patch!
>>>
>>> With the below addressed:
>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> Thanks!
>>
>>>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>>>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>>>> @@ -417,6 +417,17 @@
>>>> dma-channels = <16>;
>>>> };
>>>>
>>>> + gether: ethernet at e7400000 {
>>>> + compatible = "renesas,gether-r8a77980";
>>>> + reg = <0 0xe7400000 0 0x1000>;
>>>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>>>> + clocks = <&cpg CPG_MOD 813>;
>>>> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>>>
>>> resets = <&cpg 813>;
>>
>> As usual...
>>
>>>
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> + status = "disabled";
>>>
>>> Any default phy-mode needed?
>>
>> A default "phy-mode" IMO make sense when the MAC supports a single
>> PHY interface mode. In this case, both RMII and RGMII are supported, so
>> I coulsn't choose a default...
>
> I would think making an arbitrary choice is better than no choice.
> How does the driver behave in the absence of a default?
The board DT *must* assign some "phy-mode" -- it's a required prop.
In this particular case, iff the mode is still unspecified, the driver
will select the MII mode for the RMII_MII reg (which is a reserved value for
this GEther)...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
2018-05-23 9:05 ` Sergei Shtylyov
(?)
@ 2018-05-23 9:18 ` Simon Horman
-1 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 9:18 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Catalin Marinas, Will Deacon, Linux-Renesas,
Rob Herring, Geert Uytterhoeven, Linux ARM
On Wed, May 23, 2018 at 12:05:30PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 5/23/2018 11:41 AM, Simon Horman wrote:
>
> > > > > Define the generic R8A77980 part of the GEther device node.
> > > > >
> > > > > Based on the original (and large) patch by Vladimir Barinov.
> > > > >
> > > > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > With the below addressed:
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > Thanks!
> > >
> > > > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > > > @@ -417,6 +417,17 @@
> > > > > dma-channels = <16>;
> > > > > };
> > > > >
> > > > > + gether: ethernet@e7400000 {
> > > > > + compatible = "renesas,gether-r8a77980";
> > > > > + reg = <0 0xe7400000 0 0x1000>;
> > > > > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> > > > > + clocks = <&cpg CPG_MOD 813>;
> > > > > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> > > >
> > > > resets = <&cpg 813>;
> > >
> > > As usual...
> > >
> > > >
> > > > > + #address-cells = <1>;
> > > > > + #size-cells = <0>;
> > > > > + status = "disabled";
> > > >
> > > > Any default phy-mode needed?
> > >
> > > A default "phy-mode" IMO make sense when the MAC supports a single
> > > PHY interface mode. In this case, both RMII and RGMII are supported, so
> > > I coulsn't choose a default...
> >
> > I would think making an arbitrary choice is better than no choice.
> > How does the driver behave in the absence of a default?
>
> The board DT *must* assign some "phy-mode" -- it's a required prop.
> In this particular case, iff the mode is still unspecified, the driver
> will select the MII mode for the RMII_MII reg (which is a reserved value for
> this GEther)...
Thanks, if its required that boards provide this property then
this makes sense to me.
I have applied the patch after adding the resets property.
The result is as follows:
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: [PATCH] arm64: dts: renesas: r8a77980: add GEther support
Define the generic R8A77980 part of the GEther device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
[simon: add resets property]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 6d2b61d83caf..c797db59ae18 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -417,6 +417,18 @@
dma-channels = <16>;
};
+ gether: ethernet@e7400000 {
+ compatible = "renesas,gether-r8a77980";
+ reg = <0 0xe7400000 0 0x1000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 813>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ resets = <&cpg 813>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
mmc0: mmc@ee140000 {
compatible = "renesas,sdhi-r8a77980",
"renesas,rcar-gen3-sdhi";
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-23 9:18 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 9:18 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Geert Uytterhoeven, Rob Herring, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Mark Rutland, Magnus Damm, Linux ARM
On Wed, May 23, 2018 at 12:05:30PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 5/23/2018 11:41 AM, Simon Horman wrote:
>
> > > > > Define the generic R8A77980 part of the GEther device node.
> > > > >
> > > > > Based on the original (and large) patch by Vladimir Barinov.
> > > > >
> > > > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > With the below addressed:
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > Thanks!
> > >
> > > > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > > > @@ -417,6 +417,17 @@
> > > > > dma-channels = <16>;
> > > > > };
> > > > >
> > > > > + gether: ethernet@e7400000 {
> > > > > + compatible = "renesas,gether-r8a77980";
> > > > > + reg = <0 0xe7400000 0 0x1000>;
> > > > > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> > > > > + clocks = <&cpg CPG_MOD 813>;
> > > > > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> > > >
> > > > resets = <&cpg 813>;
> > >
> > > As usual...
> > >
> > > >
> > > > > + #address-cells = <1>;
> > > > > + #size-cells = <0>;
> > > > > + status = "disabled";
> > > >
> > > > Any default phy-mode needed?
> > >
> > > A default "phy-mode" IMO make sense when the MAC supports a single
> > > PHY interface mode. In this case, both RMII and RGMII are supported, so
> > > I coulsn't choose a default...
> >
> > I would think making an arbitrary choice is better than no choice.
> > How does the driver behave in the absence of a default?
>
> The board DT *must* assign some "phy-mode" -- it's a required prop.
> In this particular case, iff the mode is still unspecified, the driver
> will select the MII mode for the RMII_MII reg (which is a reserved value for
> this GEther)...
Thanks, if its required that boards provide this property then
this makes sense to me.
I have applied the patch after adding the resets property.
The result is as follows:
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: [PATCH] arm64: dts: renesas: r8a77980: add GEther support
Define the generic R8A77980 part of the GEther device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
[simon: add resets property]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 6d2b61d83caf..c797db59ae18 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -417,6 +417,18 @@
dma-channels = <16>;
};
+ gether: ethernet@e7400000 {
+ compatible = "renesas,gether-r8a77980";
+ reg = <0 0xe7400000 0 0x1000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 813>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ resets = <&cpg 813>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
mmc0: mmc@ee140000 {
compatible = "renesas,sdhi-r8a77980",
"renesas,rcar-gen3-sdhi";
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support
@ 2018-05-23 9:18 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 9:18 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 23, 2018 at 12:05:30PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 5/23/2018 11:41 AM, Simon Horman wrote:
>
> > > > > Define the generic R8A77980 part of the GEther device node.
> > > > >
> > > > > Based on the original (and large) patch by Vladimir Barinov.
> > > > >
> > > > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > With the below addressed:
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > Thanks!
> > >
> > > > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > > > @@ -417,6 +417,17 @@
> > > > > dma-channels = <16>;
> > > > > };
> > > > >
> > > > > + gether: ethernet at e7400000 {
> > > > > + compatible = "renesas,gether-r8a77980";
> > > > > + reg = <0 0xe7400000 0 0x1000>;
> > > > > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> > > > > + clocks = <&cpg CPG_MOD 813>;
> > > > > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> > > >
> > > > resets = <&cpg 813>;
> > >
> > > As usual...
> > >
> > > >
> > > > > + #address-cells = <1>;
> > > > > + #size-cells = <0>;
> > > > > + status = "disabled";
> > > >
> > > > Any default phy-mode needed?
> > >
> > > A default "phy-mode" IMO make sense when the MAC supports a single
> > > PHY interface mode. In this case, both RMII and RGMII are supported, so
> > > I coulsn't choose a default...
> >
> > I would think making an arbitrary choice is better than no choice.
> > How does the driver behave in the absence of a default?
>
> The board DT *must* assign some "phy-mode" -- it's a required prop.
> In this particular case, iff the mode is still unspecified, the driver
> will select the MII mode for the RMII_MII reg (which is a reserved value for
> this GEther)...
Thanks, if its required that boards provide this property then
this makes sense to me.
I have applied the patch after adding the resets property.
The result is as follows:
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: [PATCH] arm64: dts: renesas: r8a77980: add GEther support
Define the generic R8A77980 part of the GEther device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
[simon: add resets property]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 6d2b61d83caf..c797db59ae18 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -417,6 +417,18 @@
dma-channels = <16>;
};
+ gether: ethernet at e7400000 {
+ compatible = "renesas,gether-r8a77980";
+ reg = <0 0xe7400000 0 0x1000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 813>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ resets = <&cpg 813>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
mmc0: mmc at ee140000 {
compatible = "renesas,sdhi-r8a77980",
"renesas,rcar-gen3-sdhi";
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
2018-05-22 8:52 ` Simon Horman
(?)
@ 2018-05-23 9:18 ` Simon Horman
-1 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 9:18 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland, devicetree, Magnus Damm, Catalin Marinas,
Will Deacon, linux-renesas-soc, Rob Herring, linux-arm-kernel
On Tue, May 22, 2018 at 10:52:21AM +0200, Simon Horman wrote:
> On Fri, May 18, 2018 at 10:46:19PM +0300, Sergei Shtylyov wrote:
> > Define the V3H Starter Kit board dependent part of the GEther device node.
> >
> > Based on the original (and large) patch by Vladimir Barinov.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> This looks fine but I will wait to see if there are other reviews before
> applying.
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Applied.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
@ 2018-05-23 9:18 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 9:18 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Rob Herring, Catalin Marinas, Will Deacon, devicetree,
linux-renesas-soc, Mark Rutland, Magnus Damm, linux-arm-kernel
On Tue, May 22, 2018 at 10:52:21AM +0200, Simon Horman wrote:
> On Fri, May 18, 2018 at 10:46:19PM +0300, Sergei Shtylyov wrote:
> > Define the V3H Starter Kit board dependent part of the GEther device node.
> >
> > Based on the original (and large) patch by Vladimir Barinov.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> This looks fine but I will wait to see if there are other reviews before
> applying.
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Applied.
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support
@ 2018-05-23 9:18 ` Simon Horman
0 siblings, 0 replies; 30+ messages in thread
From: Simon Horman @ 2018-05-23 9:18 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 22, 2018 at 10:52:21AM +0200, Simon Horman wrote:
> On Fri, May 18, 2018 at 10:46:19PM +0300, Sergei Shtylyov wrote:
> > Define the V3H Starter Kit board dependent part of the GEther device node.
> >
> > Based on the original (and large) patch by Vladimir Barinov.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> This looks fine but I will wait to see if there are other reviews before
> applying.
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Applied.
^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2018-05-23 9:19 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18 19:37 [PATCH 0/2] Add R8A77980/V3HSK GEther support Sergei Shtylyov
2018-05-18 19:37 ` Sergei Shtylyov
2018-05-18 19:45 ` [PATCH 1/2] arm64: dts: renesas: r8a77980: add " Sergei Shtylyov
2018-05-18 19:45 ` Sergei Shtylyov
2018-05-22 8:52 ` Simon Horman
2018-05-22 8:52 ` Simon Horman
2018-05-22 8:52 ` Simon Horman
2018-05-22 11:48 ` Geert Uytterhoeven
2018-05-22 11:48 ` Geert Uytterhoeven
2018-05-22 11:48 ` Geert Uytterhoeven
2018-05-22 15:44 ` Sergei Shtylyov
2018-05-22 15:44 ` Sergei Shtylyov
2018-05-22 15:44 ` Sergei Shtylyov
2018-05-23 8:41 ` Simon Horman
2018-05-23 8:41 ` Simon Horman
2018-05-23 8:41 ` Simon Horman
2018-05-23 9:05 ` Sergei Shtylyov
2018-05-23 9:05 ` Sergei Shtylyov
2018-05-23 9:05 ` Sergei Shtylyov
2018-05-23 9:18 ` Simon Horman
2018-05-23 9:18 ` Simon Horman
2018-05-23 9:18 ` Simon Horman
2018-05-18 19:46 ` [PATCH 2/2] arm64: dts: renesas: v3hsk: " Sergei Shtylyov
2018-05-18 19:46 ` Sergei Shtylyov
2018-05-22 8:52 ` Simon Horman
2018-05-22 8:52 ` Simon Horman
2018-05-22 8:52 ` Simon Horman
2018-05-23 9:18 ` Simon Horman
2018-05-23 9:18 ` Simon Horman
2018-05-23 9:18 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.