* [PATCH] igc: check return value of ret_val in igc_config_fc_after_link_up
@ 2021-01-07 6:10 ` Kevin Lo
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Lo @ 2021-01-07 6:10 UTC (permalink / raw)
To: netdev, intel-wired-lan; +Cc: Jesse Brandeburg, Tony Nguyen, David S . Miller
Check return value from ret_val to make error check actually work.
Fixes: 4eb8080143a9 ("igc: Add setup link functionality")
Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
index 09cd0ec7ee87..67b8ffd21d8a 100644
--- a/drivers/net/ethernet/intel/igc/igc_mac.c
+++ b/drivers/net/ethernet/intel/igc/igc_mac.c
@@ -638,7 +638,7 @@ s32 igc_config_fc_after_link_up(struct igc_hw *hw)
}
out:
- return 0;
+ return ret_val;
}
/**
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Intel-wired-lan] [PATCH] igc: check return value of ret_val in igc_config_fc_after_link_up
@ 2021-01-07 6:10 ` Kevin Lo
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Lo @ 2021-01-07 6:10 UTC (permalink / raw)
To: intel-wired-lan
Check return value from ret_val to make error check actually work.
Fixes: 4eb8080143a9 ("igc: Add setup link functionality")
Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
index 09cd0ec7ee87..67b8ffd21d8a 100644
--- a/drivers/net/ethernet/intel/igc/igc_mac.c
+++ b/drivers/net/ethernet/intel/igc/igc_mac.c
@@ -638,7 +638,7 @@ s32 igc_config_fc_after_link_up(struct igc_hw *hw)
}
out:
- return 0;
+ return ret_val;
}
/**
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Intel-wired-lan] [PATCH] igc: check return value of ret_val in igc_config_fc_after_link_up
2021-01-07 6:10 ` [Intel-wired-lan] " Kevin Lo
(?)
@ 2021-01-09 16:57 ` Neftin, Sasha
-1 siblings, 0 replies; 3+ messages in thread
From: Neftin, Sasha @ 2021-01-09 16:57 UTC (permalink / raw)
To: intel-wired-lan
On 1/7/2021 08:10, Kevin Lo wrote:
> Check return value from ret_val to make error check actually work.
>
> Fixes: 4eb8080143a9 ("igc: Add setup link functionality")
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> ---
> diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
> index 09cd0ec7ee87..67b8ffd21d8a 100644
> --- a/drivers/net/ethernet/intel/igc/igc_mac.c
> +++ b/drivers/net/ethernet/intel/igc/igc_mac.c
> @@ -638,7 +638,7 @@ s32 igc_config_fc_after_link_up(struct igc_hw *hw)
> }
>
> out:
> - return 0;
> + return ret_val;
> }
>
> /**
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>
Thanks for your patch.
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-09 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 6:10 [PATCH] igc: check return value of ret_val in igc_config_fc_after_link_up Kevin Lo
2021-01-07 6:10 ` [Intel-wired-lan] " Kevin Lo
2021-01-09 16:57 ` Neftin, Sasha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.