All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Adam Ford <aford173@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 00/27] ARM: davinci: convert to common clock framework​
Date: Tue, 26 Jun 2018 18:26:31 +0530	[thread overview]
Message-ID: <a45f20fe-61f1-6c10-c44d-655f9960d824@ti.com> (raw)
In-Reply-To: <9ca9d240-f556-cb4f-1a58-4a55c379a02f@lechnology.com>

On Friday 25 May 2018 11:51 PM, David Lechner wrote:
> On 05/22/2018 04:38 AM, Sekhar Nori wrote:
>> Hi David,
>>
>> On Friday 18 May 2018 10:18 PM, David Lechner wrote:
>>> This series converts mach-davinci to use the common clock framework.
>>>
>>> The series works like this, the first 3 patches fix some issues with
>>> the clock
>>> drivers that have already been accepted into the mainline kernel.
>>>
>>> Then, starting with "ARM: davinci: pass clock as parameter to
>>> davinci_timer_init()", we get the mach code ready for the switch by
>>> adding the
>>> code needed for the new clock drivers and adding #ifndef
>>> CONFIG_COMMON_CLK
>>> around the legacy clocks so that we can switch easily between the old
>>> and the
>>> new.
>>>
>>> "ARM: davinci: switch to common clock framework" actually flips the
>>> switch
>>> to start using the new clock drivers. Then the next 8 patches remove all
>>> of the old clock code.
>>>
>>> The final four patches add device tree clock support to the one SoC that
>>> supports it.
>>>
>>> This series has been tested on TI OMAP-L138 LCDK (both device tree
>>> and legacy
>>> board file).
>>
>> If you do end up sending a v12, you can leave out the mach-davinci
>> portions unless there are any changes you need to make. I will pick them
>> up from this series once the driver dependencies are merged.
>>
>> I do hope the drivers/clk/* changes can be merged from v4.18.
>>
> 
> I have resent all of the clk patches (including all of the ones I listed as
> dependencies in addition to the three remaining in this series) under the
> cover "clk: davinci: outstanding fixes​".
> 
> I also found that we need to add power-domains properties to the PWM nodes
> in "ARM: dts: da850: Add clocks". I probably should just take your advice
> and just globally added them even if they are not documented for some types
> ofnodes.

I think doing it en masse will be controversial. Just add it to PWM
nodes for now (I am assuming the binding documentation agrees).

I have applied this series so please send any more changes as follow-on
patches.

Thanks
Sekhar

WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>, Adam Ford <aford173@gmail.com>
Subject: Re: [PATCH v11 00/27] ARM: davinci: convert to common clock framework​
Date: Tue, 26 Jun 2018 18:26:31 +0530	[thread overview]
Message-ID: <a45f20fe-61f1-6c10-c44d-655f9960d824@ti.com> (raw)
In-Reply-To: <9ca9d240-f556-cb4f-1a58-4a55c379a02f@lechnology.com>

On Friday 25 May 2018 11:51 PM, David Lechner wrote:
> On 05/22/2018 04:38 AM, Sekhar Nori wrote:
>> Hi David,
>>
>> On Friday 18 May 2018 10:18 PM, David Lechner wrote:
>>> This series converts mach-davinci to use the common clock framework.
>>>
>>> The series works like this, the first 3 patches fix some issues with
>>> the clock
>>> drivers that have already been accepted into the mainline kernel.
>>>
>>> Then, starting with "ARM: davinci: pass clock as parameter to
>>> davinci_timer_init()", we get the mach code ready for the switch by
>>> adding the
>>> code needed for the new clock drivers and adding #ifndef
>>> CONFIG_COMMON_CLK
>>> around the legacy clocks so that we can switch easily between the old
>>> and the
>>> new.
>>>
>>> "ARM: davinci: switch to common clock framework" actually flips the
>>> switch
>>> to start using the new clock drivers. Then the next 8 patches remove all
>>> of the old clock code.
>>>
>>> The final four patches add device tree clock support to the one SoC that
>>> supports it.
>>>
>>> This series has been tested on TI OMAP-L138 LCDK (both device tree
>>> and legacy
>>> board file).
>>
>> If you do end up sending a v12, you can leave out the mach-davinci
>> portions unless there are any changes you need to make. I will pick them
>> up from this series once the driver dependencies are merged.
>>
>> I do hope the drivers/clk/* changes can be merged from v4.18.
>>
> 
> I have resent all of the clk patches (including all of the ones I listed as
> dependencies in addition to the three remaining in this series) under the
> cover "clk: davinci: outstanding fixes​".
> 
> I also found that we need to add power-domains properties to the PWM nodes
> in "ARM: dts: da850: Add clocks". I probably should just take your advice
> and just globally added them even if they are not documented for some types
> ofnodes.

I think doing it en masse will be controversial. Just add it to PWM
nodes for now (I am assuming the binding documentation agrees).

I have applied this series so please send any more changes as follow-on
patches.

Thanks
Sekhar

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v11 00/27] ARM: davinci: convert to common clock framework​
Date: Tue, 26 Jun 2018 18:26:31 +0530	[thread overview]
Message-ID: <a45f20fe-61f1-6c10-c44d-655f9960d824@ti.com> (raw)
In-Reply-To: <9ca9d240-f556-cb4f-1a58-4a55c379a02f@lechnology.com>

On Friday 25 May 2018 11:51 PM, David Lechner wrote:
> On 05/22/2018 04:38 AM, Sekhar Nori wrote:
>> Hi David,
>>
>> On Friday 18 May 2018 10:18 PM, David Lechner wrote:
>>> This series converts mach-davinci to use the common clock framework.
>>>
>>> The series works like this, the first 3 patches fix some issues with
>>> the clock
>>> drivers that have already been accepted into the mainline kernel.
>>>
>>> Then, starting with "ARM: davinci: pass clock as parameter to
>>> davinci_timer_init()", we get the mach code ready for the switch by
>>> adding the
>>> code needed for the new clock drivers and adding #ifndef
>>> CONFIG_COMMON_CLK
>>> around the legacy clocks so that we can switch easily between the old
>>> and the
>>> new.
>>>
>>> "ARM: davinci: switch to common clock framework" actually flips the
>>> switch
>>> to start using the new clock drivers. Then the next 8 patches remove all
>>> of the old clock code.
>>>
>>> The final four patches add device tree clock support to the one SoC that
>>> supports it.
>>>
>>> This series has been tested on TI OMAP-L138 LCDK (both device tree
>>> and legacy
>>> board file).
>>
>> If you do end up sending a v12, you can leave out the mach-davinci
>> portions unless there are any changes you need to make. I will pick them
>> up from this series once the driver dependencies are merged.
>>
>> I do hope the drivers/clk/* changes can be merged from v4.18.
>>
> 
> I have resent all of the clk patches (including all of the ones I listed as
> dependencies in addition to the three remaining in this series) under the
> cover "clk: davinci: outstanding fixes?".
> 
> I also found that we need to add power-domains properties to the PWM nodes
> in "ARM: dts: da850: Add clocks". I probably should just take your advice
> and just globally added them even if they are not documented for some types
> ofnodes.

I think doing it en masse will be controversial. Just add it to PWM
nodes for now (I am assuming the binding documentation agrees).

I have applied this series so please send any more changes as follow-on
patches.

Thanks
Sekhar

  reply	other threads:[~2018-06-26 12:57 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 16:48 [PATCH v11 00/27] ARM: davinci: convert to common clock framework​ David Lechner
2018-05-18 16:48 ` David Lechner
2018-05-18 16:48 ` [PATCH v11 01/27] clk: davinci: pll: allow dev == NULL David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-22  8:43   ` Sekhar Nori
2018-05-22  8:43     ` Sekhar Nori
2018-05-22  8:43     ` Sekhar Nori
2018-05-18 16:48 ` [PATCH v11 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 03/27] clk: davinci: psc: allow for dev == NULL David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-22  9:05   ` Sekhar Nori
2018-05-22  9:05     ` Sekhar Nori
2018-05-22  9:05     ` Sekhar Nori
2018-05-18 16:48 ` [PATCH v11 04/27] ARM: davinci: pass clock as parameter to davinci_timer_init() David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 05/27] ARM: davinci: da830: add new clock init using common clock framework David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 06/27] ARM: davinci: da850: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 07/27] ARM: davinci: dm355: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 08/27] ARM: davinci: dm365: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 09/27] ARM: davinci: dm644x: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 10/27] ARM: davinci: dm646x: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 11/27] ARM: davinci: da8xx: add new USB PHY " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 12/27] ARM: davinci: da8xx: add new sata_refclk " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 13/27] ARM: davinci: remove CONFIG_DAVINCI_RESET_CLOCKS David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 14/27] ARM: davinci_all_defconfig: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 15/27] ARM: davinci: switch to common clock framework David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 16/27] ARM: davinci: da830: Remove legacy clock init David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 17/27] ARM: davinci: da850: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 18/27] ARM: davinci: dm355: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 19/27] ARM: davinci: dm365: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 20/27] ARM: davinci: dm644x: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 21/27] ARM: davinci: dm646x: " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 22/27] ARM: davinci: da8xx: Remove legacy USB and SATA " David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 23/27] ARM: davinci: remove legacy clocks David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 24/27] dt-bindings: timer: new bindings for TI DaVinci timer David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 25/27] ARM: davinci: add device tree support to timer David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 26/27] ARM: davinci: da8xx-dt: switch to device tree clocks David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-18 16:48 ` [PATCH v11 27/27] ARM: dts: da850: Add clocks David Lechner
2018-05-18 16:48   ` David Lechner
2018-05-22  9:38 ` [PATCH v11 00/27] ARM: davinci: convert to common clock framework​ Sekhar Nori
2018-05-22  9:38   ` Sekhar Nori
2018-05-22  9:38   ` Sekhar Nori
2018-05-25 18:21   ` David Lechner
2018-05-25 18:21     ` David Lechner
2018-06-26 12:56     ` Sekhar Nori [this message]
2018-06-26 12:56       ` Sekhar Nori
2018-06-26 12:56       ` Sekhar Nori
2018-06-26 15:34       ` David Lechner
2018-06-26 15:34         ` David Lechner
2018-06-17 15:48   ` David Lechner
2018-06-17 15:48     ` David Lechner
2018-06-18  4:47     ` Sekhar Nori
2018-06-18  4:47       ` Sekhar Nori
2018-06-18  4:47       ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a45f20fe-61f1-6c10-c44d-655f9960d824@ti.com \
    --to=nsekhar@ti.com \
    --cc=aford173@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.