From: Richard Henderson <richard.henderson@linaro.org>
To: Claudio Fontana <cfontana@suse.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [RFC v2 07/24] target/arm: move physical address translation to new modules
Date: Mon, 1 Mar 2021 10:49:13 -0800 [thread overview]
Message-ID: <a4938d38-eec9-361c-b689-77832a3da75d@linaro.org> (raw)
In-Reply-To: <20210301164936.19446-8-cfontana@suse.de>
On 3/1/21 8:49 AM, Claudio Fontana wrote:
> --- a/target/arm/internals.h
> +++ b/target/arm/internals.h
> @@ -1023,9 +1023,6 @@ typedef struct ARMVAParameters {
> bool using64k : 1;
> } ARMVAParameters;
>
> -ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va,
> - ARMMMUIdx mmu_idx, bool data);
> -
Moving aa64_va_parameters away from its struct return is not good. Either move
them both or not at all.
The collection of stuff you've split out into get-phys-addr.h is pretty random.
Let's just leave it all in internals.h for now. We can make a more reasoned
decision vs all of the vma and regime related functions.
r~
next prev parent reply other threads:[~2021-03-01 18:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210301164936.19446-1-cfontana@suse.de>
[not found] ` <20210301164936.19446-5-cfontana@suse.de>
2021-03-01 18:16 ` [RFC v2 04/24] target/arm: move psci.c into tcg/sysemu/ Richard Henderson
2021-03-02 10:38 ` Claudio Fontana
2021-03-02 11:54 ` Peter Maydell
2021-03-02 18:36 ` Claudio Fontana
[not found] ` <20210301164936.19446-8-cfontana@suse.de>
2021-03-01 18:49 ` Richard Henderson [this message]
2021-03-02 10:58 ` [RFC v2 07/24] target/arm: move physical address translation to new modules Claudio Fontana
[not found] ` <20210301164936.19446-9-cfontana@suse.de>
2021-03-01 22:22 ` [RFC v2 08/24] target/arm: split cpregs from tcg/helper.c Richard Henderson
[not found] ` <20210301164936.19446-11-cfontana@suse.de>
2021-03-02 3:36 ` [RFC v2 10/24] target/arm: only perform TCG cpu and machine inits if tcg enabled Richard Henderson
2021-03-02 7:58 ` Claudio Fontana
[not found] ` <20210301164936.19446-12-cfontana@suse.de>
2021-03-02 3:41 ` [RFC v2 11/24] target/arm: kvm: add stubs for some helpers Richard Henderson
[not found] ` <20210301164936.19446-13-cfontana@suse.de>
2021-03-02 4:02 ` [RFC v2 12/24] target/arm: move cpsr_read, cpsr_write to cpu_common Richard Henderson
2021-03-02 8:11 ` Claudio Fontana
[not found] ` <20210301164936.19446-14-cfontana@suse.de>
2021-03-02 4:07 ` [RFC v2 13/24] target/arm: add temporary stub for arm_rebuild_hflags Richard Henderson
[not found] ` <20210301164936.19446-15-cfontana@suse.de>
2021-03-02 4:24 ` [RFC v2 14/24] target/arm: split vfp state setting from tcg helpers Richard Henderson
2021-03-02 8:18 ` Claudio Fontana
[not found] ` <20210301164936.19446-16-cfontana@suse.de>
2021-03-02 4:35 ` [RFC v2 15/24] target/arm: move arm_mmu_idx* to get-phys-addr Richard Henderson
2021-03-02 12:16 ` Claudio Fontana
[not found] ` <20210301164936.19446-17-cfontana@suse.de>
2021-03-02 4:41 ` [RFC v2 16/24] target/arm: move sve_zcr_len_for_el to common_cpu Richard Henderson
2021-03-03 8:17 ` Claudio Fontana
[not found] ` <20210301164936.19446-19-cfontana@suse.de>
2021-03-02 5:43 ` [RFC v2 18/24] target/arm: move arm_cpu_list " Richard Henderson
[not found] ` <20210301164936.19446-6-cfontana@suse.de>
2021-03-02 5:50 ` [RFC v2 05/24] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG Richard Henderson
2021-03-02 8:00 ` Claudio Fontana
[not found] ` <20210301164936.19446-7-cfontana@suse.de>
2021-03-02 6:17 ` [RFC v2 06/24] target/arm: split off cpu-sysemu.c Richard Henderson
2021-03-02 8:06 ` Claudio Fontana
[not found] ` <20210301164936.19446-20-cfontana@suse.de>
2021-03-02 6:23 ` [RFC v2 19/24] target/arm: move aarch64_sync_32_to_64 (and vv) to cpu code Richard Henderson
2021-03-02 11:58 ` Claudio Fontana
2021-03-02 12:11 ` Peter Maydell
[not found] ` <20210301164936.19446-25-cfontana@suse.de>
2021-03-02 7:40 ` [RFC v2 24/24] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled() Claudio Fontana
[not found] ` <20210301164936.19446-22-cfontana@suse.de>
2021-03-02 16:56 ` [RFC v2 21/24] target/arm: cpu64: wrap TCG-only parts of aarch64_cpu_dump_state Richard Henderson
2021-03-02 18:01 ` Claudio Fontana
2021-03-02 18:49 ` Richard Henderson
[not found] ` <20210301164936.19446-23-cfontana@suse.de>
2021-03-02 16:58 ` [RFC v2 22/24] target/arm: cpu64: wrap arm cpregs with CONFIG_TCG Richard Henderson
2021-03-02 18:06 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4938d38-eec9-361c-b689-77832a3da75d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cfontana@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.