All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Neil Roberts <nroberts@igalia.com>,
	Rob Herring <robh+dt@kernel.org>,
	Tomeu Vizoso <tomeu@tomeuvizoso.net>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Robin Murphy <robin.murphy@arm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] Fix purging buffers in the shmem helpers
Date: Fri, 5 Mar 2021 10:22:30 +0000	[thread overview]
Message-ID: <a4b35b00-4f4d-b086-9ad4-dd2038d8df75@arm.com> (raw)
In-Reply-To: <20210223155125.199577-1-nroberts@igalia.com>

On 23/02/2021 15:51, Neil Roberts wrote:
> These two patches fix a problem with the madvise purging code for the
> shmem helpers where the mmaping for a purged buffer wouldn't get
> invalidated correctly. This presumably ends up as a security hole
> where the mapping can be accessed from user-space to read and write
> random pages from other buffers. This is currently affecting Panfrost.
> The second patch is a v2 from a patch that was sent standalone.
> 
> There is a WIP IGT test for Panfrost which demonstrates the bug here:
> 
> https://gitlab.freedesktop.org/nroberts/igt-gpu-tools/-/commits/panfrost-purgemap/
> 
> Neil Roberts (2):
>    drm/shmem-helper: Check for purged buffers in fault handler
>    drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff
> 
>   drivers/gpu/drm/drm_gem_shmem_helper.c | 25 ++++++++++++++++++-------
>   1 file changed, 18 insertions(+), 7 deletions(-)
> 

Pushed to drm-misc-fixes

Thanks,

Steve
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2021-03-05 10:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 15:51 [PATCH 0/2] Fix purging buffers in the shmem helpers Neil Roberts
2021-02-23 15:51 ` [PATCH 1/2] drm/shmem-helper: Check for purged buffers in fault handler Neil Roberts
2021-02-23 15:51   ` Neil Roberts
2021-02-24 16:39   ` Steven Price
2021-02-24 16:39     ` Steven Price
2021-02-23 15:51 ` [PATCH v2 2/2] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff Neil Roberts
2021-02-23 15:51   ` Neil Roberts
2021-02-24 16:41   ` Steven Price
2021-02-24 16:41     ` Steven Price
2021-03-05 10:22 ` Steven Price [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4b35b00-4f4d-b086-9ad4-dd2038d8df75@arm.com \
    --to=steven.price@arm.com \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=nroberts@igalia.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tomeu@tomeuvizoso.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.