All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ] mesh: Fix model publication status after set
@ 2020-03-25 21:48 Michał Lowas-Rzechonek
  2020-03-26 17:01 ` Gix, Brian
  0 siblings, 1 reply; 2+ messages in thread
From: Michał Lowas-Rzechonek @ 2020-03-25 21:48 UTC (permalink / raw)
  To: linux-bluetooth

This patch fixes usage of send_pub_status() when handling publication
set message - mod_id was swapped with pub_addr, resulting in malformed
message being sent back to the Config Client.
---
 mesh/cfgmod-server.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mesh/cfgmod-server.c b/mesh/cfgmod-server.c
index c5c756a33..856eb6b27 100644
--- a/mesh/cfgmod-server.c
+++ b/mesh/cfgmod-server.c
@@ -185,8 +185,8 @@ static void config_pub_set(struct mesh_node *node, uint16_t net_idx,
 	}
 
 	if (!unreliable)
-		send_pub_status(node, net_idx, src, dst, status, ele_addr, ota,
-			mod_id, idx, cred_flag, ttl, period, retransmit);
+		send_pub_status(node, net_idx, src, dst, status, ele_addr,
+			mod_id, ota, idx, cred_flag, ttl, period, retransmit);
 }
 
 static void send_sub_status(struct mesh_node *node, uint16_t net_idx,
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ] mesh: Fix model publication status after set
  2020-03-25 21:48 [PATCH BlueZ] mesh: Fix model publication status after set Michał Lowas-Rzechonek
@ 2020-03-26 17:01 ` Gix, Brian
  0 siblings, 0 replies; 2+ messages in thread
From: Gix, Brian @ 2020-03-26 17:01 UTC (permalink / raw)
  To: michal.lowas-rzechonek, linux-bluetooth

Applied
On Wed, 2020-03-25 at 22:48 +0100, Michał Lowas-Rzechonek wrote:
> This patch fixes usage of send_pub_status() when handling publication
> set message - mod_id was swapped with pub_addr, resulting in malformed
> message being sent back to the Config Client.
> ---
>  mesh/cfgmod-server.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mesh/cfgmod-server.c b/mesh/cfgmod-server.c
> index c5c756a33..856eb6b27 100644
> --- a/mesh/cfgmod-server.c
> +++ b/mesh/cfgmod-server.c
> @@ -185,8 +185,8 @@ static void config_pub_set(struct mesh_node *node, uint16_t net_idx,
>  	}
>  
>  	if (!unreliable)
> -		send_pub_status(node, net_idx, src, dst, status, ele_addr, ota,
> -			mod_id, idx, cred_flag, ttl, period, retransmit);
> +		send_pub_status(node, net_idx, src, dst, status, ele_addr,
> +			mod_id, ota, idx, cred_flag, ttl, period, retransmit);
>  }
>  
>  static void send_sub_status(struct mesh_node *node, uint16_t net_idx,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-26 17:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 21:48 [PATCH BlueZ] mesh: Fix model publication status after set Michał Lowas-Rzechonek
2020-03-26 17:01 ` Gix, Brian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.