[stable] usb: gadget: Fix potential use-after-free

[stable] usb: gadget: Fix potential use-after-free

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Please pick these two commits for all stable branches:

commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda
Author: Hangyu Hua <hbh25y@gmail.com>
Date:   Sat Jan 1 01:21:37 2022 +0800
 
    usb: gadget: don't release an existing dev->buf
 
commit 501e38a5531efbd77d5c73c0ba838a889bfc1d74
Author: Hangyu Hua <hbh25y@gmail.com>
Date:   Sat Jan 1 01:21:38 2022 +0800
 
    usb: gadget: clear related members when goto fail

Ben.

-- 
Ben Hutchings
The first rule of tautology club is the first rule of tautology club.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [stable] usb: gadget: Fix potential use-after-free

[Hangyu Hua]

All right. I will do that.

Thanks.

On 2022/3/1 02:47, Ben Hutchings wrote:
> Please pick these two commits for all stable branches:
> 
> commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda
> Author: Hangyu Hua <hbh25y@gmail.com>
> Date:   Sat Jan 1 01:21:37 2022 +0800
>   
>      usb: gadget: don't release an existing dev->buf
>   
> commit 501e38a5531efbd77d5c73c0ba838a889bfc1d74
> Author: Hangyu Hua <hbh25y@gmail.com>
> Date:   Sat Jan 1 01:21:38 2022 +0800
>   
>      usb: gadget: clear related members when goto fail
> 
> Ben.
> 

Re: [stable] usb: gadget: Fix potential use-after-free

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Tue, 2022-03-01 at 09:33 +0800, Hangyu Hua wrote:
> All right. I will do that.

That was actually a request to the stable maintainers.  You don't need
to do anything, unless there is some reason why these fixes don't apply
to older versions or need to be adjusted in some way.

Ben.

> Thanks.
> 
> On 2022/3/1 02:47, Ben Hutchings wrote:
> > Please pick these two commits for all stable branches:
> > 
> > commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda
> > Author: Hangyu Hua <hbh25y@gmail.com>
> > Date:   Sat Jan 1 01:21:37 2022 +0800
> >   
> >      usb: gadget: don't release an existing dev->buf
> >   
> > commit 501e38a5531efbd77d5c73c0ba838a889bfc1d74
> > Author: Hangyu Hua <hbh25y@gmail.com>
> > Date:   Sat Jan 1 01:21:38 2022 +0800
> >   
> >      usb: gadget: clear related members when goto fail
> > 
> > Ben.
> > 

-- 
Ben Hutchings
If God had intended Man to program,
we'd have been born with serial I/O ports.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [stable] usb: gadget: Fix potential use-after-free

[Hangyu Hua]

I get it. Looks like I got it wrong. I already submitted "PATCH 4.14" a 
few days ago. You can see it in:

https://lore.kernel.org/all/20220301022608.10950-1-hbh25y@gmail.com/

Thanks.

On 2022/3/3 04:04, Ben Hutchings wrote:
> On Tue, 2022-03-01 at 09:33 +0800, Hangyu Hua wrote:
>> All right. I will do that.
> 
> That was actually a request to the stable maintainers.  You don't need
> to do anything, unless there is some reason why these fixes don't apply
> to older versions or need to be adjusted in some way.
> 
> Ben.
> 
>> Thanks.
>>
>> On 2022/3/1 02:47, Ben Hutchings wrote:
>>> Please pick these two commits for all stable branches:
>>>
>>> commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda
>>> Author: Hangyu Hua <hbh25y@gmail.com>
>>> Date:   Sat Jan 1 01:21:37 2022 +0800
>>>    
>>>       usb: gadget: don't release an existing dev->buf
>>>    
>>> commit 501e38a5531efbd77d5c73c0ba838a889bfc1d74
>>> Author: Hangyu Hua <hbh25y@gmail.com>
>>> Date:   Sat Jan 1 01:21:38 2022 +0800
>>>    
>>>       usb: gadget: clear related members when goto fail
>>>
>>> Ben.
>>>
> 

Re: [stable] usb: gadget: Fix potential use-after-free

[Greg KH]

On Mon, Feb 28, 2022 at 07:47:31PM +0100, Ben Hutchings wrote:
> Please pick these two commits for all stable branches:
> 
> commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda
> Author: Hangyu Hua <hbh25y@gmail.com>
> Date:   Sat Jan 1 01:21:37 2022 +0800
>  
>     usb: gadget: don't release an existing dev->buf
>  
> commit 501e38a5531efbd77d5c73c0ba838a889bfc1d74
> Author: Hangyu Hua <hbh25y@gmail.com>
> Date:   Sat Jan 1 01:21:38 2022 +0800
>  
>     usb: gadget: clear related members when goto fail
> 

Now queued up, thanks

greg k-h