* [PATCH] drm/amdgpu: trace VM flags as 64bits
@ 2017-07-03 13:25 Christian König
[not found] ` <1499088304-2971-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2017-07-03 13:25 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
From: Christian König <christian.koenig@amd.com>
Otherwise the upper bits are lost.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
index 8601904..509f7a6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
@@ -224,7 +224,7 @@ TRACE_EVENT(amdgpu_vm_bo_map,
__field(long, start)
__field(long, last)
__field(u64, offset)
- __field(u32, flags)
+ __field(u64, flags)
),
TP_fast_assign(
@@ -234,7 +234,7 @@ TRACE_EVENT(amdgpu_vm_bo_map,
__entry->offset = mapping->offset;
__entry->flags = mapping->flags;
),
- TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%08x",
+ TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%llx",
__entry->bo, __entry->start, __entry->last,
__entry->offset, __entry->flags)
);
@@ -248,7 +248,7 @@ TRACE_EVENT(amdgpu_vm_bo_unmap,
__field(long, start)
__field(long, last)
__field(u64, offset)
- __field(u32, flags)
+ __field(u64, flags)
),
TP_fast_assign(
@@ -258,7 +258,7 @@ TRACE_EVENT(amdgpu_vm_bo_unmap,
__entry->offset = mapping->offset;
__entry->flags = mapping->flags;
),
- TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%08x",
+ TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%llx",
__entry->bo, __entry->start, __entry->last,
__entry->offset, __entry->flags)
);
@@ -269,7 +269,7 @@ DECLARE_EVENT_CLASS(amdgpu_vm_mapping,
TP_STRUCT__entry(
__field(u64, soffset)
__field(u64, eoffset)
- __field(u32, flags)
+ __field(u64, flags)
),
TP_fast_assign(
@@ -277,7 +277,7 @@ DECLARE_EVENT_CLASS(amdgpu_vm_mapping,
__entry->eoffset = mapping->last + 1;
__entry->flags = mapping->flags;
),
- TP_printk("soffs=%010llx, eoffs=%010llx, flags=%08x",
+ TP_printk("soffs=%010llx, eoffs=%010llx, flags=%llx",
__entry->soffset, __entry->eoffset, __entry->flags)
);
@@ -293,14 +293,14 @@ DEFINE_EVENT(amdgpu_vm_mapping, amdgpu_vm_bo_mapping,
TRACE_EVENT(amdgpu_vm_set_ptes,
TP_PROTO(uint64_t pe, uint64_t addr, unsigned count,
- uint32_t incr, uint32_t flags),
+ uint32_t incr, uint64_t flags),
TP_ARGS(pe, addr, count, incr, flags),
TP_STRUCT__entry(
__field(u64, pe)
__field(u64, addr)
__field(u32, count)
__field(u32, incr)
- __field(u32, flags)
+ __field(u64, flags)
),
TP_fast_assign(
@@ -310,7 +310,7 @@ TRACE_EVENT(amdgpu_vm_set_ptes,
__entry->incr = incr;
__entry->flags = flags;
),
- TP_printk("pe=%010Lx, addr=%010Lx, incr=%u, flags=%08x, count=%u",
+ TP_printk("pe=%010Lx, addr=%010Lx, incr=%u, flags=%llx, count=%u",
__entry->pe, __entry->addr, __entry->incr,
__entry->flags, __entry->count)
);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: trace VM flags as 64bits
[not found] ` <1499088304-2971-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
@ 2017-07-03 15:26 ` axie
2017-07-03 16:01 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: axie @ 2017-07-03 15:26 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Reviewed-by: Alex Xie <AlexBin.Xie@amd.com>
On 2017-07-03 09:25 AM, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
>
> Otherwise the upper bits are lost.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> index 8601904..509f7a6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> @@ -224,7 +224,7 @@ TRACE_EVENT(amdgpu_vm_bo_map,
> __field(long, start)
> __field(long, last)
> __field(u64, offset)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -234,7 +234,7 @@ TRACE_EVENT(amdgpu_vm_bo_map,
> __entry->offset = mapping->offset;
> __entry->flags = mapping->flags;
> ),
> - TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%08x",
> + TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%llx",
> __entry->bo, __entry->start, __entry->last,
> __entry->offset, __entry->flags)
> );
> @@ -248,7 +248,7 @@ TRACE_EVENT(amdgpu_vm_bo_unmap,
> __field(long, start)
> __field(long, last)
> __field(u64, offset)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -258,7 +258,7 @@ TRACE_EVENT(amdgpu_vm_bo_unmap,
> __entry->offset = mapping->offset;
> __entry->flags = mapping->flags;
> ),
> - TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%08x",
> + TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%llx",
> __entry->bo, __entry->start, __entry->last,
> __entry->offset, __entry->flags)
> );
> @@ -269,7 +269,7 @@ DECLARE_EVENT_CLASS(amdgpu_vm_mapping,
> TP_STRUCT__entry(
> __field(u64, soffset)
> __field(u64, eoffset)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -277,7 +277,7 @@ DECLARE_EVENT_CLASS(amdgpu_vm_mapping,
> __entry->eoffset = mapping->last + 1;
> __entry->flags = mapping->flags;
> ),
> - TP_printk("soffs=%010llx, eoffs=%010llx, flags=%08x",
> + TP_printk("soffs=%010llx, eoffs=%010llx, flags=%llx",
> __entry->soffset, __entry->eoffset, __entry->flags)
> );
>
> @@ -293,14 +293,14 @@ DEFINE_EVENT(amdgpu_vm_mapping, amdgpu_vm_bo_mapping,
>
> TRACE_EVENT(amdgpu_vm_set_ptes,
> TP_PROTO(uint64_t pe, uint64_t addr, unsigned count,
> - uint32_t incr, uint32_t flags),
> + uint32_t incr, uint64_t flags),
> TP_ARGS(pe, addr, count, incr, flags),
> TP_STRUCT__entry(
> __field(u64, pe)
> __field(u64, addr)
> __field(u32, count)
> __field(u32, incr)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -310,7 +310,7 @@ TRACE_EVENT(amdgpu_vm_set_ptes,
> __entry->incr = incr;
> __entry->flags = flags;
> ),
> - TP_printk("pe=%010Lx, addr=%010Lx, incr=%u, flags=%08x, count=%u",
> + TP_printk("pe=%010Lx, addr=%010Lx, incr=%u, flags=%llx, count=%u",
> __entry->pe, __entry->addr, __entry->incr,
> __entry->flags, __entry->count)
> );
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: trace VM flags as 64bits
[not found] ` <1499088304-2971-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-03 15:26 ` axie
@ 2017-07-03 16:01 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2017-07-03 16:01 UTC (permalink / raw)
To: 'Christian König', amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Monday, July 03, 2017 9:25 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH] drm/amdgpu: trace VM flags as 64bits
>
> From: Christian König <christian.koenig@amd.com>
>
> Otherwise the upper bits are lost.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> index 8601904..509f7a6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> @@ -224,7 +224,7 @@ TRACE_EVENT(amdgpu_vm_bo_map,
> __field(long, start)
> __field(long, last)
> __field(u64, offset)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -234,7 +234,7 @@ TRACE_EVENT(amdgpu_vm_bo_map,
> __entry->offset = mapping->offset;
> __entry->flags = mapping->flags;
> ),
> - TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx,
> flags=%08x",
> + TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%llx",
> __entry->bo, __entry->start, __entry->last,
> __entry->offset, __entry->flags)
> );
> @@ -248,7 +248,7 @@ TRACE_EVENT(amdgpu_vm_bo_unmap,
> __field(long, start)
> __field(long, last)
> __field(u64, offset)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -258,7 +258,7 @@ TRACE_EVENT(amdgpu_vm_bo_unmap,
> __entry->offset = mapping->offset;
> __entry->flags = mapping->flags;
> ),
> - TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx,
> flags=%08x",
> + TP_printk("bo=%p, start=%lx, last=%lx, offset=%010llx, flags=%llx",
> __entry->bo, __entry->start, __entry->last,
> __entry->offset, __entry->flags)
> );
> @@ -269,7 +269,7 @@ DECLARE_EVENT_CLASS(amdgpu_vm_mapping,
> TP_STRUCT__entry(
> __field(u64, soffset)
> __field(u64, eoffset)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -277,7 +277,7 @@ DECLARE_EVENT_CLASS(amdgpu_vm_mapping,
> __entry->eoffset = mapping->last + 1;
> __entry->flags = mapping->flags;
> ),
> - TP_printk("soffs=%010llx, eoffs=%010llx, flags=%08x",
> + TP_printk("soffs=%010llx, eoffs=%010llx, flags=%llx",
> __entry->soffset, __entry->eoffset, __entry->flags)
> );
>
> @@ -293,14 +293,14 @@ DEFINE_EVENT(amdgpu_vm_mapping,
> amdgpu_vm_bo_mapping,
>
> TRACE_EVENT(amdgpu_vm_set_ptes,
> TP_PROTO(uint64_t pe, uint64_t addr, unsigned count,
> - uint32_t incr, uint32_t flags),
> + uint32_t incr, uint64_t flags),
> TP_ARGS(pe, addr, count, incr, flags),
> TP_STRUCT__entry(
> __field(u64, pe)
> __field(u64, addr)
> __field(u32, count)
> __field(u32, incr)
> - __field(u32, flags)
> + __field(u64, flags)
> ),
>
> TP_fast_assign(
> @@ -310,7 +310,7 @@ TRACE_EVENT(amdgpu_vm_set_ptes,
> __entry->incr = incr;
> __entry->flags = flags;
> ),
> - TP_printk("pe=%010Lx, addr=%010Lx, incr=%u, flags=%08x,
> count=%u",
> + TP_printk("pe=%010Lx, addr=%010Lx, incr=%u, flags=%llx,
> count=%u",
> __entry->pe, __entry->addr, __entry->incr,
> __entry->flags, __entry->count)
> );
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-03 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-03 13:25 [PATCH] drm/amdgpu: trace VM flags as 64bits Christian König
[not found] ` <1499088304-2971-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-03 15:26 ` axie
2017-07-03 16:01 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.