All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"
@ 2018-05-22 23:55 Bart Van Assche
  2018-05-23  1:30 ` Kent Overstreet
  0 siblings, 1 reply; 7+ messages in thread
From: Bart Van Assche @ 2018-05-22 23:55 UTC (permalink / raw)
  To: Jens Axboe
  Cc: linux-block, Christoph Hellwig, Bart Van Assche, Kent Overstreet

This patch avoids that KASAN reports the following complaint when
running the srp-test software:

BUG: KASAN: use-after-free in bio_advance+0x110/0x1b0
Read of size 4 at addr ffff88014c7aa950 by task ksoftirqd/10/72
Call Trace:
dump_stack+0x9a/0xeb
print_address_description+0x65/0x270
kasan_report+0x232/0x350
bio_advance+0x110/0x1b0
blk_update_request+0x9d/0x5a0
scsi_end_request+0x4c/0x300 [scsi_mod]
scsi_io_completion+0x71e/0xa40 [scsi_mod]
__blk_mq_complete_request+0x13e/0x220
srp_recv_done+0x454/0x1100 [ib_srp]
__ib_process_cq+0x9a/0xf0 [ib_core]
ib_poll_handler+0x2d/0x90 [ib_core]
irq_poll_softirq+0xe5/0x1e0
__do_softirq+0x112/0x5f0
run_ksoftirqd+0x29/0x50
smpboot_thread_fn+0x30f/0x410
kthread+0x1b2/0x1d0
ret_from_fork+0x24/0x30

This reverts commit 0ba99ca4838bc75481a4bf0e70bad20b0a5457c7.

Fixes: commit 45db54d58de0 ("block: Split out bio_list_copy_data()")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
---
 block/bio.c      | 3 ---
 block/blk-core.c | 8 +-------
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/block/bio.c b/block/bio.c
index 0a4df92cd689..e22ebab450f8 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1777,9 +1777,6 @@ void bio_endio(struct bio *bio)
 	if (!bio_integrity_endio(bio))
 		return;
 
-	if (WARN_ONCE(bio->bi_next, "driver left bi_next not NULL"))
-		bio->bi_next = NULL;
-
 	/*
 	 * Need to have a real endio function for chained bios, otherwise
 	 * various corner cases will break (like stacking block devices that
diff --git a/block/blk-core.c b/block/blk-core.c
index a216b8b137f4..4d69f91a6431 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -277,10 +277,6 @@ static void req_bio_endio(struct request *rq, struct bio *bio,
 	bio_advance(bio, nbytes);
 
 	/* don't actually finish bio if it's part of flush sequence */
-	/*
-	 * XXX this code looks suspicious - it's not consistent with advancing
-	 * req->bio in caller
-	 */
 	if (bio->bi_iter.bi_size == 0 && !(rq->rq_flags & RQF_FLUSH_SEQ))
 		bio_endio(bio);
 }
@@ -3115,10 +3111,8 @@ bool blk_update_request(struct request *req, blk_status_t error,
 		struct bio *bio = req->bio;
 		unsigned bio_bytes = min(bio->bi_iter.bi_size, nr_bytes);
 
-		if (bio_bytes == bio->bi_iter.bi_size) {
+		if (bio_bytes == bio->bi_iter.bi_size)
 			req->bio = bio->bi_next;
-			bio->bi_next = NULL;
-		}
 
 		/* Completion has already been traced */
 		bio_clear_flag(bio, BIO_TRACE_COMPLETION);
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"
  2018-05-22 23:55 [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()" Bart Van Assche
@ 2018-05-23  1:30 ` Kent Overstreet
  2018-05-23  1:36   ` Bart Van Assche
  0 siblings, 1 reply; 7+ messages in thread
From: Kent Overstreet @ 2018-05-23  1:30 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: Jens Axboe, linux-block, Christoph Hellwig

On Tue, May 22, 2018 at 04:55:05PM -0700, Bart Van Assche wrote:
> This patch avoids that KASAN reports the following complaint when
> running the srp-test software:

I made a real attempt to get your test suite working. It would be nice if you
could make an attempt at tracking it down instead of just reverting, and holding
up improvements to the whole block layer, since you seem to have an easy repro
for it.

This is a real looming issue - we have other code which assumes things about
bi_next and this isn't a practical thing to grep/audit for.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"
  2018-05-23  1:30 ` Kent Overstreet
@ 2018-05-23  1:36   ` Bart Van Assche
  2018-05-23  2:16     ` Kent Overstreet
  0 siblings, 1 reply; 7+ messages in thread
From: Bart Van Assche @ 2018-05-23  1:36 UTC (permalink / raw)
  To: kent.overstreet; +Cc: hch, linux-block, axboe

T24gVHVlLCAyMDE4LTA1LTIyIGF0IDIxOjMwIC0wNDAwLCBLZW50IE92ZXJzdHJlZXQgd3JvdGU6
DQo+IE9uIFR1ZSwgTWF5IDIyLCAyMDE4IGF0IDA0OjU1OjA1UE0gLTA3MDAsIEJhcnQgVmFuIEFz
c2NoZSB3cm90ZToNCj4gPiBUaGlzIHBhdGNoIGF2b2lkcyB0aGF0IEtBU0FOIHJlcG9ydHMgdGhl
IGZvbGxvd2luZyBjb21wbGFpbnQgd2hlbg0KPiA+IHJ1bm5pbmcgdGhlIHNycC10ZXN0IHNvZnR3
YXJlOg0KPiANCj4gSSBtYWRlIGEgcmVhbCBhdHRlbXB0IHRvIGdldCB5b3VyIHRlc3Qgc3VpdGUg
d29ya2luZy4NCg0KUGxlYXNlIHRyeSBhIGxpdHRsZSBoYXJkZXIuIEV2ZXJ5b25lIEkgYXNrZWQg
dG8gcnVuIHRoYXQgdGVzdCBzdWl0ZQ0KaGFzIGJlZW4gYWJsZSB0byBydW4gaXQuDQoNCkJhcnQu
DQoNCg0KDQo=

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"
  2018-05-23  1:36   ` Bart Van Assche
@ 2018-05-23  2:16     ` Kent Overstreet
  2018-06-04  8:59       ` Bart Van Assche
  0 siblings, 1 reply; 7+ messages in thread
From: Kent Overstreet @ 2018-05-23  2:16 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: hch, linux-block, axboe

On Wed, May 23, 2018 at 01:36:02AM +0000, Bart Van Assche wrote:
> On Tue, 2018-05-22 at 21:30 -0400, Kent Overstreet wrote:
> > On Tue, May 22, 2018 at 04:55:05PM -0700, Bart Van Assche wrote:
> > > This patch avoids that KASAN reports the following complaint when
> > > running the srp-test software:
> > 
> > I made a real attempt to get your test suite working.
> 
> Please try a little harder. Everyone I asked to run that test suite
> has been able to run it.
> 
> Bart.
> 
> 
> 

========= TEST   srp

systemd-journald[143]: Received SIGTERM from PID 1 (systemd).
Removed /etc/systemd/system/multipathd.service.
Starting multipath-tools (via systemctl): multipath-tools.service.
multipathd> reconfigure
ok
multipathd> make -C discontiguous-io discontiguous-io
make[1]: Entering directory
'/host/home/kent/ktest/tests/srp-test/discontiguous-io'
make[1]: 'discontiguous-io' is up to date.
make[1]: Leaving directory
'/host/home/kent/ktest/tests/srp-test/discontiguous-io'
Unloaded the ib_srpt kernel module
Unloaded the rdma_rxe kernel module
../run_tests: line 65: cd: /lib/modules/4.17.0-rc4+/kernel/block: No such file
or directory
Zero-initializing /dev/ram0 ... done
Zero-initializing /dev/ram1 ... done
Configured SRP target driver
Running test ../tests/01 ...
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/01 failed
Running test ../tests/02-mq ...
Test file I/O on top of multipath concurrently with logout and login (10 min;
mq)
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/02-mq failed
Running test ../tests/02-sq ...
Test file I/O on top of multipath concurrently with logout and login (10 min;
sq)
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/02-sq failed
Running test ../tests/02-sq-on-mq ...
Test file I/O on top of multipath concurrently with logout and login (10 min;
sq-on-mq)
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/02-sq-on-mq failed
Running test ../tests/03-4M ...
Test direct I/O with large transfer sizes and cmd_sg_entries=255
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/03-4M failed
Running test ../tests/03-8M ...
Test direct I/O with large transfer sizes and cmd_sg_entries=255
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/03-8M failed
Running test ../tests/04-4M ...
Test direct I/O with large transfer sizes and cmd_sg_entries=1
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/04-4M failed
Running test ../tests/04-8M ...
Test direct I/O with large transfer sizes and cmd_sg_entries=1
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/04-8M failed
Running test ../tests/05-4M ...
Test buffered I/O with large transfer sizes and cmd_sg_entries=255
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/05-4M failed
Running test ../tests/05-8M ...
Test buffered I/O with large transfer sizes and cmd_sg_entries=255
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/05-8M failed
Running test ../tests/06 ...
Test block I/O on top of multipath concurrently with logout and login (10 min)
Unloaded the ib_srp kernel module
SRP login failed
Test ../tests/06 failed
0 tests succeeded and 11 tests failed
Unloaded the ib_srpt kernel module
Unloaded the rdma_rxe kernel module

========= PASSED srp in 14s


May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: --------start up--------
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: read /etc/multipath.conf
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: path checkers start up
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: fail to get serial
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: using deprecated
getuid callout
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]:
/.../srp-test/bin/getuid_callout exited with 255
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: failed to get
callout uid: Input/output error
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdb: fail to get serial
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdb: using deprecated
getuid callout
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]:
/.../srp-test/bin/getuid_callout exited with 255
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdb: failed to get
callout uid: Input/output error
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdc: using deprecated
getuid callout
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]:
/.../srp-test/bin/getuid_callout exited with 255
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdc: failed to get
callout uid: Input/output error
May 22 22:13:46 moria-kvm-kvm-kvm-kvm systemd[1]: Started Device-Mapper
Multipath Device Controller.
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: reconfigure (operator)
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: fail to get serial
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: using deprecated
getuid callout
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]:
/.../srp-test/bin/getuid_callout exited with 255
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: failed to get
callout uid: Input/output error
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdb: fail to get serial
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdb: using deprecated
getuid callout
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]:
/.../srp-test/bin/getuid_callout exited with 255
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdb: failed to get
callout uid: Input/output error
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdc: using deprecated
getuid callout
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]:
/.../srp-test/bin/getuid_callout exited with 255
May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sdc: failed to get
callout uid: Input/output error

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"
  2018-05-23  2:16     ` Kent Overstreet
@ 2018-06-04  8:59       ` Bart Van Assche
  2018-06-04 22:41         ` Kent Overstreet
  0 siblings, 1 reply; 7+ messages in thread
From: Bart Van Assche @ 2018-06-04  8:59 UTC (permalink / raw)
  To: kent.overstreet; +Cc: hch, linux-block, axboe

T24gVHVlLCAyMDE4LTA1LTIyIGF0IDIyOjE2IC0wNDAwLCBLZW50IE92ZXJzdHJlZXQgd3JvdGU6
DQo+IE1heSAyMiAyMjoxMzo0NiBtb3JpYS1rdm0ta3ZtLWt2bS1rdm0gbXVsdGlwYXRoZFszODdd
OiBzZGE6IGZhaWwgdG8gZ2V0IHNlcmlhbA0KPiBNYXkgMjIgMjI6MTM6NDYgbW9yaWEta3ZtLWt2
bS1rdm0ta3ZtIG11bHRpcGF0aGRbMzg3XTogc2RhOiB1c2luZyBkZXByZWNhdGVkDQo+IGdldHVp
ZCBjYWxsb3V0DQo+IE1heSAyMiAyMjoxMzo0NiBtb3JpYS1rdm0ta3ZtLWt2bS1rdm0gbXVsdGlw
YXRoZFszODddOg0KPiAvLi4uL3NycC10ZXN0L2Jpbi9nZXR1aWRfY2FsbG91dCBleGl0ZWQgd2l0
aCAyNTUNCg0KKGJhY2sgZnJvbSB0cmF2ZWxpbmcpDQoNCkhlbGxvIEtlbnQsDQoNClBsZWFzZSBj
b21tZW50IG91dCB0aGUgZ2V0dWlkX2NhbGxvdXQgbGluZSBmcm9tIC9ldGMvbXVsdGlwYXRoLmNv
bmYgYW5kIHRyeSBhZ2Fpbi4NCkNoYW5naW5nIHRoZSAiLy4uLiIgcGFydCBpbnRvIHRoZSBwYXRo
IG9mIHRoZSBzcnAtdGVzdCBzb2Z0d2FyZSBzaG91bGQgYWxzbyBoZWxwLg0KVGhhdCBsaW5lIGlz
IGEgbGVmdC1vdmVyIGZyb20gdGhlIHRpbWUgd2hlbiB0aGUgTlZNZSBpbml0aWF0b3IgZHJpdmVy
cyBzdXBwb3J0ZWQNCmRtLW11bHRpcGF0aC4gSSB3aWxsIHVwZGF0ZSB0aGUgc3JwLXRlc3QgUkVB
RE1FLm1kIHRvIG1ha2UgdGhpcyBtb3JlIGNsZWFyLg0KDQpUaGFua3MsDQoNCkJhcnQuDQoNCg0K

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"
  2018-06-04  8:59       ` Bart Van Assche
@ 2018-06-04 22:41         ` Kent Overstreet
  2018-06-05 14:38           ` Bart Van Assche
  0 siblings, 1 reply; 7+ messages in thread
From: Kent Overstreet @ 2018-06-04 22:41 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: hch, linux-block, axboe

On Mon, Jun 04, 2018 at 08:59:39AM +0000, Bart Van Assche wrote:
> On Tue, 2018-05-22 at 22:16 -0400, Kent Overstreet wrote:
> > May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: fail to get serial
> > May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]: sda: using deprecated
> > getuid callout
> > May 22 22:13:46 moria-kvm-kvm-kvm-kvm multipathd[387]:
> > /.../srp-test/bin/getuid_callout exited with 255
> 
> (back from traveling)
> 
> Hello Kent,
> 
> Please comment out the getuid_callout line from /etc/multipath.conf and try again.
> Changing the "/..." part into the path of the srp-test software should also help.
> That line is a left-over from the time when the NVMe initiator drivers supported
> dm-multipath. I will update the srp-test README.md to make this more clear.

Deleted that line and it still doesn't work (I also tried fixing that line so
the path was correct, but got the same output as what I sent you earlier). With
that line deleted, the output is different. test output still says SRP login
failed, syslog says:

Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: --------start up--------
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: read /etc/multipath.conf
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: path checkers start up
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: sda: fail to get serial
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: sdb: fail to get serial
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: nbd0: HDIO_GETGEO failed with 25
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: nbd0: failed to get udev uid: Invalid argument
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: nbd1: HDIO_GETGEO failed with 25
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: nbd1: failed to get udev uid: Invalid argument
Jun 04 18:35:31 moria-kvm-kvm-kvm-kvm-kvm multipathd[453]: nbd10: HDIO_GETGEO failed with 25

etc.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"
  2018-06-04 22:41         ` Kent Overstreet
@ 2018-06-05 14:38           ` Bart Van Assche
  0 siblings, 0 replies; 7+ messages in thread
From: Bart Van Assche @ 2018-06-05 14:38 UTC (permalink / raw)
  To: kent.overstreet; +Cc: hch, linux-block, axboe

T24gTW9uLCAyMDE4LTA2LTA0IGF0IDE4OjQxIC0wNDAwLCBLZW50IE92ZXJzdHJlZXQgd3JvdGU6
DQo+IE9uIE1vbiwgSnVuIDA0LCAyMDE4IGF0IDA4OjU5OjM5QU0gKzAwMDAsIEJhcnQgVmFuIEFz
c2NoZSB3cm90ZToNCj4gPiBQbGVhc2UgY29tbWVudCBvdXQgdGhlIGdldHVpZF9jYWxsb3V0IGxp
bmUgZnJvbSAvZXRjL211bHRpcGF0aC5jb25mIGFuZCB0cnkgYWdhaW4uDQo+ID4gQ2hhbmdpbmcg
dGhlICIvLi4uIiBwYXJ0IGludG8gdGhlIHBhdGggb2YgdGhlIHNycC10ZXN0IHNvZnR3YXJlIHNo
b3VsZCBhbHNvIGhlbHAuDQo+ID4gVGhhdCBsaW5lIGlzIGEgbGVmdC1vdmVyIGZyb20gdGhlIHRp
bWUgd2hlbiB0aGUgTlZNZSBpbml0aWF0b3IgZHJpdmVycyBzdXBwb3J0ZWQNCj4gPiBkbS1tdWx0
aXBhdGguIEkgd2lsbCB1cGRhdGUgdGhlIHNycC10ZXN0IFJFQURNRS5tZCB0byBtYWtlIHRoaXMg
bW9yZSBjbGVhci4NCj4gDQo+IERlbGV0ZWQgdGhhdCBsaW5lIGFuZCBpdCBzdGlsbCBkb2Vzbid0
IHdvcmsgKEkgYWxzbyB0cmllZCBmaXhpbmcgdGhhdCBsaW5lIHNvDQo+IHRoZSBwYXRoIHdhcyBj
b3JyZWN0LCBidXQgZ290IHRoZSBzYW1lIG91dHB1dCBhcyB3aGF0IEkgc2VudCB5b3UgZWFybGll
cikuIFdpdGgNCj4gdGhhdCBsaW5lIGRlbGV0ZWQsIHRoZSBvdXRwdXQgaXMgZGlmZmVyZW50LiB0
ZXN0IG91dHB1dCBzdGlsbCBzYXlzIFNSUCBsb2dpbg0KPiBmYWlsZWQsIHN5c2xvZyBzYXlzOg0K
PiANCj4gSnVuIDA0IDE4OjM1OjMxIG1vcmlhLWt2bS1rdm0ta3ZtLWt2bS1rdm0gbXVsdGlwYXRo
ZFs0NTNdOiAtLS0tLS0tLXN0YXJ0IHVwLS0tLS0tLS0NCj4gSnVuIDA0IDE4OjM1OjMxIG1vcmlh
LWt2bS1rdm0ta3ZtLWt2bS1rdm0gbXVsdGlwYXRoZFs0NTNdOiByZWFkIC9ldGMvbXVsdGlwYXRo
LmNvbmYNCj4gSnVuIDA0IDE4OjM1OjMxIG1vcmlhLWt2bS1rdm0ta3ZtLWt2bS1rdm0gbXVsdGlw
YXRoZFs0NTNdOiBwYXRoIGNoZWNrZXJzIHN0YXJ0IHVwDQo+IEp1biAwNCAxODozNTozMSBtb3Jp
YS1rdm0ta3ZtLWt2bS1rdm0ta3ZtIG11bHRpcGF0aGRbNDUzXTogc2RhOiBmYWlsIHRvIGdldCBz
ZXJpYWwNCj4gSnVuIDA0IDE4OjM1OjMxIG1vcmlhLWt2bS1rdm0ta3ZtLWt2bS1rdm0gbXVsdGlw
YXRoZFs0NTNdOiBzZGI6IGZhaWwgdG8gZ2V0IHNlcmlhbA0KPiBKdW4gMDQgMTg6MzU6MzEgbW9y
aWEta3ZtLWt2bS1rdm0ta3ZtLWt2bSBtdWx0aXBhdGhkWzQ1M106IG5iZDA6IEhESU9fR0VUR0VP
IGZhaWxlZCB3aXRoIDI1DQo+IEp1biAwNCAxODozNTozMSBtb3JpYS1rdm0ta3ZtLWt2bS1rdm0t
a3ZtIG11bHRpcGF0aGRbNDUzXTogbmJkMDogZmFpbGVkIHRvIGdldCB1ZGV2IHVpZDogSW52YWxp
ZCBhcmd1bWVudA0KPiBKdW4gMDQgMTg6MzU6MzEgbW9yaWEta3ZtLWt2bS1rdm0ta3ZtLWt2bSBt
dWx0aXBhdGhkWzQ1M106IG5iZDE6IEhESU9fR0VUR0VPIGZhaWxlZCB3aXRoIDI1DQo+IEp1biAw
NCAxODozNTozMSBtb3JpYS1rdm0ta3ZtLWt2bS1rdm0ta3ZtIG11bHRpcGF0aGRbNDUzXTogbmJk
MTogZmFpbGVkIHRvIGdldCB1ZGV2IHVpZDogSW52YWxpZCBhcmd1bWVudA0KPiBKdW4gMDQgMTg6
MzU6MzEgbW9yaWEta3ZtLWt2bS1rdm0ta3ZtLWt2bSBtdWx0aXBhdGhkWzQ1M106IG5iZDEwOiBI
RElPX0dFVEdFTyBmYWlsZWQgd2l0aCAyNQ0KDQpUaGFua3MgZm9yIGhhdmluZyBzaGFyZWQgdGhp
cyBvdXRwdXQuIEluIHRoZSBtdWx0aXBhdGhkIHNvdXJjZSBjb2RlIEkgZm91bmQgdGhhdA0KdGhl
IGVycm9yIG1lc3NhZ2UgImZhaWwgdG8gZ2V0IHNlcmlhbCIgaXMgcHJvZHVjZWQgYnkgdGhlIGZv
bGxvd2luZyBjb2RlOg0KDQoJaWYgKGdldF92cGRfc3lzZnMocGFyZW50LCAweDgwLCBwcC0+c2Vy
aWFsLCBTRVJJQUxfU0laRSkgPD0gMCkgew0KCQlpZiAoZ2V0X3NlcmlhbChwcC0+c2VyaWFsLCBT
RVJJQUxfU0laRSwgcHAtPmZkKSkgew0KCQkJY29uZGxvZygyLCAiJXM6IGZhaWwgdG8gZ2V0IHNl
cmlhbCIsIHBwLT5kZXYpOw0KCQkJcmV0dXJuIDA7DQoJCX0NCgl9DQoNClRoZSBtZXNzYWdlICJm
YWlsIHRvIGdldCBzZXJpYWwiIGlzIG9ubHkgbG9nZ2VkIGlmIHJlYWRpbmcNCi9zeXMvY2xhc3Mv
c2NzaV9kZXZpY2UvKi8qLyovKi92cGRfcGc4MCBmYWlscyAqYW5kKiBzdWJtaXR0aW5nIGEgU0NT
SSBJTlFVSVJZDQpjb21tYW5kIHRocm91Z2ggdGhlIFNHX0lPIGludGVyZmFjZSBmYWlscy4gVGhp
cyBpcyBzb21ldGhpbmcgSSBoYXZlbid0IGVuY291bnRlcmVkDQpiZWZvcmUuIElzIHRoZXJlIHNv
bWV0aGluZyBzcGVjaWFsIGFib3V0IHRoZSBWTT8gV2FzIGUuZy4gbXVsdGlwYXRoZCBjb25maWd1
cmVkDQp0byBydW4gYXMgYW5vdGhlciB1c2VyIHRoYW4gcm9vdD8gSGF2ZSBzb21lIHNlY3VyaXR5
IHNldHRpbmdzIGJlZW4gY29uZmlndXJlZCB0aGF0DQpwcmV2ZW50IG11bHRpcGF0aGQgZnJvbSBh
Y2Nlc3Npbmcgc3lzZnMgYXR0cmlidXRlcz8gV2FzIFNDU0kgZ2VuZXJpYyBzdXBwb3J0DQpkaXNh
YmxlZCAoQ0hSX0RFVl9TRyk/DQoNClRoYW5rcywNCg0KQmFydC4NCg0KDQoNCg==

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-06-05 14:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 23:55 [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()" Bart Van Assche
2018-05-23  1:30 ` Kent Overstreet
2018-05-23  1:36   ` Bart Van Assche
2018-05-23  2:16     ` Kent Overstreet
2018-06-04  8:59       ` Bart Van Assche
2018-06-04 22:41         ` Kent Overstreet
2018-06-05 14:38           ` Bart Van Assche

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.