* [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
@ 2016-06-30 10:23 Jan Stancek
2016-07-01 9:30 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Jan Stancek @ 2016-06-30 10:23 UTC (permalink / raw)
To: tadeusz.struk, herbert; +Cc: qat-linux, linux-crypto, linux-kernel, jstancek
Parallel build can sporadically fail because asn1 headers may
not be built yet by the time qat_asym_algs.o is compiled:
drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
#include "qat_rsapubkey-asn1.h"
Signed-off-by: Jan Stancek <jstancek@redhat.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
---
drivers/crypto/qat/qat_common/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/qat/qat_common/Makefile b/drivers/crypto/qat/qat_common/Makefile
index 6d74b91f2152..5fc3dbb9ada0 100644
--- a/drivers/crypto/qat/qat_common/Makefile
+++ b/drivers/crypto/qat/qat_common/Makefile
@@ -2,6 +2,7 @@ $(obj)/qat_rsapubkey-asn1.o: $(obj)/qat_rsapubkey-asn1.c \
$(obj)/qat_rsapubkey-asn1.h
$(obj)/qat_rsaprivkey-asn1.o: $(obj)/qat_rsaprivkey-asn1.c \
$(obj)/qat_rsaprivkey-asn1.h
+$(obj)/qat_asym_algs.o: $(obj)/qat_rsapubkey-asn1.h $(obj)/qat_rsaprivkey-asn1.h
clean-files += qat_rsapubkey-asn1.c qat_rsapubkey-asn1.h
clean-files += qat_rsaprivkey-asn1.c qat_rsaprivkey-asn1.h
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
2016-06-30 10:23 [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Jan Stancek
@ 2016-07-01 9:30 ` Herbert Xu
2016-07-20 15:37 ` Thomas Backlund
0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2016-07-01 9:30 UTC (permalink / raw)
To: Jan Stancek
Cc: tadeusz.struk, qat-linux, linux-crypto, linux-kernel,
Salvatore Benedetto
On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote:
> Parallel build can sporadically fail because asn1 headers may
> not be built yet by the time qat_asym_algs.o is compiled:
> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
> #include "qat_rsapubkey-asn1.h"
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
Jan, Salvatore just posted a patch to delete the qat ASN code
altogether, so your patch won't be needed.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
2016-07-01 9:30 ` Herbert Xu
@ 2016-07-20 15:37 ` Thomas Backlund
2016-07-21 4:14 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Backlund @ 2016-07-20 15:37 UTC (permalink / raw)
To: Herbert Xu, Jan Stancek
Cc: tadeusz.struk, qat-linux, linux-crypto, linux-kernel,
Salvatore Benedetto
Den 01-07-2016 kl. 12:30, skrev Herbert Xu:
> On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote:
>> Parallel build can sporadically fail because asn1 headers may
>> not be built yet by the time qat_asym_algs.o is compiled:
>> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
>> #include "qat_rsapubkey-asn1.h"
>>
>> Signed-off-by: Jan Stancek <jstancek@redhat.com>
>> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>
> Jan, Salvatore just posted a patch to delete the qat ASN code
> altogether, so your patch won't be needed.
>
> Thanks,
>
Yeah, but that patch seem to be heading to 4.8 only , so qat build in
upcoming 4.7 still breaks...
and pulling that fix only to 4.7 breaks too, so I guess more fixes
would be needed for proper backport then...
or are the qat fixes already queued somewhere for 4.7 final ?
--
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
2016-07-20 15:37 ` Thomas Backlund
@ 2016-07-21 4:14 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2016-07-21 4:14 UTC (permalink / raw)
To: Thomas Backlund
Cc: Jan Stancek, tadeusz.struk, qat-linux, linux-crypto,
linux-kernel, Salvatore Benedetto
On Wed, Jul 20, 2016 at 06:37:07PM +0300, Thomas Backlund wrote:
>
> Yeah, but that patch seem to be heading to 4.8 only , so qat build
> in upcoming 4.7 still breaks...
>
> and pulling that fix only to 4.7 breaks too, so I guess more fixes
> would be needed for proper backport then...
>
> or are the qat fixes already queued somewhere for 4.7 final ?
You're right. This patch is probably the safest fix for 4.7.
I'll bounce it to stable.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-21 4:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-30 10:23 [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Jan Stancek
2016-07-01 9:30 ` Herbert Xu
2016-07-20 15:37 ` Thomas Backlund
2016-07-21 4:14 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.