All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] r8169: fix jumbo configuration for RTL8168evl
@ 2019-12-01  9:27 Heiner Kallweit
  2019-12-01 21:16 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-12-01  9:27 UTC (permalink / raw)
  To: David Miller, Realtek linux nic maintainers; +Cc: netdev, Alan J. Wylie

Alan reported [0] that network is broken since the referenced commit
when using jumbo frames. This commit isn't wrong, it just revealed
another issue that has been existing before. According to the vendor
driver the RTL8168e-specific jumbo config doesn't apply for RTL8168evl.

[0] https://lkml.org/lkml/2019/11/30/119

Fixes: 4ebcb113edcc ("r8169: fix jumbo packet handling on resume from suspend")
Reported-by: Alan J. Wylie <alan@wylie.me.uk>
Tested-by: Alan J. Wylie <alan@wylie.me.uk>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/ethernet/realtek/r8169_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 0b47db2ff..38d212686 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -3873,7 +3873,7 @@ static void rtl_hw_jumbo_enable(struct rtl8169_private *tp)
 	case RTL_GIGA_MAC_VER_27 ... RTL_GIGA_MAC_VER_28:
 		r8168dp_hw_jumbo_enable(tp);
 		break;
-	case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_34:
+	case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33:
 		r8168e_hw_jumbo_enable(tp);
 		break;
 	default:
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] r8169: fix jumbo configuration for RTL8168evl
  2019-12-01  9:27 [PATCH net] r8169: fix jumbo configuration for RTL8168evl Heiner Kallweit
@ 2019-12-01 21:16 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-01 21:16 UTC (permalink / raw)
  To: hkallweit1; +Cc: nic_swsd, netdev, alan

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 1 Dec 2019 10:27:14 +0100

> Alan reported [0] that network is broken since the referenced commit
> when using jumbo frames. This commit isn't wrong, it just revealed
> another issue that has been existing before. According to the vendor
> driver the RTL8168e-specific jumbo config doesn't apply for RTL8168evl.
> 
> [0] https://lkml.org/lkml/2019/11/30/119
> 
> Fixes: 4ebcb113edcc ("r8169: fix jumbo packet handling on resume from suspend")
> Reported-by: Alan J. Wylie <alan@wylie.me.uk>
> Tested-by: Alan J. Wylie <alan@wylie.me.uk>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied and queued up for -stable.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-01 21:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-01  9:27 [PATCH net] r8169: fix jumbo configuration for RTL8168evl Heiner Kallweit
2019-12-01 21:16 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.