From: Jane Chu <jane.chu@oracle.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
nvdimm@lists.linux.dev, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com
Cc: djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com,
hch@lst.de, agk@redhat.com, snitzer@redhat.com
Subject: Re: [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap
Date: Thu, 5 Aug 2021 18:00:52 -0700 [thread overview]
Message-ID: <a5580cf5-9fcc-252d-5835-f199469516b0@oracle.com> (raw)
In-Reply-To: <20210730100158.3117319-4-ruansy.fnst@fujitsu.com>
On 7/30/2021 3:01 AM, Shiyang Ruan wrote:
> - /*
> - * Prevent the inode from being freed while we are interrogating
> - * the address_space, typically this would be handled by
> - * lock_page(), but dax pages do not use the page lock. This
> - * also prevents changes to the mapping of this pfn until
> - * poison signaling is complete.
> - */
> - cookie = dax_lock_page(page);
> - if (!cookie)
> - goto out;
> -
> if (hwpoison_filter(page)) {
> rc = 0;
> - goto unlock;
> + goto out;
> }
why isn't dax_lock_page() needed for hwpoison_filter() check?
thanks,
-jane
WARNING: multiple messages have this Message-ID (diff)
From: Jane Chu <jane.chu@oracle.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
nvdimm@lists.linux.dev, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com
Cc: snitzer@redhat.com, djwong@kernel.org, david@fromorbit.com,
dan.j.williams@intel.com, hch@lst.de, agk@redhat.com
Subject: Re: [dm-devel] [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap
Date: Thu, 5 Aug 2021 18:00:52 -0700 [thread overview]
Message-ID: <a5580cf5-9fcc-252d-5835-f199469516b0@oracle.com> (raw)
In-Reply-To: <20210730100158.3117319-4-ruansy.fnst@fujitsu.com>
On 7/30/2021 3:01 AM, Shiyang Ruan wrote:
> - /*
> - * Prevent the inode from being freed while we are interrogating
> - * the address_space, typically this would be handled by
> - * lock_page(), but dax pages do not use the page lock. This
> - * also prevents changes to the mapping of this pfn until
> - * poison signaling is complete.
> - */
> - cookie = dax_lock_page(page);
> - if (!cookie)
> - goto out;
> -
> if (hwpoison_filter(page)) {
> rc = 0;
> - goto unlock;
> + goto out;
> }
why isn't dax_lock_page() needed for hwpoison_filter() check?
thanks,
-jane
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-06 1:01 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 10:01 [PATCH RESEND v6 0/9] fsdax: introduce fs query to support reflink Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-07-30 10:01 ` [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-06 1:17 ` Jane Chu
2021-08-06 1:17 ` [dm-devel] " Jane Chu
2021-08-16 17:20 ` Jane Chu
2021-08-16 17:20 ` [dm-devel] " Jane Chu
2021-08-17 1:44 ` ruansy.fnst
2021-08-17 1:44 ` [dm-devel] " ruansy.fnst
2021-08-18 5:43 ` Jane Chu
2021-08-18 5:43 ` [dm-devel] " Jane Chu
2021-08-18 6:08 ` Jane Chu
2021-08-18 6:08 ` [dm-devel] " Jane Chu
2021-08-18 7:52 ` ruansy.fnst
2021-08-18 7:52 ` [dm-devel] " ruansy.fnst
2021-08-18 17:10 ` Dan Williams
2021-08-18 17:10 ` [dm-devel] " Dan Williams
2021-08-18 17:10 ` Dan Williams
2021-08-23 13:21 ` hch
2021-08-23 13:21 ` [dm-devel] " hch
2021-08-18 15:52 ` Darrick J. Wong
2021-08-18 15:52 ` [dm-devel] " Darrick J. Wong
2021-08-19 7:18 ` Jane Chu
2021-08-19 7:18 ` [dm-devel] " Jane Chu
2021-08-19 8:11 ` Jane Chu
2021-08-19 8:11 ` [dm-devel] " Jane Chu
2021-08-19 9:10 ` ruansy.fnst
2021-08-19 9:10 ` [dm-devel] " ruansy.fnst
2021-08-19 20:50 ` Jane Chu
2021-08-19 20:50 ` [dm-devel] " Jane Chu
2021-08-20 16:07 ` Dan Williams
2021-08-20 16:07 ` Dan Williams
2021-08-20 16:07 ` [dm-devel] " Dan Williams
2021-07-30 10:01 ` [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-06 1:02 ` Jane Chu
2021-08-06 1:02 ` [dm-devel] " Jane Chu
2021-08-17 1:45 ` ruansy.fnst
2021-08-17 1:45 ` [dm-devel] " ruansy.fnst
2021-08-20 16:06 ` Dan Williams
2021-08-20 16:06 ` Dan Williams
2021-08-20 16:06 ` [dm-devel] " Dan Williams
2021-08-20 20:19 ` Dan Williams
2021-08-20 20:19 ` [dm-devel] " Dan Williams
2021-08-20 20:19 ` Dan Williams
2021-07-30 10:01 ` [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-06 1:00 ` Jane Chu [this message]
2021-08-06 1:00 ` Jane Chu
2021-08-20 16:54 ` Dan Williams
2021-08-20 16:54 ` [dm-devel] " Dan Williams
2021-08-20 16:54 ` Dan Williams
2021-07-30 10:01 ` [PATCH RESEND v6 4/9] pmem,mm: Implement ->memory_failure in pmem driver Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 4/9] pmem, mm: " Shiyang Ruan
2021-08-20 20:51 ` [PATCH RESEND v6 4/9] pmem,mm: " Dan Williams
2021-08-20 20:51 ` [dm-devel] [PATCH RESEND v6 4/9] pmem, mm: " Dan Williams
2021-08-20 20:51 ` [PATCH RESEND v6 4/9] pmem,mm: " Dan Williams
2021-07-30 10:01 ` [PATCH RESEND v6 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-06 0:59 ` Jane Chu
2021-08-06 0:59 ` [dm-devel] " Jane Chu
2021-08-20 22:40 ` Dan Williams
2021-08-20 22:40 ` [dm-devel] " Dan Williams
2021-08-20 22:40 ` Dan Williams
2021-07-30 10:01 ` [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-06 0:50 ` Jane Chu
2021-08-06 0:50 ` [dm-devel] " Jane Chu
2021-08-20 22:56 ` Dan Williams
2021-08-20 22:56 ` [dm-devel] " Dan Williams
2021-08-20 22:56 ` Dan Williams
2021-08-20 22:59 ` Dan Williams
2021-08-20 22:59 ` [dm-devel] " Dan Williams
2021-08-20 22:59 ` Dan Williams
2021-07-30 10:01 ` [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-20 23:46 ` Dan Williams
2021-08-20 23:46 ` [dm-devel] " Dan Williams
2021-08-20 23:46 ` Dan Williams
2021-07-30 10:01 ` [PATCH RESEND v6 8/9] md: Implement dax_holder_operations Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-06 0:48 ` Jane Chu
2021-08-06 0:48 ` [dm-devel] " Jane Chu
2021-08-17 1:59 ` ruansy.fnst
2021-08-17 1:59 ` [dm-devel] " ruansy.fnst
2021-07-30 10:01 ` [PATCH RESEND v6 9/9] fsdax: add exception for reflinked files Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan
2021-08-06 0:46 ` Jane Chu
2021-08-06 0:46 ` [dm-devel] " Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5580cf5-9fcc-252d-5835-f199469516b0@oracle.com \
--to=jane.chu@oracle.com \
--cc=agk@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.