From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> To: "jic23@kernel.org" <jic23@kernel.org>, "rodrigorsdc@gmail.com" <rodrigorsdc@gmail.com> Cc: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>, "kernel-usp@googlegroups.com" <kernel-usp@googlegroups.com>, "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "lars@metafoo.de" <lars@metafoo.de>, "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>, "Hennerich, Michael" <Michael.Hennerich@analog.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "knaack.h@gmx.de" <knaack.h@gmx.de> Subject: Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240 Date: Mon, 25 Nov 2019 07:51:30 +0000 [thread overview] Message-ID: <a55b9c576eded8c91a985aabbba89180561ab156.camel@analog.com> (raw) In-Reply-To: <20191123114119.7b0c3447@archlinux> On Sat, 2019-11-23 at 11:41 +0000, Jonathan Cameron wrote: > On Sat, 23 Nov 2019 02:19:27 -0300 > Rodrigo Carvalho <rodrigorsdc@gmail.com> wrote: > > > This patch add device tree binding documentation for ADIS16240. > > > > Signed-off-by: Rodrigo Ribeiro Carvalho <rodrigorsdc@gmail.com> My bad for the late timing on this. I'm slightly more fresh on Mondays. But I will get overloaded with work in a few hours, so I may not have time ot respond. > No problem with this patch, but I definitely want to see an accompanying > one enforcing the SPI mode in the driver. > So, then the binding should probably also define spi-cpol & spi-cpha as mandatory. Maybe, the driver would do a check and print a warning. I'm noticing that this device uses SPI mode 3, but this DT binding defaults to SPI mode 0 > Right now the driver doesn't set it and so I'm fairly sure not putting > it in the binding will leave you with a non working device. > > The right option if only one option is supported is for the driver > to call spi_setup with the relevant options. > What if the board uses some level inverters [because of some weird reason] and that messes up with the SPI mode? It's not common, but it is possible. > Thanks, > > Jonathan > > > --- > > V4: > > - Remove spi-cpha and spi-cpol in binding example, since this driver > > supports only one timing mode. > > .../bindings/iio/accel/adi,adis16240.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > new file mode 100644 > > index 000000000000..8e902f7c49e6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/accel/adi,adis16240.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ADIS16240 Programmable Impact Sensor and Recorder driver > > + > > +maintainers: > > + - Alexandru Ardelean <alexandru.ardelean@analog.com> > > + > > +description: | > > + ADIS16240 Programmable Impact Sensor and Recorder driver that > > supports > > + SPI interface. > > + https://www.analog.com/en/products/adis16240.html > > + > > +properties: > > + compatible: > > + enum: > > + - adi,adis16240 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + spi0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* Example for a SPI device node */ > > + accelerometer@0 { > > + compatible = "adi,adis16240"; > > + reg = <0>; > > + spi-max-frequency = <2500000>; > > + interrupt-parent = <&gpio0>; > > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > > + }; > > + };
WARNING: multiple messages have this Message-ID (diff)
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> To: "jic23@kernel.org" <jic23@kernel.org>, "rodrigorsdc@gmail.com" <rodrigorsdc@gmail.com> Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "lars@metafoo.de" <lars@metafoo.de>, "Hennerich, Michael" <Michael.Hennerich@analog.com>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel-usp@googlegroups.com" <kernel-usp@googlegroups.com>, "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>, "knaack.h@gmx.de" <knaack.h@gmx.de>, "Popa, Stefan Serban" <StefanSerban.Popa@analog.com> Subject: Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240 Date: Mon, 25 Nov 2019 07:51:30 +0000 [thread overview] Message-ID: <a55b9c576eded8c91a985aabbba89180561ab156.camel@analog.com> (raw) In-Reply-To: <20191123114119.7b0c3447@archlinux> On Sat, 2019-11-23 at 11:41 +0000, Jonathan Cameron wrote: > On Sat, 23 Nov 2019 02:19:27 -0300 > Rodrigo Carvalho <rodrigorsdc@gmail.com> wrote: > > > This patch add device tree binding documentation for ADIS16240. > > > > Signed-off-by: Rodrigo Ribeiro Carvalho <rodrigorsdc@gmail.com> My bad for the late timing on this. I'm slightly more fresh on Mondays. But I will get overloaded with work in a few hours, so I may not have time ot respond. > No problem with this patch, but I definitely want to see an accompanying > one enforcing the SPI mode in the driver. > So, then the binding should probably also define spi-cpol & spi-cpha as mandatory. Maybe, the driver would do a check and print a warning. I'm noticing that this device uses SPI mode 3, but this DT binding defaults to SPI mode 0 > Right now the driver doesn't set it and so I'm fairly sure not putting > it in the binding will leave you with a non working device. > > The right option if only one option is supported is for the driver > to call spi_setup with the relevant options. > What if the board uses some level inverters [because of some weird reason] and that messes up with the SPI mode? It's not common, but it is possible. > Thanks, > > Jonathan > > > --- > > V4: > > - Remove spi-cpha and spi-cpol in binding example, since this driver > > supports only one timing mode. > > .../bindings/iio/accel/adi,adis16240.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > new file mode 100644 > > index 000000000000..8e902f7c49e6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/accel/adi,adis16240.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ADIS16240 Programmable Impact Sensor and Recorder driver > > + > > +maintainers: > > + - Alexandru Ardelean <alexandru.ardelean@analog.com> > > + > > +description: | > > + ADIS16240 Programmable Impact Sensor and Recorder driver that > > supports > > + SPI interface. > > + https://www.analog.com/en/products/adis16240.html > > + > > +properties: > > + compatible: > > + enum: > > + - adi,adis16240 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + spi0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* Example for a SPI device node */ > > + accelerometer@0 { > > + compatible = "adi,adis16240"; > > + reg = <0>; > > + spi-max-frequency = <2500000>; > > + interrupt-parent = <&gpio0>; > > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > > + }; > > + }; _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-11-25 7:52 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-23 5:19 [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240 Rodrigo Carvalho 2019-11-23 5:19 ` Rodrigo Carvalho 2019-11-23 11:41 ` Jonathan Cameron 2019-11-23 11:41 ` Jonathan Cameron 2019-11-25 7:51 ` Ardelean, Alexandru [this message] 2019-11-25 7:51 ` Ardelean, Alexandru 2019-12-01 11:40 ` Jonathan Cameron 2019-12-01 11:40 ` Jonathan Cameron 2019-12-03 16:38 ` Mark Brown 2019-12-03 16:38 ` Mark Brown 2019-12-03 16:51 ` Jonathan Cameron 2019-12-03 16:51 ` Jonathan Cameron 2019-12-04 7:18 ` Ardelean, Alexandru 2019-12-04 7:18 ` Ardelean, Alexandru 2019-12-04 17:00 ` Mark Brown 2019-12-04 17:00 ` Mark Brown 2019-12-05 8:19 ` Ardelean, Alexandru 2019-12-05 8:19 ` Ardelean, Alexandru 2019-12-04 11:12 ` Mark Brown 2019-12-04 11:12 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a55b9c576eded8c91a985aabbba89180561ab156.camel@analog.com \ --to=alexandru.ardelean@analog.com \ --cc=Michael.Hennerich@analog.com \ --cc=StefanSerban.Popa@analog.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jic23@kernel.org \ --cc=kernel-usp@googlegroups.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=rodrigorsdc@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.