* [PATCH] vim2m: the v4l2_m2m_buf_copy_data args were swapped
@ 2019-01-11 11:43 Hans Verkuil
0 siblings, 0 replies; only message in thread
From: Hans Verkuil @ 2019-01-11 11:43 UTC (permalink / raw)
To: Linux Media Mailing List
The buffer arguments to v4l2_m2m_buf_copy_data args were swapped.
The reason is confusing naming conventions in vim2m. It certainly
could be improved.
Fixes: 7aca565ee3d0 ("media: vim2m: use v4l2_m2m_buf_copy_data")
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
index 33397d4a1402..a7a152fb3075 100644
--- a/drivers/media/platform/vim2m.c
+++ b/drivers/media/platform/vim2m.c
@@ -241,7 +241,7 @@ static int device_process(struct vim2m_ctx *ctx,
out_vb->sequence =
get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE)->sequence++;
in_vb->sequence = q_data->sequence++;
- v4l2_m2m_buf_copy_data(out_vb, in_vb, true);
+ v4l2_m2m_buf_copy_data(in_vb, out_vb, true);
switch (ctx->mode) {
case MEM2MEM_HFLIP | MEM2MEM_VFLIP:
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-11 11:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 11:43 [PATCH] vim2m: the v4l2_m2m_buf_copy_data args were swapped Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.