[PATCH] Staging: gasket: gasket_sysfs.c: Fix multiple string split issue.

[PATCH] Staging: gasket: gasket_sysfs.c: Fix multiple string split issue.

[Sanjana Sanikommu]

Remove string " across the line.
Issue found by checkpatch.pl semantic patch results for gasket_sysfs.c

WARNING:quoted string split across line.

Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
 drivers/staging/gasket/gasket_sysfs.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c
index fc45f0d13e87..a2d67c28f530 100644
--- a/drivers/staging/gasket/gasket_sysfs.c
+++ b/drivers/staging/gasket/gasket_sysfs.c
@@ -223,8 +223,7 @@ int gasket_sysfs_create_entries(struct device *device,
 
 	if (!mapping) {
 		dev_dbg(device,
-			"Creating entries for device without first "
-			"initializing mapping\n");
+			"Creating entries for device without first initializing mapping\n");
 		return -EINVAL;
 	}
 
@@ -233,8 +232,7 @@ int gasket_sysfs_create_entries(struct device *device,
 		i++) {
 		if (mapping->attribute_count == GASKET_SYSFS_MAX_NODES) {
 			dev_err(device,
-				"Maximum number of sysfs nodes reached for "
-				"device\n");
+				"Maximum number of sysfs nodes reached for device\n");
 			mutex_unlock(&mapping->mutex);
 			put_mapping(mapping);
 			return -ENOMEM;
@@ -264,8 +262,7 @@ void gasket_sysfs_remove_mapping(struct device *device)
 
 	if (!mapping) {
 		dev_err(device,
-			"Attempted to remove non-existent sysfs mapping to "
-			"device\n");
+			"Attempted to remove non-existent sysfs mapping to device\n");
 		return;
 	}
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] Staging: gasket: gasket_sysfs.c: Fix multiple string split issue.

[Julia Lawall]

The subject line is not correct.  You need to see what other people have
done to describe the affected files, using git log --oneline, rather than
making something up yourself.

On Mon, 18 Mar 2019, Sanjana Sanikommu wrote:

> Remove string " across the line.

The change looks ok, but the message is not understandable.  You don't
remove anything.  Everything that was in the code before is still there.

This could be "Concatenate a multi-line string constant into a single
line".

> Issue found by checkpatch.pl semantic patch results for gasket_sysfs.c

Just "Issue found by checkpatch" would be fine.  Check patch is a tool
that runs a bunch of perl regular expressions.  There are no semantic
patches involved.  And it is not necessary to mention the file name.  That
is apparent just below.

julia

>
> WARNING:quoted string split across line.
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
>  drivers/staging/gasket/gasket_sysfs.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c
> index fc45f0d13e87..a2d67c28f530 100644
> --- a/drivers/staging/gasket/gasket_sysfs.c
> +++ b/drivers/staging/gasket/gasket_sysfs.c
> @@ -223,8 +223,7 @@ int gasket_sysfs_create_entries(struct device *device,
>
>  	if (!mapping) {
>  		dev_dbg(device,
> -			"Creating entries for device without first "
> -			"initializing mapping\n");
> +			"Creating entries for device without first initializing mapping\n");
>  		return -EINVAL;
>  	}
>
> @@ -233,8 +232,7 @@ int gasket_sysfs_create_entries(struct device *device,
>  		i++) {
>  		if (mapping->attribute_count == GASKET_SYSFS_MAX_NODES) {
>  			dev_err(device,
> -				"Maximum number of sysfs nodes reached for "
> -				"device\n");
> +				"Maximum number of sysfs nodes reached for device\n");
>  			mutex_unlock(&mapping->mutex);
>  			put_mapping(mapping);
>  			return -ENOMEM;
> @@ -264,8 +262,7 @@ void gasket_sysfs_remove_mapping(struct device *device)
>
>  	if (!mapping) {
>  		dev_err(device,
> -			"Attempted to remove non-existent sysfs mapping to "
> -			"device\n");
> +			"Attempted to remove non-existent sysfs mapping to device\n");
>  		return;
>  	}
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190318134950.14056-1-sanjana99reddy99%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: gasket: gasket_sysfs.c: Fix multiple string split issue.

[sanjana99reddy99]

[-- Attachment #1.1: Type: text/plain, Size: 68 bytes --]


>
> I would change the log and subject line :)

Thanks 

Sanjana
 

[-- Attachment #1.2: Type: text/html, Size: 257 bytes --]