* [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype
@ 2021-06-01 15:41 Anthony PERARD
2021-06-02 8:25 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Anthony PERARD @ 2021-06-01 15:41 UTC (permalink / raw)
To: xen-devel; +Cc: Anthony PERARD, Ian Jackson, Wei Liu
Commit cf8c4d3d13b8 made some preparation to have one day
variable-length-array argument, but didn't declare the array in the
function prototype the same way as in the function definition. And now
GCC 11 complains about it.
Fixes: cf8c4d3d13b8 ("tools/libs/foreignmemory: pull array length argument to map forward")
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libs/foreignmemory/private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/foreignmemory/private.h b/tools/libs/foreignmemory/private.h
index 1ee3626dd278..5bb0cefb0987 100644
--- a/tools/libs/foreignmemory/private.h
+++ b/tools/libs/foreignmemory/private.h
@@ -32,7 +32,7 @@ int osdep_xenforeignmemory_close(xenforeignmemory_handle *fmem);
void *osdep_xenforeignmemory_map(xenforeignmemory_handle *fmem,
uint32_t dom, void *addr,
int prot, int flags, size_t num,
- const xen_pfn_t arr[num], int err[num]);
+ const xen_pfn_t arr[/*num*/], int err[/*num*/]);
int osdep_xenforeignmemory_unmap(xenforeignmemory_handle *fmem,
void *addr, size_t num);
--
Anthony PERARD
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype
2021-06-01 15:41 [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype Anthony PERARD
@ 2021-06-02 8:25 ` Jan Beulich
2021-06-15 13:31 ` PING " Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2021-06-02 8:25 UTC (permalink / raw)
To: Anthony PERARD, Ian Jackson; +Cc: Wei Liu, xen-devel
On 01.06.2021 17:41, Anthony PERARD wrote:
> Commit cf8c4d3d13b8 made some preparation to have one day
> variable-length-array argument, but didn't declare the array in the
> function prototype the same way as in the function definition. And now
> GCC 11 complains about it.
>
> Fixes: cf8c4d3d13b8 ("tools/libs/foreignmemory: pull array length argument to map forward")
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Ian - this (or whichever alternative might be chosen to address gcc11's
valid complaint) also will want backporting.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* PING Re: [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype
2021-06-02 8:25 ` Jan Beulich
@ 2021-06-15 13:31 ` Julien Grall
2021-06-15 17:12 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2021-06-15 13:31 UTC (permalink / raw)
To: Ian Jackson, Wei Liu; +Cc: xen-devel, Jan Beulich, Anthony PERARD
Hi Ian & Wei,
On 02/06/2021 10:25, Jan Beulich wrote:
> On 01.06.2021 17:41, Anthony PERARD wrote:
>> Commit cf8c4d3d13b8 made some preparation to have one day
>> variable-length-array argument, but didn't declare the array in the
>> function prototype the same way as in the function definition. And now
>> GCC 11 complains about it.
>>
>> Fixes: cf8c4d3d13b8 ("tools/libs/foreignmemory: pull array length argument to map forward")
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> Ian - this (or whichever alternative might be chosen to address gcc11's
> valid complaint) also will want backporting.
I was about to commit this patch and noticed that there is still a
missing an ack from the tools maintainers. @Ian, @Wei, can you provide one?
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PING Re: [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype
2021-06-15 13:31 ` PING " Julien Grall
@ 2021-06-15 17:12 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2021-06-15 17:12 UTC (permalink / raw)
To: Ian Jackson, Wei Liu; +Cc: xen-devel, Jan Beulich, Anthony PERARD
Hi,
On 15/06/2021 15:31, Julien Grall wrote:
> Hi Ian & Wei,
>
> On 02/06/2021 10:25, Jan Beulich wrote:
>> On 01.06.2021 17:41, Anthony PERARD wrote:
>>> Commit cf8c4d3d13b8 made some preparation to have one day
>>> variable-length-array argument, but didn't declare the array in the
>>> function prototype the same way as in the function definition. And now
>>> GCC 11 complains about it.
>>>
>>> Fixes: cf8c4d3d13b8 ("tools/libs/foreignmemory: pull array length
>>> argument to map forward")
>>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>
>> Ian - this (or whichever alternative might be chosen to address gcc11's
>> valid complaint) also will want backporting.
>
> I was about to commit this patch and noticed that there is still a
> missing an ack from the tools maintainers. @Ian, @Wei, can you provide one?
From an IRC discussion, Ian was happy to follow the rule:
"Commit something without the necessary acks if you're reasonably
certain that the maintainer would have approved it"
This doesn't seem to be part of MAINTAINERS, but I will use it for this
patch as Ian gave his assent.
This is committed now.
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-15 17:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 15:41 [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype Anthony PERARD
2021-06-02 8:25 ` Jan Beulich
2021-06-15 13:31 ` PING " Julien Grall
2021-06-15 17:12 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.